From 186b8352b50c8639aa6ff71b97ef5e3ce62e7581 Mon Sep 17 00:00:00 2001 From: Harsh Shandilya Date: Fri, 11 Mar 2022 10:54:51 +0530 Subject: [PATCH] Fix TOTP field flashing on each update (#1779) * Fix TOTP field flashing on each update * Add missing changelog entry --- CHANGELOG.md | 1 + app/src/main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivity.kt | 1 + .../main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivityV2.kt | 1 + 3 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 68db6e4a..4142ce74 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ All notable changes to this project will be documented in this file. - Introduce a new opt-in PGP backend powered by [PGPainless](https://github.com/pgpainless/pgpainless) that does not require OpenKeychain - Add the ability to run garbage collection on the internal Git repository - Introduce crash reporting backed by Sentry +- TOTP field now shows the remaining time for which it is valid ### Fixed diff --git a/app/src/main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivity.kt b/app/src/main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivity.kt index c6fda844..77abde2a 100644 --- a/app/src/main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivity.kt +++ b/app/src/main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivity.kt @@ -208,6 +208,7 @@ class DecryptActivity : BasePgpActivity(), OpenPgpServiceConnection.OnBound { val adapter = FieldItemAdapter(items, showPassword) { text -> copyTextToClipboard(text) } binding.recyclerView.adapter = adapter + binding.recyclerView.itemAnimator = null if (entry.hasTotp()) { entry.totp.onEach(adapter::updateOTPCode).launchIn(lifecycleScope) diff --git a/app/src/main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivityV2.kt b/app/src/main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivityV2.kt index 21cd42aa..424d5c46 100644 --- a/app/src/main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivityV2.kt +++ b/app/src/main/java/dev/msfjarvis/aps/ui/crypto/DecryptActivityV2.kt @@ -196,6 +196,7 @@ class DecryptActivityV2 : BasePgpActivity() { val adapter = FieldItemAdapter(items, showPassword) { text -> copyTextToClipboard(text) } binding.recyclerView.adapter = adapter + binding.recyclerView.itemAnimator = null if (entry.hasTotp()) { entry.totp.onEach(adapter::updateOTPCode).launchIn(lifecycleScope)