Delete HTTPS instead of SSH key password on error (#1060)

CHANGELOG.md

@@ -19,6 +19,7 @@ All notable changes to this project will be documented in this file.
 
 -   Password creation UI will scroll if it does not fit on the screen
 -   Git server protocol and authentication mode are only updated when explicitly saved
+-   Delete stored HTTPS password on connection errors (such as failed authentication)
 
 ## [1.11.2] - 2020-08-24
 

app/src/main/java/com/zeapo/pwdstore/git/operation/GitOperation.kt

@@ -151,7 +151,7 @@ abstract class GitOperation(gitDir: File, internal val callingActivity: Fragment
     open fun onError(err: Exception) {
         // Clear various auth related fields on failure
         callingActivity.getEncryptedPrefs("git_operation").edit {
-            remove(PreferenceKeys.SSH_KEY_LOCAL_PASSPHRASE)
+            remove(PreferenceKeys.HTTPS_PASSWORD)
         }
         callingActivity.sharedPrefs.edit { remove(PreferenceKeys.SSH_OPENKEYSTORE_KEYID) }
         d(err)