From 96fcc852d6c45e0e58159fe1c06e6db3d94d8fae Mon Sep 17 00:00:00 2001 From: yflory Date: Mon, 25 May 2020 15:29:18 +0200 Subject: [PATCH 1/2] Add a timeout for file upload if we can't make a thumbnail --- www/common/common-thumbnail.js | 32 +++++++++++++++++++++----------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/www/common/common-thumbnail.js b/www/common/common-thumbnail.js index 19b6713da..3f359d425 100644 --- a/www/common/common-thumbnail.js +++ b/www/common/common-thumbnail.js @@ -197,17 +197,27 @@ define([ }; Thumb.fromBlob = function (blob, _cb) { var cb = Util.once(_cb); - if (blob.type.indexOf('video/') !== -1) { - return void Thumb.fromVideoBlob(blob, cb); - } - if (blob.type.indexOf('application/pdf') !== -1) { - return void Thumb.fromPdfBlob(blob, cb); - } - if (Util.isPlainTextFile(blob.type, blob.name)) { - return void Thumb.fromPlainTextBlob(blob, cb); - } - if (blob.type.indexOf('image/') !== -1) { - return void Thumb.fromImageBlob(blob, cb); + // The blob is already in memory, it should be super-fast to make a thumbnail + // ==> 1s timeout + setTimeout(function () { + console.error("Thumbnail timeout"); + cb('TIMEOUT'); + }, 1000); + try { + if (blob.type.indexOf('video/') !== -1) { + return void Thumb.fromVideoBlob(blob, cb); + } + if (blob.type.indexOf('application/pdf') !== -1) { + return void Thumb.fromPdfBlob(blob, cb); + } + if (Util.isPlainTextFile(blob.type, blob.name)) { + return void Thumb.fromPlainTextBlob(blob, cb); + } + if (blob.type.indexOf('image/') !== -1) { + return void Thumb.fromImageBlob(blob, cb); + } + } catch (e) { + return void cb('THUMBNAIL_ERROR'); } return void cb('NO_THUMBNAIL'); }; From 6e8ed7529f77dca19d423117dd598dccf843213b Mon Sep 17 00:00:00 2001 From: yflory Date: Mon, 25 May 2020 16:07:58 +0200 Subject: [PATCH 2/2] Fix issue when renaming a shared folder in the drive --- www/common/proxy-manager.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/common/proxy-manager.js b/www/common/proxy-manager.js index e272070a4..df46cb884 100644 --- a/www/common/proxy-manager.js +++ b/www/common/proxy-manager.js @@ -826,8 +826,9 @@ define([ if (!resolved.id) { var el = Env.user.userObject.find(resolved.path); if (Env.user.userObject.isSharedFolder(el) && Env.folders[el]) { + var oldName = Env.folders[el].proxy.metadata.title; Env.folders[el].proxy.metadata.title = data.newName; - Env.user.proxy[UserObject.SHARED_FOLDERS][el].lastTitle = data.value; + Env.user.proxy[UserObject.SHARED_FOLDERS][el].lastTitle = oldName; return void cb(); } }