From a28a59abf0752a421495082ba03064f343e9b4fa Mon Sep 17 00:00:00 2001 From: ansuz Date: Mon, 17 Jul 2017 16:34:47 +0200 Subject: [PATCH] harden server further against bad channel ids --- rpc.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rpc.js b/rpc.js index e54362e98..73fb43736 100644 --- a/rpc.js +++ b/rpc.js @@ -28,8 +28,8 @@ var WARN = function (e, output) { }; var isValidId = function (chan) { - return chan && chan.length && /^[a-fA-F0-9]/.test(chan) || - [32, 48].indexOf(chan.length) !== -1; + return chan && chan.length && /^[a-fA-F0-9]/.test(chan) && + [32, 48].indexOf(chan.length) > -1; }; var uint8ArrayToHex = function (a) {