blitzwing/cryptpad
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix leaky variable in chainpad

Browse source 
Patch.transform declared a 'toTransform' variable without using 'var'
this caused it to leak onto the window during operational transformations
This commit is contained in:
ansuz 2016-04-12 09:52:36 +02:00
parent 05108efdfa
commit 4ba68eb2bf
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
www/common/chainpad.js
View file

@ -220,7 +220,7 @@ var transform = Patch.transform = function (origToTransform, transformBy, doc, t
Common.assert(origToTransform.parentHash === transformBy.parentHash);
var resultOfTransformBy = apply(transformBy, doc);
toTransform = clone(origToTransform);
var toTransform = clone(origToTransform);
var text = doc;
for (var i = toTransform.operations.length-1; i >= 0; i--) {
/* this line caused diffs to be applied against the incorrect text