blitzwing/cryptpad
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Phantom viewers potential fix

Browse source
This commit is contained in:
yflory 2018-08-28 16:28:26 +02:00
parent 0e1c525c30
commit 256b7b5bb4
2 changed files with 47 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
www/common/cryptpad-common.js
View file

@ -1016,7 +1016,17 @@ define([
cb();
};
/*var onPing = function (data, cb) {
cb();
};
var onTimeout = function () {
//alert("Timeout");
};*/
var queries = {
/*PING: onPing,
TIMEOUT: onTimeout,*/
REQUEST_LOGIN: requestLogin,
UPDATE_METADATA: common.changeMetadata,
UPDATE_TOKEN: function (data) {

37
www/common/outer/async-store.js
View file

@ -1558,6 +1558,43 @@ define([
rt.proxy.on('reconnect', function (info) {
broadcast([], 'NETWORK_RECONNECT', {myId: info.myId});
});
/*
// Ping clients regularly to make sure one tab was not closed without sending a removeClient()
// command. This allow us to avoid phantom viewers in pads.
var PING_INTERVAL = 30000;
var MAX_PING = 1000;
var MAX_FAILED_PING = 5;
setInterval(function () {
var clients = [];
Object.keys(Store.channels).forEach(function (chanId) {
var c = Store.channels[chanId].clients;
Array.prototype.push.apply(clients, c);
});
clients = Util.deduplicateString(clients);
clients.forEach(function (cId) {
var nb = 0;
var ping = function () {
nb++;
if (nb >= MAX_FAILED_PING) {
Store._removeClient(cId);
postMessage(cId, 'TIMEOUT');
console.error('TIMEOUT 5 errors');
return;
}
var to = setTimeout(ping, MAX_PING);
console.log('ping');
postMessage(cId, 'PING', null, function () {
console.log('pong');
clearTimeout(to);
});
};
ping();
});
}, PING_INTERVAL);
*/
};
/**