From b8eb70874866335b8a2ccb09be4612d150268672 Mon Sep 17 00:00:00 2001
From: wukko <me@wukko.me>
Date: Sat, 27 Jul 2024 15:28:02 +0600
Subject: [PATCH] web/DialogHolder: fix typescript error, add a note

---
 web/src/components/dialog/DialogHolder.svelte | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/web/src/components/dialog/DialogHolder.svelte b/web/src/components/dialog/DialogHolder.svelte
index 7a481d42..b715a485 100644
--- a/web/src/components/dialog/DialogHolder.svelte
+++ b/web/src/components/dialog/DialogHolder.svelte
@@ -8,16 +8,18 @@
     $: backdropVisible = $dialogs.length > 0;
 </script>
 
+<!--
+    this is the cleanest way of passing props without typescript throwing a fit.
+    more info here: https://github.com/microsoft/TypeScript/issues/46680
+-->
 <div id="dialog-holder">
     {#each $dialogs as dialog}
-        {@const { type, ...data } = dialog}
-
-        {#if type === "small"}
-            <SmallDialog {...data} />
-        {:else if type === "picker"}
-            <PickerDialog {...data} />
-        {:else if type === "saving"}
-            <SavingDialog {...data} />
+        {#if dialog.type === "small"}
+            <SmallDialog {...dialog} />
+        {:else if dialog.type === "picker"}
+            <PickerDialog {...dialog} />
+        {:else if dialog.type === "saving"}
+            <SavingDialog {...dialog} />
         {/if}
     {/each}
     <div id="dialog-backdrop" class:visible={backdropVisible}></div>