api: make deepsource happy

api/src/security/api-keys.js

@@ -117,6 +117,10 @@ const formatKeys = (keyData) => {
     return formatted;
 }
 
+const updateKeys = (newKeys) => {
+    keys = formatKeys(newKeys);
+}
+
 const loadKeys = async (source) => {
     let updated;
     if (source.protocol === 'file:') {
@@ -138,10 +142,6 @@ const loadKeys = async (source) => {
     updateKeys(updated);
 }
 
-const updateKeys = (newKeys) => {
-    keys = formatKeys(newKeys);
-}
-
 const wrapLoad = (url, initial = false) => {
     loadKeys(url)
     .then(() => {

api/src/security/secrets.js

@@ -15,15 +15,19 @@ export const syncSecrets = () => {
     return new Promise((resolve, reject) => {
         if (cluster.isPrimary) {
             let remaining = Object.values(cluster.workers).length;
-
-            for (const worker of Object.values(cluster.workers)) {
-                worker.once('message', (m) => {
+            const handleReady = (worker, m) => {
                 if (m.ready)
                     worker.send({ rateSalt, streamSalt });
 
                 if (!--remaining)
                     resolve();
-                });
+            }
+
+            for (const worker of Object.values(cluster.workers)) {
+                worker.once(
+                    'message',
+                    (m) => handleReady(worker, m)
+                );
             }
         } else if (cluster.isWorker) {
             if (rateSalt || streamSalt)

api/src/store/base-store.js

@@ -13,7 +13,7 @@ export class Store {
         this.id = name;
     }
 
-    async _has(_key) { throw "needs implementation" }
+    async _has(_key) { await Promise.reject("needs implementation"); }
     has(key) {
         if (typeof key !== 'string') {
             key = key.toString();
@@ -22,7 +22,7 @@ export class Store {
         return this._has(key);
     }
 
-    async _get(_key) { throw "needs implementation" }
+    async _get(_key) { await Promise.reject("needs implementation"); }
     async get(key) {
         if (typeof key !== 'string') {
             key = key.toString();
@@ -35,7 +35,7 @@ export class Store {
         return val;
     }
 
-    async _set(_key, _val, _exp_sec = -1) { throw "needs implementation" }
+    async _set(_key, _val, _exp_sec = -1) { await Promise.reject("needs implementation") }
     set(key, val, exp_sec = -1) {
         if (typeof key !== 'string') {
             key = key.toString();

api/src/store/memory-store.js

@@ -14,17 +14,17 @@ export default class MemoryStore extends Store {
         super(name);
     }
 
-    async _has(key) {
+    _has(key) {
         return this.#store.has(key);
     }
 
-    async _get(key) {
+    _get(key) {
         const val = this.#store.get(key);
 
         return val === undefined ? null : val;
     }
 
-    async _set(key, val, exp_sec = -1) {
+    _set(key, val, exp_sec = -1) {
         if (this.#store.has(key)) {
             this.#timeouts.remove(o => o.k === key);
         }