From 0bb84f0e98d96ae64b3538eb275fb16f66bbdc4a Mon Sep 17 00:00:00 2001 From: dumbmoron <136796770+dumbmoron@users.noreply.github.com> Date: Sat, 16 Sep 2023 21:25:36 +0000 Subject: [PATCH] fix soundcloud downloads when requested format is `best` --- src/modules/processing/matchActionDecider.js | 7 ++++++- src/modules/processing/servicesConfig.json | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/modules/processing/matchActionDecider.js b/src/modules/processing/matchActionDecider.js index 82eb3415..32ce4a52 100644 --- a/src/modules/processing/matchActionDecider.js +++ b/src/modules/processing/matchActionDecider.js @@ -126,7 +126,12 @@ export default function(r, host, audioFormat, isAudioOnly, lang, isAudioMuted, d } if ((audioFormat === "best" && services[host]["bestAudio"]) || (services[host]["bestAudio"] && (audioFormat === services[host]["bestAudio"]))) { audioFormat = services[host]["bestAudio"]; - processType = "bridge" + if (host === "soundcloud") { + processType = "render" + copy = true + } else { + processType = "bridge" + } } else if (audioFormat === "best") { audioFormat = "m4a"; copy = true; diff --git a/src/modules/processing/servicesConfig.json b/src/modules/processing/servicesConfig.json index c7e62a1e..95ec5509 100644 --- a/src/modules/processing/servicesConfig.json +++ b/src/modules/processing/servicesConfig.json @@ -49,7 +49,7 @@ }, "soundcloud": { "patterns": [":author/:song/s-:accessKey", ":author/:song", ":shortLink"], - "bestAudio": "none", + "bestAudio": "opus", "enabled": true }, "instagram": {