web/onDemand: check blockId is string, early return if not
This commit is contained in:
parent
479e14778d
commit
315ddb17c1
1 changed files with 35 additions and 34 deletions
|
@ -26,7 +26,13 @@ export async function runWeb(express, app, gitCommit, gitBranch, __dirname) {
|
|||
|
||||
app.get('/onDemand', (req, res) => {
|
||||
try {
|
||||
if (req.query.blockId) {
|
||||
if (typeof req.query.blockId !== 'string') {
|
||||
return res.status(400).json({
|
||||
status: "error",
|
||||
text: "couldn't render this block, please try again!"
|
||||
});
|
||||
}
|
||||
|
||||
let blockId = req.query.blockId.slice(0, 3);
|
||||
let blockData;
|
||||
switch(blockId) {
|
||||
|
@ -54,17 +60,12 @@ export async function runWeb(express, app, gitCommit, gitBranch, __dirname) {
|
|||
})
|
||||
break;
|
||||
}
|
||||
|
||||
if (blockData?.body) {
|
||||
return res.status(blockData.status).json(blockData.body);
|
||||
} else {
|
||||
return res.status(204).end();
|
||||
}
|
||||
} else {
|
||||
return res.status(400).json({
|
||||
status: "error",
|
||||
text: "couldn't render this block, please try again!"
|
||||
});
|
||||
}
|
||||
} catch {
|
||||
return res.status(400).json({
|
||||
status: "error",
|
||||
|
|
Loading…
Reference in a new issue