Haocen Xu
74551f58d7
Avoid DOMPurify mess with forward slash in expirationDateString
2020-05-30 05:52:15 -04:00
Haocen Xu
4984194c33
Avoid dropzone appearing when it should not by fixing
...
TopNav.isAttachmentReadonly logic
2020-05-30 05:48:15 -04:00
Haocen Xu
d6b06269a4
Fix Editor.hide typo
2020-05-30 05:47:33 -04:00
Haocen Xu
7eb96eb3cb
Avoid handling clipboard data item if it is not file type
2020-05-30 05:39:46 -04:00
rugk
d3ba7eeb13
Reset checkboxes on new paste
2020-04-23 12:07:08 +02:00
rugk
5ece4d2632
Reset attachment when clicking new paste
2020-04-23 11:25:24 +02:00
El RIDO
c63dc3df7b
increase timeout for nyc JS code coverage generator
2020-03-22 06:56:18 +01:00
El RIDO
9914c37683
incrementing version
2020-03-22 06:44:04 +01:00
El RIDO
1439bb291f
allow pasting password on paste with attachment - big kudos @rugk for finding it! - fixes #565 , fixes #595
2020-03-21 16:53:55 +01:00
El RIDO
71c76adac4
addressing false positive jsverify rngState 077c06da821594b3fe
2020-03-06 23:00:48 +01:00
rugk
7cb830e22f
It includes a change in the RegEx for URLs because that was broken when a
...
& character later followed at any time after a link (even after a newline).
(with a negative lookahead)
Test with https://regex101.com/r/i7bZ73/1
Now the RegEx does not check for _all_ chars after a link, but just for the
one following the link.
(So the lookahead is not * anymore. I guess thsi behaviour was
the expectation when it has been implemented.)
2020-03-06 22:37:12 +01:00
El RIDO
c334d2d00d
Merge branch 'master' into preview-encoding
2020-03-06 22:23:40 +01:00
El RIDO
c11dc8e17e
reverting Helper.urls2links() method to old style, applied to element instead of string, allows inserting plain text as text node
2020-03-06 22:18:38 +01:00
El RIDO
8a6dcf910a
Revert "in Helper.urls2links(), encode HTML entities, find and insert links, partially decoding only the href property of it"
...
This reverts commit 5340f417e0
2020-03-06 20:57:15 +01:00
El RIDO
f391773c65
generalize date string handling, replacing hardcoded lookups, fixes #586
2020-03-01 08:54:48 +01:00
El RIDO
5340f417e0
in Helper.urls2links(), encode HTML entities, find and insert links, partially decoding only the href property of it
2020-02-29 09:37:54 +01:00
El RIDO
d2e9e47b67
refactor switch into nested if/else, to improve readability - no functional change
2020-02-29 08:45:56 +01:00
El RIDO
adece1d784
incrementing version
2020-02-16 11:15:51 +01:00
El RIDO
12c83a13c7
addressing false positive jsverify rngState 85f362db8950cea741
2020-02-05 19:06:45 +01:00
El RIDO
bab95cce1b
addressing false positive jsverify rngState 8bf7605ea139db4c28
2020-02-04 18:58:24 +01:00
El RIDO
00438ec1ab
upgrade DOMpurify to 2.0.8
2020-02-04 18:43:35 +01:00
El RIDO
2cbb8bf3ca
in translation, allow links to be inserted unencoded into href attribute, simplfy sanitation by allowing only <a> tags in DOMpurify for plain text and comments and avoid DOMpurify removing magnet links, fixes #579
2020-02-02 07:08:38 +01:00
El RIDO
3996f82404
relax encoding of slashes just for plaintext display, so links can be detected
2020-02-01 16:30:41 +01:00
El RIDO
cc0920fc09
add HTML entity encoding to PHP translation logic, remove exception to allow <br/> tags in DOMpurify by eliminating the single case that made use of it
2020-02-01 08:46:59 +01:00
El RIDO
91003d6597
Merge remote-tracking branch 'origin/master' into displayEncoding
2020-02-01 07:52:48 +01:00
El RIDO
9a4018bffe
jsverify rngState 8270695ec83abf412d was a false positive, due to incorrect test logic
2020-02-01 07:40:14 +01:00
El RIDO
8a6415ef5f
fixing jsverify rngStates 0220439df7ec68a15b, 015c81b7afd06e4293 & 041e3d57692b08fc4a
2020-01-31 22:42:42 +01:00
Erion
3f8cf1792d
Switch to single quotes.
2020-01-26 18:08:59 +01:00
Erion
f6899785a9
Fix ARIA for Editor/preview tabs.
2020-01-25 18:47:18 +01:00
El RIDO
2d11d7b29e
re-applying sprintf simplification and rephrased jsdoc block
2020-01-25 09:16:14 +01:00
El RIDO
29efc14aa7
Revert "implement simplified translation logic, forcing the use of safe application via jQuery element"
...
This reverts commit 62365880b4
2020-01-25 09:07:29 +01:00
El RIDO
62365880b4
implement simplified translation logic, forcing the use of safe application via jQuery element
2020-01-25 09:07:06 +01:00
El RIDO
aa3f1206b2
rewriting translations to pass jQuery element where easily possible
2020-01-25 08:13:36 +01:00
El RIDO
42130e0468
prevent potentially non-encoded string from getting returned
2020-01-18 10:53:58 +01:00
El RIDO
685c354d0e
several changes:
...
- added tests for all 4 cases: output to string or into element vs first param contains link or not
- cleaned up logic - skip HTML entity encoding only if we can ensure insertion to text node / when output to string, we always encode
- DOMpurify sanitizes gopher, ws & wss links, which we previosly had tested for
2020-01-18 10:44:35 +01:00
El RIDO
fa9d3037ba
fixing logic & indentation
2020-01-18 07:44:32 +01:00
El RIDO
7b87dc3ca9
cleanup revert
2020-01-18 07:36:43 +01:00
El RIDO
0d08edbe55
Revert "getting rid of htmlEntities (except for tests)" a0740ff79f
2020-01-18 07:30:01 +01:00
El RIDO
cec5cb41d7
Partial revert "Do not double-encode HTML in i18n", only revert the removal of required encoding logic - still has to be moved
...
This reverts commit 01414e43ca
2020-01-18 07:20:05 +01:00
El RIDO
76eff6a87a
Revert "[TEST] Try to disallow vulnerable cases" to remove accidentally committed file and statement that breaks the tests
...
This reverts commit ebc2d649c4
2020-01-18 07:12:03 +01:00
El RIDO
fd4492f229
ensuring that both critical branches get tested
2020-01-18 07:09:56 +01:00
rugk
eb549d70d1
Invert conatainsLink logic
2020-01-15 17:52:51 +01:00
rugk
ebc2d649c4
[TEST] Try to disallow vulnerable cases
2020-01-13 19:56:15 +01:00
rugk
01414e43ca
Do not double-encode HTML in i18n
...
This issue got introduced in 4bf7f86https://github.com/PrivateBin/PrivateBin/issues/557
Fixes https://github.com/PrivateBin/PrivateBin/issues/558
Also _inverted_ the logic/variable name for containsNoLinks to
the more logical one "containsLinks" to avoid too many negations.
Also verified that the attachment name is stil properly displayed
when you clone a paste.
2020-01-13 19:17:30 +01:00
El RIDO
599264e167
partially address #556 - now comments can only be added after successfull decryption
2020-01-08 19:48:42 +01:00
El RIDO
ed590ee557
incrementing version
2020-01-08 19:31:06 +01:00
El RIDO
ef8943d838
upgrading base-x library to 3.0.7
2020-01-07 20:11:12 +01:00
El RIDO
2fd649db14
upgrading showdown to released 1.9.1 version
2020-01-07 19:58:05 +01:00
El RIDO
a9bf667f8e
address error, displayed when paste has attachment, but configuration has them disabled
2020-01-04 13:33:03 +01:00
El RIDO
4bf7f863dc
more general solution addressing #554 , kudos @rugk for the suggestions
2020-01-04 13:14:53 +01:00
El RIDO
8d0ac336d2
addressing jsverifyRngState 8b8f0d4ec2a67139b5, fixes HTML injection via filename, closes #554
2019-12-25 09:14:32 +01:00
Haocen Xu
853fd906cb
Fix unnecessary closure capture
2019-11-21 17:43:10 -05:00
El RIDO
af8d963fd2
updating DOMpurify library, fixes #523
2019-11-02 17:31:45 +01:00
El RIDO
8cf0c86ebb
simplify case statement, update documentation
2019-11-02 17:18:22 +01:00
El RIDO
b23fd48d49
Merge branch 'master' of https://github.com/AndriiZ/PrivateBin into AndriiZ-master
2019-11-02 17:11:05 +01:00
Haocen Xu
e079f6c830
Implement Email button
2019-10-31 15:07:13 -04:00
Haocen Xu
63fdd2eba3
Fix missing semi colon
2019-10-30 14:04:10 -04:00
Haocen Xu
56222d6cfb
Bugfix when password is disabled in config no new paste can be
...
created
2019-10-25 13:05:09 -04:00
Andriy Zhuk
65b7077756
Added plural rules for ukrainian
2019-10-18 12:31:40 +03:00
El RIDO
71797d1dd4
changes required for jsdoc, adding legacy.js to code coverage
2019-09-22 21:18:19 +02:00
El RIDO
2d4edfe401
incrementing version number in preparation of release
2019-09-22 19:42:04 +02:00
El RIDO
e9eeeacdf0
addressing jsverifyRngState 0f5ea3f961827b0c4d
2019-09-19 20:48:05 +02:00
El RIDO
8da382f7c6
Merge branch 'master' into better-feature-detection
2019-09-19 20:19:35 +02:00
El RIDO
28d70a1b18
upgrading DOMpurify, fixes #520
2019-09-19 20:13:47 +02:00
El RIDO
955317d924
make codacy a bit happier
2019-09-19 19:47:19 +02:00
El RIDO
7c61f59dcd
removing untranslated string for non-human entities, moving insecure notice to template, so it can remains translated
2019-09-19 19:14:48 +02:00
El RIDO
70c38db81d
adding ES6 and async feature detection to correctly flag old chromes and operas with the modern browser error
2019-09-18 07:47:26 +02:00
El RIDO
4332d0edb0
making legacy.js work even on IE 6 by avoiding jQuery
2019-09-18 07:31:32 +02:00
El RIDO
5810f17c31
fixing HTTP only error detection in Chrome and Android by ensuring all logic is contained in legacy.js
2019-09-17 21:41:25 +02:00
El RIDO
1a42158dd1
address Codacy's concern about missing semicolons
2019-09-14 09:53:22 +02:00
El RIDO
713ce148a4
address Codacy's concern that i is already defined
2019-09-14 09:50:47 +02:00
El RIDO
63426d6f8b
splitting out PrivateBin.InitialCheck class into Legacy.Check and working on making it compatible with IE 11
2019-09-14 09:41:52 +02:00
El RIDO
c2962af4f8
trying different approach to convince codacy about false positive
2019-09-08 09:08:21 +02:00
El RIDO
b1c9ca65fa
trying to address eslint false positives
2019-09-08 08:39:28 +02:00
El RIDO
5471757fa7
making webassembly optional, ensuring retry button works when wrong password is provided
...
Tested configurations:
- browser with WASM support (Firefox 68.0.2)
- creates paste with zlib compression, no password
- creates paste with zlib compression, with password
- reads paste with zlib compression, no password
- reads paste with zlib compression, with password + retry button works
- reads paste without compression, no password
- reads paste without compression, with password + retry button works
- browser without WASM support (Chromium 76.0.3809.100, started via `chromium-browser --js-flags=--noexpose_wasm`)
- creates paste without compression, no password, but shows WASM warning
- creates paste without compression, with password, but shows WASM warning
- fails to read paste with zlib compression, no password + shows WASM error
- fails to read paste with zlib compression, with password + shows WASM error
- reads paste without compression, no password
- reads paste without compression, with password + retry button works
2019-09-08 08:21:54 +02:00
El RIDO
813e72d871
don't encode HTML entities in translations if they contain links
2019-08-28 20:37:14 +02:00
El RIDO
c56d777c11
fixing logic when there are no icons and warning icons, add more test cases
2019-08-28 20:29:23 +02:00
El RIDO
7f65fe9218
fixing conflicting icons when using error message div for warnings in bootstrap template
2019-08-28 19:25:11 +02:00
El RIDO
ad570c391a
extend Alert class unit testing
2019-08-28 19:23:58 +02:00
El RIDO
a6aef109cc
making feature detection work as intended in chrome
2019-08-27 23:16:06 +02:00
El RIDO
6fcd82fb85
making the feature detection more robust, let users with no WASM create uncompressed pastes, remove dead & duplicate code
2019-08-27 07:38:27 +02:00
Haocen Xu
00b886c492
Refactor attachment editable logic to avoid undesired assumption
2019-08-25 12:00:59 -04:00
El RIDO
ad096b80a1
refactoring logic, to make intention more clear and reduce complexity
2019-08-25 17:24:22 +02:00
Haocen Xu
ab75b183fb
Fix click on new paste on clone paste editing view not removing custom
...
attachment
Fix cloning paste with attachment
Update CSP in sample and default configuration
Ensure clone paste also clone format
Fix clone button hiding logic when paste is burn after read
Remove attachment name when new paste clicked on
Enable file operation only when editing
2019-08-25 02:16:58 -04:00
El RIDO
121b1e75d2
remove debug statement, fixes #462
2019-08-24 08:42:33 +02:00
Haocen Xu
2eed7a8a1c
Update SRI
...
Remove dejavu
2019-08-17 15:39:13 -04:00
Haocen Xu
078b8d8fd6
Clear attachment if user cancel file select
2019-08-17 15:14:40 -04:00
Haocen Xu
3a9730f883
Improve file upload UX
...
Fix incorrect highlight logic
Fix transition on fileupload highlight
Handle drag leave
Fix draghover
Minor style improvements
2019-08-17 15:13:58 -04:00
El RIDO
30ddcacca6
fixing unit tests
2019-08-17 10:20:46 +02:00
El RIDO
e7fab8439d
documenting showdown fix and incrementing library version to circumvent browser caching
2019-08-17 10:04:54 +02:00
El RIDO
f22449ffd1
Merge branch 'fix-showdown' of https://github.com/macropin/PrivateBin into macropin
2019-08-17 09:59:44 +02:00
Andrew Cutler
49b358b1ee
patch showdown.js to allow 100 nested spans. Ref https://github.com/PrivateBin/PrivateBin/issues/485
2019-08-15 13:41:41 +10:00
Haocen Xu
71931b0f18
Clear discussion if new/clone paste clicked
2019-08-14 20:40:50 -04:00
Haocen Xu
1af7b536a5
Fix an edge case where we cannot find any shortUrl
2019-08-14 00:06:51 -04:00
Haocen Xu
a5cd8696e6
Ensure shortener button re-enable after creating new paste
2019-08-13 21:55:35 -04:00
Haocen Xu
cd5ede5670
Enhance URL shortener integration, clear address bar when create new paste from existing paste
2019-08-13 21:44:53 -04:00
El RIDO
d63a0d10d3
fixing npm package version number
2019-07-27 08:11:29 +02:00
El RIDO
b0d1a3949e
add bulgarian to the supported languages
2019-07-11 16:50:32 +02:00
El RIDO
07018e5876
incrementing version number in preparation of release
2019-07-08 18:35:34 +02:00
El RIDO
c707c87cac
addressing rngState 0ef2c5e06719a8b43d
2019-06-27 21:37:40 +02:00
El RIDO
2cbf528894
fixing failing unit tests in travisCI
2019-06-27 21:18:46 +02:00
El RIDO
67b9b5f0d8
correcting old browser detection logic, fixes #446
2019-06-27 20:11:22 +02:00
El RIDO
fdc532b3c1
simplify npm install instructions
2019-06-24 07:41:12 +02:00
El RIDO
ddb1c550f5
remove alerts when missing showdown & prettify libraries, if the are missing it is intentionally done in the configuration, fixes #237
2019-06-23 19:55:25 +02:00
El RIDO
c2e060d464
made compression configurable, fixes #38
2019-06-23 19:45:40 +02:00
El RIDO
47944ba3b1
updating DOMpurify to 1.0.11, fixes #442
2019-06-23 12:15:36 +02:00
El RIDO
8dc9db90c9
added translation for Czech, provided by @info-path, fixes #424
2019-06-23 12:06:36 +02:00
El RIDO
40493dfb3a
simplify logic, adding test cases for all combinations of URLs that are regarded as secure context
2019-06-23 10:38:08 +02:00
El RIDO
61fde53de0
adding IPv6 localhost to exceptions
2019-06-23 09:56:18 +02:00
El RIDO
dc193f7555
Revert "removing exceptions - in these cases server admins can opt to disable the warning message in the configuration"
...
This reverts commit d0365faf76
2019-06-23 09:54:48 +02:00
El RIDO
d9f27fb004
avoid instability of tests due to Alert callback testing, which can prevent notifications from getting displayed
2019-06-23 09:39:21 +02:00
El RIDO
603f7fd911
adding tests for all cases
2019-06-22 15:44:54 +02:00
El RIDO
59153633b8
adding test for bot UAs
2019-06-22 09:12:31 +02:00
El RIDO
d0365faf76
removing exceptions - in these cases server admins can opt to disable the warning message in the configuration
2019-06-22 08:39:46 +02:00
rugk
e5974d4663
Prefer isSecureContext if available
2019-06-21 19:48:16 +02:00
El RIDO
50cc6995e0
making use of the URL object in the existing tests
2019-06-20 22:30:49 +02:00
El RIDO
1958a55651
adding new dev dependency to support the URL object
2019-06-20 21:38:29 +02:00
El RIDO
77419ec2c1
Merge branch 'master' into httpinsecure
2019-06-20 21:01:00 +02:00
El RIDO
b1be74a56f
support processing of Error types in notifications, adresses #441
2019-06-18 19:45:52 +02:00
El RIDO
42c2003220
made notice configurable, fixing a few CSS glitches
2019-06-17 21:40:37 +02:00
El RIDO
a67c9ab129
reworded the message, added the missing translation strings
2019-06-17 21:18:30 +02:00
El RIDO
fc914b4b84
moved bad bot check into InitialCheck, changed old ie notice into generic update warning, when unsupported user agent is detected and made the other IE alert show in all versions as it is now entirely unsupported
2019-06-17 21:09:21 +02:00
El RIDO
748b85e025
Merge branch master into httpinsecure
2019-06-17 19:51:33 +02:00
El RIDO
8515c9d223
upgrading DOMpurify library
2019-06-16 10:23:14 +02:00
El RIDO
8a69411d50
upgrading showdown library
2019-06-16 10:19:44 +02:00
El RIDO
49e118a8b3
updated kjua library
2019-06-16 10:13:53 +02:00
El RIDO
3259cabfb3
revert bootstraps JS to 3.3.7 as 3.4.1 breaks the navbar toggle
2019-06-16 10:06:01 +02:00
El RIDO
b527bc6208
upgrade jQuery library
2019-06-16 09:30:59 +02:00
El RIDO
0a88b3043c
upgrading bootstrap CSS
2019-06-16 09:27:11 +02:00
El RIDO
b4ceb4078d
removed obsolete code and comments, tested with a PDF of 9 MiB and it works fine in Firefox and Chrome
2019-06-15 09:47:55 +02:00
El RIDO
451a4817c4
replace data-URL method usage with blob-URL one
2019-06-15 09:35:26 +02:00
El RIDO
6cf52f4cf3
mocking window.URL.createObjectURL to have tests working with blob URLs
2019-06-15 08:56:47 +02:00
R4SAS
abd71413c3
Store Blob URL in variable
2019-06-12 06:29:36 +03:00
R4SAS
d3f9670bc2
Remove data length detection, because we work with URL
2019-06-12 06:05:55 +03:00
R4SAS
dcbefcc1c3
Use blob for previews
2019-06-12 05:29:19 +03:00
R4SAS
ff6b9bd8f9
Use blob URI for saving attachments ( #432 )
2019-06-12 04:37:17 +03:00
El RIDO
a459c4692c
correcting API use, avoid history glitch
2019-06-01 23:49:40 +02:00
El RIDO
ebbb850b27
clone array instead of passing the reference, adresses #436
2019-05-31 07:05:40 +02:00
El RIDO
c4b84b2b6b
extract version logic into paste & comment classes
2019-05-25 13:20:39 +02:00
El RIDO
d73c68ad85
insert Paste class to wrap the data, to be able to extend the paste with getters and format version handling
2019-05-25 10:10:59 +02:00
El RIDO
b44e729a1a
fixing display of version 1 pastes without attachments
2019-05-19 13:31:17 +02:00
El RIDO
353d08daf6
handle regression due to base58 stripping NULL bytes, discovered via JSVerify RNG state 0dec6b2a5f04d19873
2019-05-19 09:54:40 +02:00
El RIDO
8fd3e680e4
base58 will left trim NULL bytes, handling JSVerify RNG state 0dec6b2a5f04d19873
2019-05-19 09:05:56 +02:00
El RIDO
86b4e0e7a4
revert autoformatting applied by IDE
2019-05-19 08:43:07 +02:00
El RIDO
3b0ab7e99f
fixing regression handling v1 key format (un-decoded base64)
2019-05-19 08:36:18 +02:00
El RIDO
0e71211fad
v2 paste can successfully en- and decrypt the particular message, fixes #260
2019-05-19 08:25:34 +02:00
El RIDO
7111e38898
Merge branch 'empty-paste' into webcrypto
2019-05-19 07:52:37 +02:00
El RIDO
6f480bf014
Merge branch 'master' into webcrypto, implementing base58, fixes #377
2019-05-15 21:20:54 +02:00
El RIDO
5779d87788
integrating compression test case that failed in rawdeflate in webcrypto + zlib testing, proving this fixes #328
2019-05-15 18:56:42 +02:00
El RIDO
e77eb1de13
Merge branch 'truncation' into webcrypto
2019-05-15 18:44:26 +02:00
