From 79fd33d21ffb1bdb613bf5d03cc14f2addebf768 Mon Sep 17 00:00:00 2001 From: rugk Date: Sat, 9 Jul 2022 16:57:06 +0200 Subject: [PATCH 1/2] chore: run tests with NodeJS 14 I expect no stuff to break or so, so let's just try to use the current recommend LTS version. (v14 will also die at some time, but Fedora e.g. still seems to use it for now by default. Likely we may upgrade soon even more.) Ref https://nodejs.org/en/about/releases/ --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 55a51aaf..530be1cc 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -104,7 +104,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: '12' + node-version: '14' cache: 'npm' cache-dependency-path: 'js/package.json' From e536db9b7e9fb38229c19ec2b245592b676989d2 Mon Sep 17 00:00:00 2001 From: rugk Date: Sat, 9 Jul 2022 17:04:28 +0200 Subject: [PATCH 2/2] style: run tests via npm script insread of custom command I.e. not call mocha directly but let the script defined in package.json do it's job. --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 530be1cc..10e84b48 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -116,6 +116,6 @@ jobs: working-directory: js - name: Run unit tests - run: mocha + run: npm test working-directory: js