From baf8c4a11dce0c4e74921932ac478525437eda77 Mon Sep 17 00:00:00 2001 From: El RIDO Date: Sat, 4 May 2024 08:49:43 +0200 Subject: [PATCH 1/2] tolerate test failures in the PHP development release at this time, guzzle, dependency of google cloud storage library, raises deprecation warnings in PHP 8.4, which caused the tests to be considered failed --- .github/workflows/tests.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 730de26e..1667ed8c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -16,11 +16,16 @@ jobs: run: composer install --prefer-dist --no-dev PHPunit: + name: PHP ${{ matrix.php-versions }} unit tests on ${{ matrix.operating-system }} runs-on: ubuntu-latest + continue-on-error: ${{ matrix.experimental }} strategy: matrix: - php-versions: ['7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4'] - name: PHP ${{ matrix.php-versions }} unit tests on ${{ matrix.operating-system }} + php-versions: ['7.3', '7.4', '8.0', '8.1', '8.2', '8.3'] + experimental: [false] + include: + - php-versions: '8.4' # development release, things can break + experimental: true env: extensions: gd, sqlite3 extensions-cache-key-name: phpextensions From 33df5fbd2f3aa8d235638166c8876e9f3b0b600a Mon Sep 17 00:00:00 2001 From: rugk Date: Sat, 4 May 2024 12:40:44 +0200 Subject: [PATCH 2/2] Actually make tests continue on experimental builds --- .github/workflows/tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1667ed8c..00cab65c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -7,6 +7,8 @@ jobs: Composer: runs-on: ubuntu-latest + # https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#handling-failures + continue-on-error: ${{ matrix.experimental }} steps: - name: Checkout uses: actions/checkout@v4