From 5980f8b603cd9f442ab40663e96c45d9ecac73e9 Mon Sep 17 00:00:00 2001
From: El RIDO <elrido@gmx.net>
Date: Mon, 4 Jul 2016 20:46:45 +0200
Subject: [PATCH] removing some unused code detected by codacy

---
 lib/zerobin.php       | 10 ----------
 tst/configuration.php |  2 +-
 tst/model.php         |  2 +-
 tst/request.php       |  2 --
 tst/serversalt.php    |  2 +-
 tst/vizhash16x16.php  |  2 --
 tst/zerobin.php       |  2 --
 7 files changed, 3 insertions(+), 19 deletions(-)

diff --git a/lib/zerobin.php b/lib/zerobin.php
index b279dd2e..94026def 100644
--- a/lib/zerobin.php
+++ b/lib/zerobin.php
@@ -55,14 +55,6 @@ class zerobin
      */
     private $_doesExpire = false;
 
-    /**
-     * formatter
-     *
-     * @access private
-     * @var    string
-     */
-    private $_formatter = 'plaintext';
-
     /**
      * error message
      *
@@ -219,8 +211,6 @@ class zerobin
      */
     private function _create()
     {
-        $error = false;
-
         // Ensure last paste from visitors IP address was more than configured amount of seconds ago.
         trafficlimiter::setConfiguration($this->_conf);
         if (!trafficlimiter::canPass()) return $this->_return_message(
diff --git a/tst/configuration.php b/tst/configuration.php
index d0fe5d3b..b9084cd5 100644
--- a/tst/configuration.php
+++ b/tst/configuration.php
@@ -90,7 +90,7 @@ class configurationTest extends PHPUnit_Framework_TestCase
     public function testHandleBlankConfigFile()
     {
         file_put_contents(CONF, '');
-        $conf = new configuration;
+        new configuration;
     }
 
     public function testHandleMinimalConfigFile()
diff --git a/tst/model.php b/tst/model.php
index c5c21c18..6bc8332d 100644
--- a/tst/model.php
+++ b/tst/model.php
@@ -175,7 +175,7 @@ class modelTest extends PHPUnit_Framework_TestCase
     public function testInvalidComment()
     {
         $paste = $this->_model->getPaste();
-        $comment = $paste->getComment(helper::getPasteId());
+        $paste->getComment(helper::getPasteId());
     }
 
     public function testExpiration()
diff --git a/tst/request.php b/tst/request.php
index cf4a4eb2..a072a5b8 100644
--- a/tst/request.php
+++ b/tst/request.php
@@ -1,8 +1,6 @@
 <?php
 class requestTest extends PHPUnit_Framework_TestCase
 {
-    private $_request;
-
     public function setUp()
     {
         /* Setup Routine */
diff --git a/tst/serversalt.php b/tst/serversalt.php
index 9756455c..39a8557f 100644
--- a/tst/serversalt.php
+++ b/tst/serversalt.php
@@ -43,7 +43,7 @@ class serversaltTest extends PHPUnit_Framework_TestCase
             function mcrypt_create_iv($int, $flag)
             {
                 $randomSalt = '';
-                for($i = 0; $i < 256; ++$i) {
+                for($i = 0; $i < $int; ++$i) {
                     $randomSalt .= base_convert(mt_rand(), 10, 16);
                 }
                 // hex2bin requires an even length, pad if necessary
diff --git a/tst/vizhash16x16.php b/tst/vizhash16x16.php
index c810c548..1c9a4c5b 100644
--- a/tst/vizhash16x16.php
+++ b/tst/vizhash16x16.php
@@ -1,8 +1,6 @@
 <?php
 class vizhash16x16Test extends PHPUnit_Framework_TestCase
 {
-    private $_dataDirCreated;
-
     private $_file;
 
     private $_path;
diff --git a/tst/zerobin.php b/tst/zerobin.php
index 22cb3120..d35d12bf 100644
--- a/tst/zerobin.php
+++ b/tst/zerobin.php
@@ -124,9 +124,7 @@ class zerobinTest extends PHPUnit_Framework_TestCase
             $file = PATH . $dir . DIRECTORY_SEPARATOR . '.htaccess';
             @unlink($file);
         }
-        ob_start();
         new zerobin;
-        $content = ob_get_contents();
         foreach ($dirs as $dir) {
             $file = PATH . $dir . DIRECTORY_SEPARATOR . '.htaccess';
             $this->assertFileExists(