From 3979eef66da34b7a5a9ce47273a0724f77947197 Mon Sep 17 00:00:00 2001
From: Jay Trees <github.hybridsupply@grandel.anonaddy.me>
Date: Wed, 23 Mar 2022 13:28:09 +0100
Subject: [PATCH] Add button title attribute

---
 src/classes/wish.php    |  9 +++++++--
 src/pages/home.php      | 28 ++++++++++++++++++++++++----
 src/pages/install.php   | 21 ++++++++++++++++++---
 src/pages/login-as.php  |  6 +++++-
 src/pages/login.php     | 15 +++++++++++++--
 src/pages/profile.php   |  6 +++++-
 src/pages/register.php  | 13 +++++++++++--
 src/pages/settings.php  |  7 ++++++-
 src/pages/update.php    |  5 ++++-
 src/pages/wish.php      | 38 ++++++++++++++++++++++++++++----------
 src/pages/wishlists.php | 33 +++++++++++++++++++++------------
 11 files changed, 142 insertions(+), 39 deletions(-)

diff --git a/src/classes/wish.php b/src/classes/wish.php
index e32fa435..aafc59ae 100644
--- a/src/classes/wish.php
+++ b/src/classes/wish.php
@@ -157,7 +157,9 @@ class Wish
 
             <div class="extra content buttons">
                 <?php if (!$userIsCurrent) { ?>
-                    <a class="ui small primary labeled icon button fulfill">
+                    <a class="ui small primary labeled icon button fulfill"
+                       title="<?= __('Fulfill wish') ?>"
+                    >
                         <i class="shopping cart icon"></i>
                         <?= __('Fulfill wish') ?>
                     </a>
@@ -166,6 +168,7 @@ class Wish
                 <?php if ($this->url) { ?>
                     <a class="ui small labeled icon button<?= $userIsCurrent ? ' primary' : '' ?>"
                        href="<?= $this->url ?>" target="_blank"
+                       title="<?= __('Visit') ?>"
                     >
                         <i class="external icon"></i>
                         <?= __('Visit') ?>
@@ -173,7 +176,9 @@ class Wish
                 <?php } ?>
 
                 <?php if ($userIsCurrent) { ?>
-                    <div class="ui small labeled icon top left pointing dropdown button options">
+                    <div class="ui small labeled icon top left pointing dropdown button options"
+                         title="<?= __('Options') ?>"
+                    >
                         <i class="cog icon"></i>
                         <span class="text"><?= __('Options') ?></span>
                         <div class="menu">
diff --git a/src/pages/home.php b/src/pages/home.php
index 4535f8b6..ec59af2c 100644
--- a/src/pages/home.php
+++ b/src/pages/home.php
@@ -25,17 +25,37 @@ $page->navigation();
             <div class="ui four column doubling stackable centered grid">
                 <?php if ($user->isLoggedIn()) { ?>
                     <div class="column">
-                        <a class="ui fluid primary button" href="/?page=wishlists"><?= __('Create a wishlist') ?></a>
+                        <a class="ui fluid primary button"
+                           href="/?page=wishlists"
+                           title="<?= __('Create a wishlist') ?>"
+                        >
+                            <?= __('Create a wishlist') ?>
+                        </a>
                     </div>
                     <div class="column">
-                        <a class="ui fluid button" href="/?page=wishlists"><?= __('View your wishlists') ?></a>
+                        <a class="ui fluid button"
+                           href="/?page=wishlists"
+                           title="<?= __('View your wishlists') ?>"
+                        >
+                            <?= __('View your wishlists') ?>
+                        </a>
                     </div>
                 <?php } else { ?>
                     <div class="column">
-                        <a class="ui fluid primary button" href="/?page=register"><?= __('Register now') ?></a>
+                        <a class="ui fluid primary button"
+                           href="/?page=register"
+                           title="<?= __('Register now') ?>"
+                        >
+                            <?= __('Register now') ?>
+                        </a>
                     </div>
                     <div class="column">
-                        <a class="ui fluid button" href="/?page=login"><?= __('Login') ?></a>
+                        <a class="ui fluid button"
+                           href="/?page=login"
+                           title="<?= __('Login') ?>"
+                        >
+                            <?= __('Login') ?>
+                        </a>
                     </div>
                 <?php } ?>
             </div>
diff --git a/src/pages/install.php b/src/pages/install.php
index e56669cb..c36dfd2d 100644
--- a/src/pages/install.php
+++ b/src/pages/install.php
@@ -56,7 +56,11 @@ switch ($step) {
                             <input type="text" name="DATABASE_PASSWORD" />
                         </div>
 
-                        <input class="ui primary button" type="submit" value="<?= __('Continue') ?>" />
+                        <input class="ui primary button"
+                               type="submit"
+                               value="<?= __('Continue') ?>"
+                               title="<?= __('Continue') ?>"
+                        />
                     </form>
                 </div>
             </div>
@@ -102,7 +106,11 @@ switch ($step) {
                         <input type="hidden" name="install" value="true" />
                         <input type="hidden" name="step" value="<?= $step + 1; ?>" />
 
-                        <input class="ui primary button" type="submit" value="<?= __('Continue') ?>" />
+                        <input class="ui primary button"
+                               type="submit"
+                               value="<?= __('Continue') ?>"
+                               title="<?= __('Continue') ?>"
+                        />
                     </form>
                 </div>
             </div>
@@ -200,7 +208,14 @@ switch ($step) {
             <div class="ui container">
                 <div class="ui segment">
                     <h1 class="ui header"><?= __('Success') ?></h1>
-                    <p><a class="ui primary button" href="/?page=register"><?= __('Register') ?></a></p>
+                    <p>
+                        <a class="ui primary button"
+                           href="/?page=register"
+                           title="<?= __('Register') ?>"
+                        >
+                            <?= __('Register') ?>
+                        </a>
+                    </p>
                 </div>
             </div>
         </main>
diff --git a/src/pages/login-as.php b/src/pages/login-as.php
index da236f1b..2c41d643 100644
--- a/src/pages/login-as.php
+++ b/src/pages/login-as.php
@@ -49,7 +49,11 @@ $page->navigation();
                     <input type="email" name="email" placeholder="john.doe@domain.tld" />
                 </div>
 
-                <input class="ui primary button" type="submit" value="<?= __('Login') ?>" />
+                <input class="ui primary button"
+                       type="submit"
+                       value="<?= __('Login') ?>"
+                       title="<?= __('Login') ?>"
+                />
             </form>
         </div>
     </div>
diff --git a/src/pages/login.php b/src/pages/login.php
index 00fb3869..4d5f9a99 100644
--- a/src/pages/login.php
+++ b/src/pages/login.php
@@ -125,8 +125,18 @@ $page->navigation();
                                 </div>
                             </div>
 
-                            <input class="ui primary button" type="submit" name="login" value="<?= __('Login') ?>" />
-                            <a class="ui tertiary button" href="/?page=register"><?= __('Register') ?></a>
+                            <input class="ui primary button"
+                                   type="submit"
+                                   name="login"
+                                   value="<?= __('Login') ?>"
+                                   title="<?= __('Login') ?>"
+                            />
+                            <a class="ui tertiary button"
+                               href="/?page=register"
+                               title="<?= __('Register') ?>"
+                            >
+                                <?= __('Register') ?>
+                            </a>
                         </form>
                     </div>
 
@@ -150,6 +160,7 @@ $page->navigation();
                                                 type="submit"
                                                 name="reset"
                                                 value="<?= __('Send email') ?>"
+                                                title="<?= __('Send email') ?>"
                                             />
                                         </div>
 
diff --git a/src/pages/profile.php b/src/pages/profile.php
index b72568de..0fa2693a 100644
--- a/src/pages/profile.php
+++ b/src/pages/profile.php
@@ -99,7 +99,11 @@ $page->navigation();
 
                 <div class="ui error message"></div>
 
-                <input class="ui primary button" type="submit" value="<?= __('Save') ?>" />
+                <input class="ui primary button"
+                       type="submit"
+                       value="<?= __('Save') ?>"
+                       title="<?= __('Save') ?>"
+                />
             </form>
         </div>
     </div>
diff --git a/src/pages/register.php b/src/pages/register.php
index 1090010c..43c01bf3 100644
--- a/src/pages/register.php
+++ b/src/pages/register.php
@@ -219,8 +219,17 @@ $page->navigation();
                         <div class="column">
                             <div class="ui error message"></div>
 
-                            <input class="ui primary button" type="submit" value="<?= $buttonSubmit ?>" />
-                            <a class="ui tertiary button" href="/?page=login"><?= __('Login') ?></a>
+                            <input class="ui primary button"
+                                   type="submit"
+                                   value="<?= $buttonSubmit ?>"
+                                   title="<?= $buttonSubmit ?>"
+                            />
+                            <a class="ui tertiary button"
+                               href="/?page=login"
+                               title="<?= __('Login') ?>"
+                            >
+                                <?= __('Login') ?>
+                            </a>
                         </div>
                     </div>
 
diff --git a/src/pages/settings.php b/src/pages/settings.php
index 0c2de889..27a2884c 100644
--- a/src/pages/settings.php
+++ b/src/pages/settings.php
@@ -47,7 +47,12 @@ if (isset($_POST['mjml_api'], $_POST['api_key'], $_POST['api_secret'])) {
                     />
                 </div>
 
-                <input class="ui primary button" type="submit" name="mjml_api" value="<?= __('Save') ?>" />
+                <input class="ui primary button"
+                       type="submit"
+                       name="mjml_api"
+                       value="<?= __('Save') ?>"
+                       title="<?= __('Save') ?>"
+                />
             </form>
         </div>
     </div>
diff --git a/src/pages/update.php b/src/pages/update.php
index 58a7c1f7..aab63633 100644
--- a/src/pages/update.php
+++ b/src/pages/update.php
@@ -112,7 +112,10 @@ if ('POST' === $_SERVER['REQUEST_METHOD']) {
                 </div>
             </div>
             <form class="ui form" method="post">
-                <button class="ui orange button" type="submit">
+                <button class="ui orange button"
+                        type="submit"
+                        title="<?= sprintf(__('Update to %s'), 'v' . $version) ?>"
+                >
                     <i class="upload icon"></i>
                     <?= sprintf(__('Update to %s'), 'v' . $version) ?>
                 </button>
diff --git a/src/pages/wish.php b/src/pages/wish.php
index a02c58a9..c9da89f0 100644
--- a/src/pages/wish.php
+++ b/src/pages/wish.php
@@ -80,13 +80,18 @@ $referer = '/?page=wishlists&wishlist=' . $wish->wishlist;
             <div class="row">
                 <div class="sixteen wide column">
 
-                    <a class="ui small labeled icon button" href="<?= $wish->url ?>" target="_blank">
+                    <a class="ui small labeled icon button"
+                       href="<?= $wish->url ?>"
+                       target="_blank"
+                       title="<?= __('Visit') ?>"
+                    >
                         <i class="external icon"></i>
                         <?= __('Visit') ?>
                     </a>
 
                     <button class="ui small labeled icon button auto-fill disabled"
                             type="button"
+                            title="<?= __('Auto-fill') ?>"
                     >
                         <i class="redo icon"></i>
                         <?= __('Auto-fill') ?>
@@ -164,9 +169,22 @@ $referer = '/?page=wishlists&wishlist=' . $wish->wishlist;
                     <div class="stackable row">
                         <div class="sixteen wide column">
 
-                            <input class="ui small primary button" type="submit" value="<?= __('Save') ?>" />
-                            <input class="ui small button" type="reset" value="<?= __('Reset') ?>" />
-                            <a class="ui small secondary button" href="<?= $referer ?>"><?= __('Back') ?></a>
+                            <input class="ui small primary button"
+                                   type="submit"
+                                   value="<?= __('Save') ?>"
+                                   title="<?= __('Save') ?>"
+                            />
+                            <input class="ui small button"
+                                   type="reset"
+                                   value="<?= __('Reset') ?>"
+                                   title="<?= __('Reset') ?>"
+                            />
+                            <a class="ui small secondary button"
+                               href="<?= $referer ?>"
+                               title="<?= __('Back') ?>"
+                            >
+                                <?= __('Back') ?>
+                            </a>
 
                         </div>
                     </div>
@@ -194,10 +212,10 @@ $referer = '/?page=wishlists&wishlist=' . $wish->wishlist;
         </div>
     </div>
     <div class="actions">
-        <div class="ui primary approve button">
+        <div class="ui primary approve button" title="<?= __('Save') ?>">
             <?= __('Save') ?>
         </div>
-        <div class="ui deny button">
+        <div class="ui deny button" title="<?= __('Discard') ?>">
             <?= __('Discard') ?>
         </div>
     </div>
@@ -213,10 +231,10 @@ $referer = '/?page=wishlists&wishlist=' . $wish->wishlist;
         <p><?= __('Would you like to continue?') ?></p>
     </div>
     <div class="actions">
-        <div class="ui primary approve button">
+        <div class="ui primary approve button" title="<?= __('Yes, overwrite') ?>">
             <?= __('Yes, overwrite') ?>
         </div>
-        <div class="ui deny button">
+        <div class="ui deny button" title="<?= __('No') ?>">
             <?= __('No') ?>
         </div>
     </div>
@@ -246,10 +264,10 @@ $referer = '/?page=wishlists&wishlist=' . $wish->wishlist;
         </div>
     </div>
     <div class="actions">
-        <div class="ui primary approve button">
+        <div class="ui primary approve button" title="<?= __('Yes, update') ?>">
             <?= __('Yes, update') ?>
         </div>
-        <div class="ui deny button">
+        <div class="ui deny button" title="<?= __('No, leave it') ?>">
             <?= __('No, leave it') ?>
         </div>
     </div>
diff --git a/src/pages/wishlists.php b/src/pages/wishlists.php
index 2164004a..4d2e42d6 100644
--- a/src/pages/wishlists.php
+++ b/src/pages/wishlists.php
@@ -34,27 +34,34 @@ $page->navigation();
                     </div>
 
                     <div class="flex buttons">
-                        <a class="ui small labeled icon primary button wishlist-wish-add disabled">
+                        <a class="ui small labeled icon primary button wishlist-wish-add disabled"
+                           title="<?= __('Add a wish') ?>"
+                        >
                             <i class="add icon"></i>
                             <?= __('Add a wish') ?>
                         </a>
 
-                        <a class="ui small labeled icon button wishlist-share disabled" target="_blank">
+                        <a class="ui small labeled icon button wishlist-share disabled"
+                           target="_blank"
+                           title="<?= __('Share') ?>"
+                        >
                             <i class="share icon"></i>
                             <?= __('Share') ?>
                         </a>
 
-                        <div class="ui small labeled icon top left pointing dropdown button options">
+                        <div class="ui small labeled icon top left pointing dropdown button options"
+                             title="<?= __('Options') ?>"
+                        >
                             <i class="cog icon"></i>
                             <span class="text"><?= __('Options') ?></span>
                             <div class="menu">
 
-                                <div class="item wishlist-rename disabled">
+                                <div class="item wishlist-rename disabled" title="<?= __('Rename') ?>">
                                     <i class="pen icon"></i>
                                     <?= __('Rename') ?>
                                 </div>
 
-                                <div class="item wishlist-delete disabled">
+                                <div class="item wishlist-delete disabled" title="<?= __('Delete') ?>">
                                     <i class="trash icon"></i>
                                     <?= __('Delete') ?>
                                 </div>
@@ -70,7 +77,9 @@ $page->navigation();
                 <p><?= __('General options.') ?></p>
 
                 <div class="flex buttons">
-                    <a class="ui small labeled icon button wishlist-create">
+                    <a class="ui small labeled icon button wishlist-create"
+                       title="<?= __('Create a wishlist') ?>"
+                    >
                         <i class="add icon"></i>
                         <?= __('Create a wishlist') ?>
                     </a>
@@ -119,10 +128,10 @@ $page->navigation();
         </div>
     </div>
     <div class="actions">
-        <div class="ui approve primary button create">
+        <div class="ui approve primary button create" title="<?= __('Create') ?>">
             <?= __('Create') ?>
         </div>
-        <div class="ui deny button cancel">
+        <div class="ui deny button cancel" title="<?= __('Cancel') ?>">
             <?= __('Cancel') ?>
         </div>
     </div>
@@ -146,10 +155,10 @@ $page->navigation();
         </form>
     </div>
     <div class="actions">
-        <div class="ui approve primary button">
+        <div class="ui approve primary button" title="<?= __('Rename') ?>">
             <?= __('Rename') ?>
         </div>
-        <div class="ui deny button">
+        <div class="ui deny button" title="<?= __('Cancel') ?>">
             <?= __('Cancel') ?>
         </div>
     </div>
@@ -188,10 +197,10 @@ $page->navigation();
         </div>
     </div>
     <div class="actions">
-        <div class="ui primary approve button">
+        <div class="ui primary approve button" title="<?= __('Add') ?>">
             <?= __('Add') ?>
         </div>
-        <div class="ui deny button">
+        <div class="ui deny button" title="<?= __('Cancel') ?>">
             <?= __('Cancel') ?>
         </div>
     </div>