PrivateCoffee/travelynx
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix edge case that allowed in-transit journeys with invalid destinations

Browse source
This commit is contained in:
Derf Null 2023-06-07 23:04:00 +02:00
parent cc4feebe2c
commit e275fc6dbe
No known key found for this signature in database
GPG key ID: 19E6E524EBB177BA
1 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lib/Travelynx.pm
View file

@ -519,6 +519,26 @@ sub startup {
delete $journey->{edited}; delete $journey->{edited};
delete $journey->{id}; delete $journey->{id};
# users may force checkouts at stations that are not part of
# the train's scheduled (or real-time) route. re-adding those
# to in-transit violates the assumption that each train has
# a valid destination. Remove the target in this case.
my $route = JSON->new->decode( $journey->{route} );
my $found_checkout_id;
for my $stop ( @{$route} ) {
if ( $stop->[1] == $journey->{checkout_station_id} ) {
$found_checkout_id = 1;
last;
}
}
if ( not $found_checkout_id ) {
$journey->{checkout_station_id} = undef;
$journey->{checkout_time} = undef;
$journey->{arr_platform} = undef;
$journey->{sched_arrival} = undef;
$journey->{real_arrival} = undef;
}
$self->in_transit->add_from_journey( $self->in_transit->add_from_journey(
db => $db, db => $db,
journey => $journey journey => $journey