From 87a3ceb0c1d853ea6d12cd080e6e1e92919874a4 Mon Sep 17 00:00:00 2001 From: Daniel Friesel Date: Mon, 25 Mar 2019 21:37:11 +0100 Subject: [PATCH] remove sleep(1) workaround in checkout-before-checkin code path The unique constraint on (user id, timestamp) is no longer present --- lib/Travelynx.pm | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/lib/Travelynx.pm b/lib/Travelynx.pm index 7c89b04..b81ec46 100755 --- a/lib/Travelynx.pm +++ b/lib/Travelynx.pm @@ -536,23 +536,14 @@ qq{select * from pending_mails where email = ? and num_tries > 1;} my $user = $self->get_user_status; if ( $user->{checked_in} ) { - # If a user is already checked in, we assume that they forgot to - # check out and do it for them. - # XXX this is an ugly workaround for the UNIQUE constraint on - # (user id, action timestamp): Ensure that checkout and re-checkin - # work even if the previous checkin was less than a second ago. - sleep(1); + # If a user is already checked in, we assume that they forgot to + # check out and do it for them. $self->checkout( $station, 1 ); - - # XXX same workaround: We can't checkin immediately after checkout. - sleep(1); } elsif ( $user->{cancelled} ) { # Same - sleep(1); $self->cancelled_to($station); - sleep(1); } my $success = $self->app->action_query->execute(