647d03a173
This PR fixes some bugs related to our coordinate systems. These bugs would appear when the editor was not full screen.  In short, we were being inconsistent with whether the `currentScreenPoint` was relative to the top left corner of the component or the top left corner of the page that contained the component. Here's the actual system: <img width="898" alt="image" src="https://github.com/tldraw/tldraw/assets/23072548/c49b3686-aeb6-4164-a55d-8639d40290a1"> The `viewportPageBounds` describes the bounds of the component within the browser's space. Its `x` and `y` describe the delta in browser space between the top left corner of the **page** and the component. This is not effected by scrolling. The use's `screenPoint` describes the user's cursor's location relative to the `viewportPageBounds`. Its `x` and `y` describe the delta in browser space between the top left corner of the **component** and the cursor. While this is a bug fix, I'm marking it as major as apps may be depending on the previous (broken) behavior. ### Change Type - [x] `major` — Breaking change ### Test Plan 1. Zoom in, out, and pinch on an editor that isn't full screen. 2. Zoom in, out, and pinch on an editor that is full screen. 3. Drag and scroll on an editor that isn't full screen. 4. Drag and scroll on an editor that is full screen. - [x] Unit Tests ### Release Notes - Fixed bugs with `getViewportScreenCenter` that could effect zooming and pinching on editors that aren't full screen |
||
|---|---|---|
| .. | ||
| assets | ||
| editor | ||
| state | ||
| store | ||
| tldraw | ||
| tlschema | ||
| tlsync | ||
| utils | ||
| validate | ||