e29137f467
Right now when you hit Share/Fork on production it can take a good 5 seconds for something to happen. In the meantime, it can feel like nothing happened when you clicked the button. Maybe you click it again to see if that'll fix it, which doesn't do anything. Same thing for the Copy action, sometimes we don't have an icon to subtly show that it's been copied. This adds some toasts and disables the Share menu while a project is being created. Also, has two drive-by fixes: - the getShareUrl logic is old and needed to be superseded by the new stuff - the icon fix for clipboard-copied.svg from the readonly omnibus PR (https://github.com/tldraw/tldraw/pull/3192) got overridden in a different PR (https://github.com/tldraw/tldraw/pull/3627) - this restores the fix <img width="304" alt="Screenshot 2024-05-30 at 11 38 39" src="https://github.com/tldraw/tldraw/assets/469604/f9a3b7c7-f9ea-41f0-ad00-7fc5d71da93f"> <img width="257" alt="Screenshot 2024-05-30 at 11 38 14" src="https://github.com/tldraw/tldraw/assets/469604/c0a2d762-64c3-44da-b61e-c237133dd8cd"> ### Change Type <!-- ❗ Please select a 'Scope' label ❗️ --> - [x] `sdk` — Changes the tldraw SDK - [ ] `dotcom` — Changes the tldraw.com web app - [ ] `docs` — Changes to the documentation, examples, or templates. - [ ] `vs code` — Changes to the vscode plugin - [ ] `internal` — Does not affect user-facing stuff <!-- ❗ Please select a 'Type' label ❗️ --> - [ ] `bugfix` — Bug fix - [ ] `feature` — New feature - [x] `improvement` — Improving existing features - [ ] `chore` — Updating dependencies, other boring stuff - [ ] `galaxy brain` — Architectural changes - [ ] `tests` — Changes to any test code - [ ] `tools` — Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` — I don't know ### Release Notes - Share menu: make sharing/fork/copy actions clearer |
||
---|---|---|
.. | ||
embed-icons | ||
fonts | ||
icons/icon | ||
translations | ||
card-repo.png | ||
card_repo.svg | ||
github-hero-dark-draw.png | ||
github-hero-dark.png | ||
github-hero-light-2.png | ||
github-hero-light-draw.png | ||
github-hero-light.png | ||
github-hero_dark-2.png |