ac0259a6af
This PR refactors our menu systems and provides an interface to hide or
replace individual user interface elements.
# Background
Previously, we've had two types of overrides:
- "schema" overrides that would allow insertion or replacement of items
in the different menus
- "component" overrides that would replace components in the editor's
user interface
This PR is an attempt to unify the two and to provide for additional
cases where the "schema-based" user interface had begun to break down.
# Approach
This PR makes no attempt to change the `actions` or `tools`
overrides—the current system seems to be correct for those because they
are not reactive. The challenge with the other ui schemas is that they
_are_ reactive, and thus the overrides both need to a) be fed in from
outside of the editor as props, and b) react to changes from the editor,
which is an impossible situation.
The new approach is to use React to declare menu items. (Surprise!)
```tsx
function CustomHelpMenuContent() {
return (
<>
<DefaultHelpMenuContent />
<TldrawUiMenuGroup id="custom stuff">
<TldrawUiMenuItem
id="about"
label="Like my posts"
icon="external-link"
readonlyOk
onSelect={() => {
window.open('https://x.com/tldraw', '_blank')
}}
/>
</TldrawUiMenuGroup>
</>
)
}
const components: TLComponents = {
HelpMenuContent: CustomHelpMenuContent,
}
export default function CustomHelpMenuContentExample() {
return (
<div className="tldraw__editor">
<Tldraw components={components} />
</div>
)
}
```
We use a `components` prop with the combined editor and ui components.
- [ ] Create a "layout" component?
- [ ] Make UI components more isolated? If possible, they shouldn't
depend on styles outside of themselves, so that they can be used in
other layouts. Maybe we wait on this because I'm feeling a slippery
slope toward presumptions about configurability.
- [ ] OTOH maybe we go hard and consider these things as separate
components, even packages, with their own interfaces for customizability
/ configurability, just go all the way with it, and see what that looks
like.
# Pros
Top line: you can customize tldraw's user interface in a MUCH more
granular / powerful way than before.
It solves a case where menu items could not be made stateful from
outside of the editor context, and provides the option to do things in
the menus that we couldn't allow previously with the "schema-based"
approach.
It also may (who knows) be more performant because we can locate the
state inside of the components for individual buttons and groups,
instead of all at the top level above the "schema". Because items /
groups decide their own state, we don't have to have big checks on how
many items are selected, or whether we have a flippable state. Items and
groups themselves are allowed to re-build as part of the regular React
lifecycle. Menus aren't constantly being rebuilt, if that were ever an
issue.
Menu items can be shared between different menu types. We'll are
sometimes able to re-use items between, for example, the menu and the
context menu and the actions menu.
Our overrides no longer mutate anything, so there's less weird searching
and finding.
# Cons
This approach can make customization menu contents significantly more
complex, as an end user would need to re-declare most of a menu in order
to make any change to it. Luckily a user can add things to the top or
bottom of the context menu fairly easily. (And who knows, folks may
actually want to do deep customization, and this allows for it.)
It's more code. We are shipping more react components, basically one for
each menu item / group.
Currently this PR does not export the subcomponents, i.e. menu items. If
we do want to export these, then heaven help us, it's going to be a
_lot_ of exports.
# Progress
- [x] Context menu
- [x] Main menu
- [x] Zoom menu
- [x] Help menu
- [x] Actions menu
- [x] Keyboard shortcuts menu
- [x] Quick actions in main menu? (new)
- [x] Helper buttons? (new)
- [x] Debug Menu
And potentially
- [x] Toolbar
- [x] Style menu
- [ ] Share zone
- [x] Navigation zone
- [ ] Other zones
### Change Type
- [x] `major` — Breaking change
### Test Plan
1. use the context menu
2. use the custom context menu example
3. use cursor chat in the context menu
- [x] Unit Tests
- [ ] End to end tests
### Release Notes
- Add a brief release note for your PR here.
79 lines
2.8 KiB
TypeScript
79 lines
2.8 KiB
TypeScript
import test, { expect } from '@playwright/test'
|
|
import { Editor } from '@tldraw/tldraw'
|
|
import { setup } from '../shared-e2e'
|
|
|
|
export function sleep(ms: number) {
|
|
return new Promise((resolve) => setTimeout(resolve, ms))
|
|
}
|
|
|
|
declare const editor: Editor
|
|
|
|
/**
|
|
* These tests are skipped. They are here to show how to use the clipboard
|
|
* in tests. The clipboard is not really supported in playwright, so until
|
|
* we figure out a way to do it (or until it is supported propertly), we've
|
|
* had to skip these tests.
|
|
*/
|
|
test.describe.skip('clipboard tests', () => {
|
|
test.beforeEach(setup)
|
|
|
|
test('copy and paste from keyboard shortcut', async ({ page }) => {
|
|
await page.keyboard.press('r')
|
|
await page.mouse.move(100, 100)
|
|
await page.mouse.down()
|
|
await page.mouse.up()
|
|
|
|
expect(await page.evaluate(() => editor.getCurrentPageShapes().length)).toBe(1)
|
|
expect(await page.evaluate(() => editor.getSelectedShapes().length)).toBe(1)
|
|
|
|
await page.keyboard.down('Control')
|
|
await page.keyboard.press('KeyC')
|
|
await sleep(100)
|
|
await page.keyboard.press('KeyV')
|
|
await page.keyboard.up('Control')
|
|
|
|
expect(await page.evaluate(() => editor.getCurrentPageShapes().length)).toBe(2)
|
|
expect(await page.evaluate(() => editor.getSelectedShapes().length)).toBe(1)
|
|
})
|
|
|
|
test('copy and paste from main menu', async ({ page }) => {
|
|
await page.keyboard.press('r')
|
|
await page.mouse.move(100, 100)
|
|
await page.mouse.down()
|
|
await page.mouse.up()
|
|
|
|
expect(await page.evaluate(() => editor.getCurrentPageShapes().length)).toBe(1)
|
|
expect(await page.evaluate(() => editor.getSelectedShapes().length)).toBe(1)
|
|
|
|
await page.getByTestId('main.menu').click()
|
|
await page.getByTestId('main-menu-sub-trigger.edit').click()
|
|
await page.getByTestId('main-menu.copy').click()
|
|
await sleep(100)
|
|
await page.getByTestId('main.menu').click()
|
|
await page.getByTestId('main-menu-sub-trigger.edit').click()
|
|
await page.getByTestId('main-menu.paste').click()
|
|
|
|
expect(await page.evaluate(() => editor.getCurrentPageShapes().length)).toBe(2)
|
|
expect(await page.evaluate(() => editor.getSelectedShapes().length)).toBe(1)
|
|
})
|
|
|
|
test('copy and paste from context menu', async ({ page }) => {
|
|
await page.keyboard.press('r')
|
|
await page.mouse.move(100, 100)
|
|
await page.mouse.down()
|
|
await page.mouse.up()
|
|
|
|
expect(await page.evaluate(() => editor.getCurrentPageShapes().length)).toBe(1)
|
|
expect(await page.evaluate(() => editor.getSelectedShapes().length)).toBe(1)
|
|
|
|
await page.mouse.click(100, 100, { button: 'right' })
|
|
await page.getByTestId('main-menu.copy').click()
|
|
await sleep(100)
|
|
await page.mouse.move(200, 200)
|
|
await page.mouse.click(100, 100, { button: 'right' })
|
|
await page.getByTestId('main-menu.paste').click()
|
|
|
|
expect(await page.evaluate(() => editor.getCurrentPageShapes().length)).toBe(2)
|
|
expect(await page.evaluate(() => editor.getSelectedShapes().length)).toBe(1)
|
|
})
|
|
})
|