006d2a7ffc
This PR fixes a bug where you could lose focus of the editor, which caused keyboard shortcuts to stop working. The problem was this: - The duplicate button can become disabled while you have it focused. - This would shove focus back to the document body, and the editor would lose focus. - When we disable the button, we should keep focus in the editor instead. - This shouldn't interfere with a developer manually handling focus of the editor themselves. I applied the same fix to the undo, redo, delete and duplicate buttons. **Is this is a bit hacky? Not sure if I'm handling those `ref`s correctly? WDYT?** ![2024-01-25 at 12 14 50 - Gold Nightingale](https://github.com/tldraw/tldraw/assets/15892272/5ca71f92-45fa-48f6-9039-f6c01c495ce7) ### Change Type - [x] `patch` — Bug fix [^1]: publishes a `patch` release, for devDependencies use `internal` [^2]: will not publish a new version ### Test Plan 1. Create a shape. 2. Select it. 3. Click the duplicate button at the top of the screen. 4. Press the 'd' key. 5. Press the 'a' key. 6. You should have the Arrow tool selected. - [ ] Unit Tests - [ ] End to end tests ### Release Notes - Fixed a bug where keyboard shortcuts could stop working after using an action button. |
||
---|---|---|
.. | ||
assets | ||
editor | ||
state | ||
store | ||
tldraw | ||
tlschema | ||
tlsync | ||
utils | ||
validate |