4dab25be57
This PR ensures that the share menu is open when navigating from the create new shared project button. This could be achieved by calling ```editor.addOpenMenu('share-menu')``` after ```navigate('/new')``` , but that opens the menu on the local editor first so you get a flash of that before the multiplayer editor loads. Instead I've used the state prop on the Navigate component/function to pass a property called shouldOpenShareMenu. If the user presses the back button to return to the local editor instance then the open state of the share menu is preserved, which is actually something we don't want in this case. Not sure how to deal with that without adding a ton more complexity, is it worth it? ### Change Type <!-- ❗ Please select a 'Scope' label ❗️ --> - [ ] `sdk` — Changes the tldraw SDK - [x] `dotcom` — Changes the tldraw.com web app - [ ] `docs` — Changes to the documentation, examples, or templates. - [ ] `vs code` — Changes to the vscode plugin - [ ] `internal` — Does not affect user-facing stuff <!-- ❗ Please select a 'Type' label ❗️ --> - [ ] `bugfix` — Bug fix - [ ] `feature` — New feature - [x] `improvement` — Improving existing features - [ ] `chore` — Updating dependencies, other boring stuff - [ ] `galaxy brain` — Architectural changes - [ ] `tests` — Changes to any test code - [ ] `tools` — Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` — I don't know ### Test Plan 1. Click create new shared project from the file menu 2. Share menu should open after navigating to the new room ### Release Notes - Open share menu when navigating from the create new shared project button. --------- Co-authored-by: Steve Ruiz <steveruizok@gmail.com> |
||
---|---|---|
.. | ||
embed-icons | ||
fonts | ||
icons/icon | ||
translations | ||
card-repo.png | ||
card_repo.svg | ||
github-hero-dark-draw.png | ||
github-hero-dark.png | ||
github-hero-light-2.png | ||
github-hero-light-draw.png | ||
github-hero-light.png | ||
github-hero_dark-2.png |