From f63ddc7ecc71f498a7cddf6bc4611c7013c454dd Mon Sep 17 00:00:00 2001 From: Gabriel Lee Date: Mon, 17 Jul 2023 22:58:05 +0100 Subject: [PATCH] fix: arrow label dark mode color (#1733) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This PR fixes the issue where the arrow label was black in dark mode instead of white. light mode (normal): Screenshot 2023-07-12 at 00 21 35 dark mode (before): Screenshot 2023-07-12 at 00 21 52 dark mode (after): Screenshot 2023-07-12 at 00 21 44 Fixes #1716 ### Change Type - [x] `patch` — Bug fix - [ ] `minor` — New feature - [ ] `major` — Breaking change - [ ] `dependencies` — Changes to package dependencies[^1] - [ ] `documentation` — Changes to the documentation only[^2] - [ ] `tests` — Changes to any test code only[^2] - [ ] `internal` — Any other changes that don't affect the published package[^2] - [ ] I don't know [^1]: publishes a `patch` release, for devDependencies use `internal` [^2]: will not publish a new version ### Test Plan 1. Add an arrow with label 2. Switch between dark and light mode and notice that the label color adapts correctly - [ ] Unit Tests - [ ] End to end tests ### Release Notes - fixed arrow label dark mode color Co-authored-by: Steve Ruiz --- packages/tldraw/src/lib/shapes/arrow/ArrowShapeUtil.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tldraw/src/lib/shapes/arrow/ArrowShapeUtil.tsx b/packages/tldraw/src/lib/shapes/arrow/ArrowShapeUtil.tsx index c149bee87..d28902c4f 100644 --- a/packages/tldraw/src/lib/shapes/arrow/ArrowShapeUtil.tsx +++ b/packages/tldraw/src/lib/shapes/arrow/ArrowShapeUtil.tsx @@ -732,7 +732,7 @@ export class ArrowShapeUtil extends ShapeUtil { size={shape.props.size} position={info.middle} width={labelSize?.w ?? 0} - labelColor={shape.props.labelColor} + labelColor={theme[shape.props.labelColor].solid} /> )