This reverts commit 8a5741c283
.
Introduced a fuzz error
https://github.com/tldraw/tldraw/actions/runs/8703994315/job/23871324407
- [x] `internal` — Does not affect user-facing stuff
This commit is contained in:
parent
6f05a9b756
commit
cb118ef712
8 changed files with 42 additions and 76 deletions
|
@ -33,8 +33,6 @@ export interface Computed<Value, Diff = unknown> extends Signal<Value, Diff> {
|
||||||
readonly parentEpochs: number[];
|
readonly parentEpochs: number[];
|
||||||
// @internal (undocumented)
|
// @internal (undocumented)
|
||||||
readonly parents: Signal<any, any>[];
|
readonly parents: Signal<any, any>[];
|
||||||
// @internal (undocumented)
|
|
||||||
readonly parentSet: ArraySet<Signal<any, any>>;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// @public
|
// @public
|
||||||
|
|
|
@ -144,29 +144,4 @@ export class ArraySet<T> {
|
||||||
|
|
||||||
throw new Error('no set or array')
|
throw new Error('no set or array')
|
||||||
}
|
}
|
||||||
|
|
||||||
has(elem: T) {
|
|
||||||
if (this.array) {
|
|
||||||
return this.array.indexOf(elem) !== -1
|
|
||||||
} else {
|
|
||||||
return this.set!.has(elem)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
clear() {
|
|
||||||
if (this.set) {
|
|
||||||
this.set.clear()
|
|
||||||
} else {
|
|
||||||
this.arraySize = 0
|
|
||||||
this.array?.fill(undefined)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
size() {
|
|
||||||
if (this.set) {
|
|
||||||
return this.set.size
|
|
||||||
} else {
|
|
||||||
return this.arraySize
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
|
@ -123,8 +123,6 @@ export interface Computed<Value, Diff = unknown> extends Signal<Value, Diff> {
|
||||||
*/
|
*/
|
||||||
readonly isActivelyListening: boolean
|
readonly isActivelyListening: boolean
|
||||||
|
|
||||||
/** @internal */
|
|
||||||
readonly parentSet: ArraySet<Signal<any, any>>
|
|
||||||
/** @internal */
|
/** @internal */
|
||||||
readonly parents: Signal<any, any>[]
|
readonly parents: Signal<any, any>[]
|
||||||
/** @internal */
|
/** @internal */
|
||||||
|
@ -143,7 +141,6 @@ class __UNSAFE__Computed<Value, Diff = unknown> implements Computed<Value, Diff>
|
||||||
*/
|
*/
|
||||||
private lastCheckedEpoch = GLOBAL_START_EPOCH
|
private lastCheckedEpoch = GLOBAL_START_EPOCH
|
||||||
|
|
||||||
parentSet = new ArraySet<Signal<any, any>>()
|
|
||||||
parents: Signal<any, any>[] = []
|
parents: Signal<any, any>[] = []
|
||||||
parentEpochs: number[] = []
|
parentEpochs: number[] = []
|
||||||
|
|
||||||
|
|
|
@ -1,4 +1,3 @@
|
||||||
import { ArraySet } from './ArraySet'
|
|
||||||
import { startCapturingParents, stopCapturingParents } from './capture'
|
import { startCapturingParents, stopCapturingParents } from './capture'
|
||||||
import { GLOBAL_START_EPOCH } from './constants'
|
import { GLOBAL_START_EPOCH } from './constants'
|
||||||
import { attach, detach, haveParentsChanged, singleton } from './helpers'
|
import { attach, detach, haveParentsChanged, singleton } from './helpers'
|
||||||
|
@ -64,11 +63,9 @@ class __EffectScheduler__<Result> {
|
||||||
}
|
}
|
||||||
|
|
||||||
/** @internal */
|
/** @internal */
|
||||||
readonly parentSet = new ArraySet<Signal<any, any>>()
|
parentEpochs: number[] = []
|
||||||
/** @internal */
|
/** @internal */
|
||||||
readonly parentEpochs: number[] = []
|
parents: Signal<any, any>[] = []
|
||||||
/** @internal */
|
|
||||||
readonly parents: Signal<any, any>[] = []
|
|
||||||
private readonly _scheduleEffect?: (execute: () => void) => void
|
private readonly _scheduleEffect?: (execute: () => void) => void
|
||||||
constructor(
|
constructor(
|
||||||
public readonly name: string,
|
public readonly name: string,
|
||||||
|
|
|
@ -94,16 +94,12 @@ function runTest(seed: number) {
|
||||||
for (let i = 0; i < 1000; i++) {
|
for (let i = 0; i < 1000; i++) {
|
||||||
const num = nums[Math.floor(r() * nums.length)]
|
const num = nums[Math.floor(r() * nums.length)]
|
||||||
|
|
||||||
const choice = r()
|
if (r() > 0.5) {
|
||||||
if (choice < 0.45) {
|
|
||||||
as.add(num)
|
as.add(num)
|
||||||
s.add(num)
|
s.add(num)
|
||||||
} else if (choice < 0.9) {
|
} else {
|
||||||
as.remove(num)
|
as.remove(num)
|
||||||
s.delete(num)
|
s.delete(num)
|
||||||
} else {
|
|
||||||
as.clear()
|
|
||||||
s.clear()
|
|
||||||
}
|
}
|
||||||
|
|
||||||
try {
|
try {
|
||||||
|
|
|
@ -1,4 +1,3 @@
|
||||||
import { ArraySet } from '../ArraySet'
|
|
||||||
import { atom } from '../Atom'
|
import { atom } from '../Atom'
|
||||||
import { computed } from '../Computed'
|
import { computed } from '../Computed'
|
||||||
import { react } from '../EffectScheduler'
|
import { react } from '../EffectScheduler'
|
||||||
|
@ -15,7 +14,6 @@ const emptyChild = (props: Partial<Child> = {}) =>
|
||||||
({
|
({
|
||||||
parentEpochs: [],
|
parentEpochs: [],
|
||||||
parents: [],
|
parents: [],
|
||||||
parentSet: new ArraySet(),
|
|
||||||
isActivelyListening: false,
|
isActivelyListening: false,
|
||||||
lastTraversedEpoch: 0,
|
lastTraversedEpoch: 0,
|
||||||
...props,
|
...props,
|
||||||
|
|
|
@ -3,6 +3,7 @@ import type { Child, Signal } from './types'
|
||||||
|
|
||||||
class CaptureStackFrame {
|
class CaptureStackFrame {
|
||||||
offset = 0
|
offset = 0
|
||||||
|
numNewParents = 0
|
||||||
|
|
||||||
maybeRemoved?: Signal<any>[]
|
maybeRemoved?: Signal<any>[]
|
||||||
|
|
||||||
|
@ -49,29 +50,33 @@ export function unsafe__withoutCapture<T>(fn: () => T): T {
|
||||||
|
|
||||||
export function startCapturingParents(child: Child) {
|
export function startCapturingParents(child: Child) {
|
||||||
inst.stack = new CaptureStackFrame(inst.stack, child)
|
inst.stack = new CaptureStackFrame(inst.stack, child)
|
||||||
child.parentSet.clear()
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export function stopCapturingParents() {
|
export function stopCapturingParents() {
|
||||||
const frame = inst.stack!
|
const frame = inst.stack!
|
||||||
inst.stack = frame.below
|
inst.stack = frame.below
|
||||||
|
|
||||||
if (frame.offset < frame.child.parents.length) {
|
const didParentsChange = frame.numNewParents > 0 || frame.offset !== frame.child.parents.length
|
||||||
for (let i = frame.offset; i < frame.child.parents.length; i++) {
|
|
||||||
const maybeRemovedParent = frame.child.parents[i]
|
|
||||||
if (!frame.child.parentSet.has(maybeRemovedParent)) {
|
|
||||||
detach(maybeRemovedParent, frame.child)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
frame.child.parents.length = frame.offset
|
if (!didParentsChange) {
|
||||||
frame.child.parentEpochs.length = frame.offset
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
|
for (let i = frame.offset; i < frame.child.parents.length; i++) {
|
||||||
|
const p = frame.child.parents[i]
|
||||||
|
const parentWasRemoved = frame.child.parents.indexOf(p) >= frame.offset
|
||||||
|
if (parentWasRemoved) {
|
||||||
|
detach(p, frame.child)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
frame.child.parents.length = frame.offset
|
||||||
|
frame.child.parentEpochs.length = frame.offset
|
||||||
|
|
||||||
if (inst.stack?.maybeRemoved) {
|
if (inst.stack?.maybeRemoved) {
|
||||||
for (let i = 0; i < inst.stack.maybeRemoved.length; i++) {
|
for (let i = 0; i < inst.stack.maybeRemoved.length; i++) {
|
||||||
const maybeRemovedParent = inst.stack.maybeRemoved[i]
|
const maybeRemovedParent = inst.stack.maybeRemoved[i]
|
||||||
if (!inst.stack.child.parentSet.has(maybeRemovedParent)) {
|
if (frame.child.parents.indexOf(maybeRemovedParent) === -1) {
|
||||||
detach(maybeRemovedParent, frame.child)
|
detach(maybeRemovedParent, frame.child)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -81,33 +86,34 @@ export function stopCapturingParents() {
|
||||||
// this must be called after the parent is up to date
|
// this must be called after the parent is up to date
|
||||||
export function maybeCaptureParent(p: Signal<any, any>) {
|
export function maybeCaptureParent(p: Signal<any, any>) {
|
||||||
if (inst.stack) {
|
if (inst.stack) {
|
||||||
const wasCapturedAlready = inst.stack.child.parentSet.has(p)
|
const idx = inst.stack.child.parents.indexOf(p)
|
||||||
// if the child didn't deref this parent last time it executed, then idx will be -1
|
// if the child didn't deref this parent last time it executed, then idx will be -1
|
||||||
// if the child did deref this parent last time but in a different order relative to other parents, then idx will be greater than stack.offset
|
// if the child did deref this parent last time but in a different order relative to other parents, then idx will be greater than stack.offset
|
||||||
// if the child did deref this parent last time in the same order, then idx will be the same as stack.offset
|
// if the child did deref this parent last time in the same order, then idx will be the same as stack.offset
|
||||||
// if the child did deref this parent already during this capture session then 0 <= idx < stack.offset
|
// if the child did deref this parent already during this capture session then 0 <= idx < stack.offset
|
||||||
|
|
||||||
if (wasCapturedAlready) {
|
if (idx < 0) {
|
||||||
return
|
inst.stack.numNewParents++
|
||||||
}
|
if (inst.stack.child.isActivelyListening) {
|
||||||
|
attach(p, inst.stack.child)
|
||||||
inst.stack.child.parentSet.add(p)
|
|
||||||
if (inst.stack.child.isActivelyListening) {
|
|
||||||
attach(p, inst.stack.child)
|
|
||||||
}
|
|
||||||
|
|
||||||
if (inst.stack.offset < inst.stack.child.parents.length) {
|
|
||||||
const maybeRemovedParent = inst.stack.child.parents[inst.stack.offset]
|
|
||||||
if (!inst.stack.maybeRemoved) {
|
|
||||||
inst.stack.maybeRemoved = [maybeRemovedParent]
|
|
||||||
} else {
|
|
||||||
inst.stack.maybeRemoved.push(maybeRemovedParent)
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
inst.stack.child.parents[inst.stack.offset] = p
|
if (idx < 0 || idx >= inst.stack.offset) {
|
||||||
inst.stack.child.parentEpochs[inst.stack.offset] = p.lastChangedEpoch
|
if (idx !== inst.stack.offset && idx > 0) {
|
||||||
inst.stack.offset++
|
const maybeRemovedParent = inst.stack.child.parents[inst.stack.offset]
|
||||||
|
|
||||||
|
if (!inst.stack.maybeRemoved) {
|
||||||
|
inst.stack.maybeRemoved = [maybeRemovedParent]
|
||||||
|
} else if (inst.stack.maybeRemoved.indexOf(maybeRemovedParent) === -1) {
|
||||||
|
inst.stack.maybeRemoved.push(maybeRemovedParent)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
inst.stack.child.parents[inst.stack.offset] = p
|
||||||
|
inst.stack.child.parentEpochs[inst.stack.offset] = p.lastChangedEpoch
|
||||||
|
inst.stack.offset++
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -51,9 +51,8 @@ export interface Signal<Value, Diff = unknown> {
|
||||||
/** @internal */
|
/** @internal */
|
||||||
export type Child = {
|
export type Child = {
|
||||||
lastTraversedEpoch: number
|
lastTraversedEpoch: number
|
||||||
readonly parentSet: ArraySet<Signal<any, any>>
|
parents: Signal<any, any>[]
|
||||||
readonly parents: Signal<any, any>[]
|
parentEpochs: number[]
|
||||||
readonly parentEpochs: number[]
|
|
||||||
isActivelyListening: boolean
|
isActivelyListening: boolean
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue