PrivateCoffee/tldraw
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

[fix] transform errors (#1772)

Browse source 
This PR fixes some over-cautious transform errors introduced in #1751. 

### Change Type

- [x] `patch` — Bug fix

### Test Plan

- [ ] Unit Tests
This commit is contained in:
Steve Ruiz 2023-07-27 17:27:35 +01:00 committed by GitHub
parent eb52eb4e30
commit acbd9ce0cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/editor/src/lib/editor/Editor.ts
View file

@ -3879,8 +3879,7 @@ export class Editor extends EventEmitter<TLEventMap> {
getParentTransform(id: TLShapeId): Matrix2d getParentTransform(id: TLShapeId): Matrix2d
getParentTransform(arg: TLShape | TLShapeId): Matrix2d { getParentTransform(arg: TLShape | TLShapeId): Matrix2d {
const shape = typeof arg === 'string' ? this.getShape(arg) : arg const shape = typeof arg === 'string' ? this.getShape(arg) : arg
if (!shape) throw Error('Editor.getParentTransform: shape not found') if (!shape || isPageId(shape.parentId)) return Matrix2d.Identity()
if (isPageId(shape.parentId)) return Matrix2d.Identity()
return this._pageTransformCache.get(shape.parentId) ?? Matrix2d.Identity() return this._pageTransformCache.get(shape.parentId) ?? Matrix2d.Identity()
} }
@ -3900,9 +3899,8 @@ export class Editor extends EventEmitter<TLEventMap> {
getPageTransform(id: TLShapeId): Matrix2d getPageTransform(id: TLShapeId): Matrix2d
getPageTransform(shape: TLShape): Matrix2d getPageTransform(shape: TLShape): Matrix2d
getPageTransform(arg: TLShape | TLShapeId): Matrix2d { getPageTransform(arg: TLShape | TLShapeId): Matrix2d {
const shape = typeof arg === 'string' ? this.getShape(arg) : arg const id = typeof arg === 'string' ? arg : this.getShape(arg)!.id
if (!shape) throw Error('Editor.getParentTransform: shape not found') return this._pageTransformCache.get(id) ?? Matrix2d.Identity()
return this._pageTransformCache.get(shape.id) ?? Matrix2d.Identity()
} }
/** /**