PrivateCoffee/tldraw
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix group opacity (#1997)

Browse source 
@SomeHats I'll leave this assigned to you in case you want to compare
the perf of using consts/lets scoped to the visitor function. Or just do
that anyway regardless of microperf. Either is fine with me.
This commit is contained in:
David Sheldrick 2023-10-03 11:42:34 +01:00 committed by GitHub
parent 2694a7ab48
commit a635145f2a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/editor/src/lib/editor/Editor.ts
View file

@ -3026,17 +3026,16 @@ export class Editor extends EventEmitter<TLEventMap> {
const isCullingOffScreenShapes = Number.isFinite(this.renderingBoundsMargin) const isCullingOffScreenShapes = Number.isFinite(this.renderingBoundsMargin)
let shape: TLShape | undefined let shape: TLShape | undefined
let opacity: number
let isShapeErasing: boolean let isShapeErasing: boolean
let isCulled: boolean let isCulled: boolean
let util: ShapeUtil let util: ShapeUtil
let maskedPageBounds: Box2d | undefined let maskedPageBounds: Box2d | undefined
const addShapeById = (id: TLShapeId, parentOpacity: number, isAncestorErasing: boolean) => { const addShapeById = (id: TLShapeId, opacity: number, isAncestorErasing: boolean) => {
shape = this.getShape(id) shape = this.getShape(id)
if (!shape) return if (!shape) return
opacity = shape.opacity * parentOpacity opacity *= shape.opacity
isShapeErasing = false isShapeErasing = false
isCulled = false isCulled = false
util = this.getShapeUtil(shape) util = this.getShapeUtil(shape)