[fix] Don't synchronize isReadOnly (#1396)
We were storing the state of whether or not a document is read-only in the store. It does not need to be stored there, and it was creating consistency problems for us, so let's not store it in there. fixes https://github.com/tldraw/brivate/issues/1864 ### Change Type <!-- 💡 Indicate the type of change your pull request is. --> <!-- 🤷♀️ If you're not sure, don't select anything --> <!-- ✂️ Feel free to delete unselected options --> <!-- To select one, put an x in the box: [x] --> - [ ] `patch` — Bug Fix - [ ] `minor` — New Feature - [x] `major` — Breaking Change - [ ] `dependencies` — Dependency Update (publishes a `patch` release, for devDependencies use `internal`) - [ ] `documentation` — Changes to the documentation only (will not publish a new version) - [ ] `tests` — Changes to any testing-related code only (will not publish a new version) - [ ] `internal` — Any other changes that don't affect the published package (will not publish a new version) ### Test Plan 1. Create a multiplayer room 2. Create a read-only link for the room 3. Paste the link into a new browser tab (not incognito, needs to have the same session state) 4. Check the room is read-only in the new tab 5. Check the room is still writable in the previous tab. ### Release Notes - Removes the isReadOnly value from the `user_document_settings` record type.
This commit is contained in:
parent
01487be6fa
commit
a3896fc492
9 changed files with 75 additions and 27 deletions
|
@ -32,6 +32,11 @@ export function generateSharedScripts(bublic: '<rootDir>' | '<rootDir>/bublic')
|
|||
test: {
|
||||
baseCommand: 'yarn run -T jest',
|
||||
runsAfter: { 'refresh-assets': {} },
|
||||
cache: {
|
||||
inputs: {
|
||||
exclude: ['*.tsbuildinfo'],
|
||||
},
|
||||
},
|
||||
},
|
||||
'test-coverage': {
|
||||
baseCommand: 'yarn run -T jest --coverage',
|
||||
|
@ -42,7 +47,7 @@ export function generateSharedScripts(bublic: '<rootDir>' | '<rootDir>/bublic')
|
|||
runsAfter: { 'build-types': {} },
|
||||
cache: {
|
||||
inputs: {
|
||||
exclude: ['**/*.tsbuildinfo'],
|
||||
exclude: ['*.tsbuildinfo'],
|
||||
},
|
||||
},
|
||||
},
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue