From 4b4c258219eafdf36d7a1b9299478eac9459b38a Mon Sep 17 00:00:00 2001 From: Lu Wilson Date: Tue, 19 Dec 2023 14:26:10 +0000 Subject: [PATCH] Stop shape text labels being hoverable when context menu is open (#2352) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes https://github.com/tldraw/tldraw/issues/2351 This css change shouldn't affect any other interactions. Tested on: - Mac Chrome - Mac Chrome with touch - Mac Safari - Mac Firefox ### Change Type - [x] `patch` — Bug fix - [ ] `minor` — New feature - [ ] `major` — Breaking change - [ ] `dependencies` — Changes to package dependencies[^1] - [ ] `documentation` — Changes to the documentation only[^2] - [ ] `tests` — Changes to any test code only[^2] - [ ] `internal` — Any other changes that don't affect the published package[^2] - [ ] I don't know [^1]: publishes a `patch` release, for devDependencies use `internal` [^2]: will not publish a new version ### Test Plan 1. Right click to open context menu. 2. Click on a filled shape's text label. 3. Make sure the context menu has closed. - [ ] Unit Tests - [ ] End to end tests ### Release Notes - Add a brief release note for your PR here. --- packages/editor/editor.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/editor/editor.css b/packages/editor/editor.css index e8a999971..e3b03b614 100644 --- a/packages/editor/editor.css +++ b/packages/editor/editor.css @@ -1079,7 +1079,7 @@ input, display: flex; align-items: center; justify-content: center; - pointer-events: all; + pointer-events: none; min-height: auto; }