Only upload playwright to S3 if we have the right credentials (#2074)
These credentials aren't available to non-tldraw contributors which was breaking uploads. --------- Co-authored-by: Steve Ruiz <steveruizok@gmail.com>
This commit is contained in:
parent
1f4df14d4f
commit
22955bb0ec
2 changed files with 14 additions and 1 deletions
5
.github/workflows/playwright.yml
vendored
5
.github/workflows/playwright.yml
vendored
|
@ -68,7 +68,10 @@ jobs:
|
||||||
retention-days: 30
|
retention-days: 30
|
||||||
|
|
||||||
- uses: shallwefootball/s3-upload-action@master
|
- uses: shallwefootball/s3-upload-action@master
|
||||||
if: always()
|
# only upload if we have AWS credentials:
|
||||||
|
env:
|
||||||
|
HAS_AWS_KEY: ${{ secrets.AWS_S3_SECRET_KEY && '1' || '' }}
|
||||||
|
if: always() && env.HAS_AWS_KEY == '1'
|
||||||
name: Upload S3
|
name: Upload S3
|
||||||
id: s3
|
id: s3
|
||||||
with:
|
with:
|
||||||
|
|
10
apps/examples/e2e/tests/test-ui.spec.ts
Normal file
10
apps/examples/e2e/tests/test-ui.spec.ts
Normal file
|
@ -0,0 +1,10 @@
|
||||||
|
import test from '@playwright/test'
|
||||||
|
import { setup } from '../shared-e2e'
|
||||||
|
|
||||||
|
test.describe('ui', () => {
|
||||||
|
test.beforeEach(setup)
|
||||||
|
|
||||||
|
test('mobile style panel opens and closes when tapped', async ({ isMobile }) => {
|
||||||
|
test.skip(!isMobile, 'only run on mobile')
|
||||||
|
})
|
||||||
|
})
|
Loading…
Reference in a new issue