PrivateCoffee/tldraw
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
tldraw/assets/icons/icon/clipboard-copied.svg

5 lines
893 B
XML
Raw Normal View History

share: make share/fork/copy actions clearer (#3846) Right now when you hit Share/Fork on production it can take a good 5 seconds for something to happen. In the meantime, it can feel like nothing happened when you clicked the button. Maybe you click it again to see if that'll fix it, which doesn't do anything. Same thing for the Copy action, sometimes we don't have an icon to subtly show that it's been copied. This adds some toasts and disables the Share menu while a project is being created. Also, has two drive-by fixes: - the getShareUrl logic is old and needed to be superseded by the new stuff - the icon fix for clipboard-copied.svg from the readonly omnibus PR (https://github.com/tldraw/tldraw/pull/3192) got overridden in a different PR (https://github.com/tldraw/tldraw/pull/3627) - this restores the fix <img width="304" alt="Screenshot 2024-05-30 at 11 38 39" src="https://github.com/tldraw/tldraw/assets/469604/f9a3b7c7-f9ea-41f0-ad00-7fc5d71da93f"> <img width="257" alt="Screenshot 2024-05-30 at 11 38 14" src="https://github.com/tldraw/tldraw/assets/469604/c0a2d762-64c3-44da-b61e-c237133dd8cd"> ### Change Type <!-- ❗ Please select a 'Scope' label ❗️ --> - [x] `sdk` — Changes the tldraw SDK - [ ] `dotcom` — Changes the tldraw.com web app - [ ] `docs` — Changes to the documentation, examples, or templates. - [ ] `vs code` — Changes to the vscode plugin - [ ] `internal` — Does not affect user-facing stuff <!-- ❗ Please select a 'Type' label ❗️ --> - [ ] `bugfix` — Bug fix - [ ] `feature` — New feature - [x] `improvement` — Improving existing features - [ ] `chore` — Updating dependencies, other boring stuff - [ ] `galaxy brain` — Architectural changes - [ ] `tests` — Changes to any test code - [ ] `tools` — Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` — I don't know ### Release Notes - Share menu: make sharing/fork/copy actions clearer
2024-06-03 08:42:08 +00:00
<svg width="30" height="30" viewBox="0 0 30 30" fill="none" xmlns="http://www.w3.org/2000/svg">
open menus refactor (#1400) This PR makes a change to how open menus are handled. ### Change Type - [x] `minor` — New Feature
2023-05-17 14:30:28 +00:00
<path fill-rule="evenodd" clip-rule="evenodd" d="M8 2V4H18V2H8ZM6 1.5C6 0.671573 6.67157 0 7.5 0H18.5C19.3284 0 20 0.671572 20 1.5V2H21C22.6569 2 24 3.34315 24 5V14H22V5C22 4.44772 21.5523 4 21 4H20V4.5C20 5.32843 19.3284 6 18.5 6H7.5C6.67157 6 6 5.32843 6 4.5V4H5C4.44771 4 4 4.44772 4 5V25C4 25.5523 4.44772 26 5 26H12V28H5C3.34315 28 2 26.6569 2 25V5C2 3.34314 3.34315 2 5 2H6V1.5Z" fill="black"/>
<path d="M27.5197 17.173C28.0099 17.4936 28.1475 18.1509 27.827 18.6411L20.6149 29.6713C20.445 29.9313 20.1696 30.1037 19.8615 30.143C19.5534 30.1823 19.2436 30.0846 19.0138 29.8757L14.3472 25.6333C13.9137 25.2393 13.8818 24.5685 14.2758 24.1351C14.6698 23.7017 15.3406 23.6697 15.774 24.0638L19.5203 27.4694L26.0516 17.4803C26.3721 16.9901 27.0294 16.8525 27.5197 17.173Z" fill="black"/>
</svg>
Reference in a new issue Copy permalink