PrivateCoffee/privatecoffee-website
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: enhance icon loading robustness

Browse source 
Improved the `icon` function to handle attribute errors gracefully by falling back to an alternative reading method. This change addresses potential situations where the `file.response.file` attribute does not exist, ensuring icons are consistently loaded without causing runtime errors. The fallback method, `file.response.read()`, provides a reliable alternative for retrieving SVG files, thus enhancing the application's resilience and user experience.
This commit is contained in:
Kumi 2024-05-29 19:02:19 +02:00
parent e77fc521bf
commit 45e6b36260
Signed by: kumi
GPG key ID: ECBCC9082395383F
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
main.py
View file

@ -83,9 +83,13 @@ if os.environ.get("PRIVATECOFFEE_DEV"):
def icon(icon_name): def icon(icon_name):
file = send_from_directory("assets", f"dist/icons/{icon_name}.svg") file = send_from_directory("assets", f"dist/icons/{icon_name}.svg")
try:
file_content = file.response.file.read().decode("utf-8") file_content = file.response.file.read().decode("utf-8")
except AttributeError:
file_content = file.response.read().decode("utf-8")
return file_content return file_content
app.add_template_filter(icon) app.add_template_filter(icon)
if __name__ == "__main__": if __name__ == "__main__":