b981a96b29
* Add unexposed account setting for hiding poll creation This is to match the sticker picker setting we already have, but not exposed in the user settings until we decide if we actually want it to be there. This is primarily intended to be used in environments that disable it at the config level, though given there's multiple people in the wild who have asked for this, it seems reasonable to expose it as a hidden setting instead. Note that as of writing it's not clear if any of those requests made it as far as an issue tracker. Typically for the usecase presented we'd add a new UIFeature flag, however this *feels* wrong for the case at hand. * Move visibility check way higher * Fix i18n post-merge
263 lines
8 KiB
TypeScript
263 lines
8 KiB
TypeScript
/*
|
|
Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import React from "react";
|
|
import { mount, ReactWrapper } from "enzyme";
|
|
import { Room } from "matrix-js-sdk/src/models/room";
|
|
import { RoomMember } from "matrix-js-sdk/src/models/room-member";
|
|
|
|
import * as TestUtils from "../../../test-utils";
|
|
import sdk from "../../../skinned-sdk";
|
|
import MatrixClientContext from "../../../../src/contexts/MatrixClientContext";
|
|
import { Layout } from "../../../../src/settings/enums/Layout";
|
|
import RoomContext, { TimelineRenderingType } from "../../../../src/contexts/RoomContext";
|
|
import { createTestClient } from "../../../test-utils";
|
|
import { IRoomState } from "../../../../src/components/structures/RoomView";
|
|
import { MatrixClientPeg } from "../../../../src/MatrixClientPeg";
|
|
|
|
const _MessageComposerButtons = sdk.getComponent("views.rooms.MessageComposerButtons");
|
|
const MessageComposerButtons = TestUtils.wrapInMatrixClientContext(
|
|
_MessageComposerButtons,
|
|
);
|
|
|
|
describe("MessageComposerButtons", () => {
|
|
it("Renders emoji and upload buttons in wide mode", () => {
|
|
const buttons = wrapAndRender(
|
|
<MessageComposerButtons
|
|
isMenuOpen={false}
|
|
showLocationButton={true}
|
|
showPollsButton={true}
|
|
showStickersButton={true}
|
|
toggleButtonMenu={() => {}}
|
|
/>,
|
|
false,
|
|
);
|
|
|
|
expect(buttonLabels(buttons)).toEqual([
|
|
"Emoji",
|
|
"Attachment",
|
|
"More options",
|
|
]);
|
|
});
|
|
|
|
it("Renders other buttons in menu in wide mode", () => {
|
|
const buttons = wrapAndRender(
|
|
<MessageComposerButtons
|
|
isMenuOpen={true}
|
|
showLocationButton={true}
|
|
showPollsButton={true}
|
|
showStickersButton={true}
|
|
toggleButtonMenu={() => {}}
|
|
/>,
|
|
false,
|
|
);
|
|
|
|
expect(buttonLabels(buttons)).toEqual([
|
|
"Emoji",
|
|
"Attachment",
|
|
"More options",
|
|
[
|
|
"Sticker",
|
|
"Voice Message",
|
|
"Poll",
|
|
"Location",
|
|
],
|
|
]);
|
|
});
|
|
|
|
it("Renders only some buttons in narrow mode", () => {
|
|
const buttons = wrapAndRender(
|
|
<MessageComposerButtons
|
|
isMenuOpen={false}
|
|
showLocationButton={true}
|
|
showPollsButton={true}
|
|
showStickersButton={true}
|
|
toggleButtonMenu={() => {}}
|
|
/>,
|
|
true,
|
|
);
|
|
|
|
expect(buttonLabels(buttons)).toEqual([
|
|
"Emoji",
|
|
"More options",
|
|
]);
|
|
});
|
|
|
|
it("Renders other buttons in menu (except voice messages) in narrow mode", () => {
|
|
const buttons = wrapAndRender(
|
|
<MessageComposerButtons
|
|
isMenuOpen={true}
|
|
showLocationButton={true}
|
|
showPollsButton={true}
|
|
showStickersButton={true}
|
|
toggleButtonMenu={() => {}}
|
|
/>,
|
|
true,
|
|
);
|
|
|
|
expect(buttonLabels(buttons)).toEqual([
|
|
"Emoji",
|
|
"More options",
|
|
[
|
|
"Attachment",
|
|
"Sticker",
|
|
"Poll",
|
|
"Location",
|
|
],
|
|
]);
|
|
});
|
|
|
|
describe('polls button', () => {
|
|
it('should render when asked to', () => {
|
|
const buttons = wrapAndRender(
|
|
<MessageComposerButtons
|
|
isMenuOpen={true}
|
|
showLocationButton={true}
|
|
showPollsButton={true}
|
|
showStickersButton={true}
|
|
toggleButtonMenu={() => {}}
|
|
/>,
|
|
true,
|
|
);
|
|
|
|
expect(buttonLabels(buttons)).toEqual([
|
|
"Emoji",
|
|
"More options",
|
|
[
|
|
"Attachment",
|
|
"Sticker",
|
|
"Poll",
|
|
"Location",
|
|
],
|
|
]);
|
|
});
|
|
|
|
it('should not render when asked not to', () => {
|
|
const buttons = wrapAndRender(
|
|
<MessageComposerButtons
|
|
isMenuOpen={true}
|
|
showLocationButton={true}
|
|
showPollsButton={false} // !! the change from the alternate test
|
|
showStickersButton={true}
|
|
toggleButtonMenu={() => {}}
|
|
/>,
|
|
true,
|
|
);
|
|
|
|
expect(buttonLabels(buttons)).toEqual([
|
|
"Emoji",
|
|
"More options",
|
|
[
|
|
"Attachment",
|
|
"Sticker",
|
|
// "Poll", // should be hidden
|
|
"Location",
|
|
],
|
|
]);
|
|
});
|
|
});
|
|
});
|
|
|
|
function wrapAndRender(component: React.ReactElement, narrow: boolean): ReactWrapper {
|
|
const mockClient = MatrixClientPeg.matrixClient = createTestClient();
|
|
const roomId = "myroomid";
|
|
const mockRoom: any = {
|
|
currentState: undefined,
|
|
roomId,
|
|
client: mockClient,
|
|
getMember: function(userId: string): RoomMember {
|
|
return new RoomMember(roomId, userId);
|
|
},
|
|
};
|
|
const roomState = createRoomState(mockRoom, narrow);
|
|
|
|
return mount(
|
|
<MatrixClientContext.Provider value={mockClient}>
|
|
<RoomContext.Provider value={roomState}>
|
|
{ component }
|
|
</RoomContext.Provider>
|
|
</MatrixClientContext.Provider>,
|
|
);
|
|
}
|
|
|
|
function createRoomState(room: Room, narrow: boolean): IRoomState {
|
|
return {
|
|
room: room,
|
|
roomId: room.roomId,
|
|
roomLoading: true,
|
|
peekLoading: false,
|
|
shouldPeek: true,
|
|
membersLoaded: false,
|
|
numUnreadMessages: 0,
|
|
searching: false,
|
|
guestsCanJoin: false,
|
|
canPeek: false,
|
|
showApps: false,
|
|
isPeeking: false,
|
|
showRightPanel: true,
|
|
joining: false,
|
|
atEndOfLiveTimeline: true,
|
|
atEndOfLiveTimelineInit: false,
|
|
showTopUnreadMessagesBar: false,
|
|
statusBarVisible: false,
|
|
canReact: false,
|
|
canSendMessages: false,
|
|
layout: Layout.Group,
|
|
lowBandwidth: false,
|
|
alwaysShowTimestamps: false,
|
|
showTwelveHourTimestamps: false,
|
|
readMarkerInViewThresholdMs: 3000,
|
|
readMarkerOutOfViewThresholdMs: 30000,
|
|
showHiddenEventsInTimeline: false,
|
|
showReadReceipts: true,
|
|
showRedactions: true,
|
|
showJoinLeaves: true,
|
|
showAvatarChanges: true,
|
|
showDisplaynameChanges: true,
|
|
matrixClientIsReady: false,
|
|
timelineRenderingType: TimelineRenderingType.Room,
|
|
liveTimeline: undefined,
|
|
narrow,
|
|
};
|
|
}
|
|
|
|
function buttonLabels(buttons: ReactWrapper): any[] {
|
|
// Note: Depends on the fact that the mini buttons use aria-label
|
|
// and the labels under More options use textContent
|
|
const mainButtons = (
|
|
buttons
|
|
.find('div.mx_MessageComposer_button[aria-label]')
|
|
.map((button: ReactWrapper) => button.prop("aria-label") as string)
|
|
.filter(x => x)
|
|
);
|
|
|
|
const extraButtons = (
|
|
buttons
|
|
.find('.mx_MessageComposer_Menu div.mx_AccessibleButton[role="menuitem"]')
|
|
.map((button: ReactWrapper) => button.text())
|
|
.filter(x => x)
|
|
);
|
|
|
|
const list: any[] = [
|
|
...mainButtons,
|
|
];
|
|
|
|
if (extraButtons.length > 0) {
|
|
list.push(extraButtons);
|
|
}
|
|
|
|
return list;
|
|
}
|