0d6a550c33
* Improve accessibility and testability of Tooltip Adding a role to Tooltip was motivated by React Testing Library's reliance on accessibility-related attributes to locate elements. * Make the ReadyWatchingStore constructor safer The ReadyWatchingStore constructor previously had a chance to immediately call onReady, which was dangerous because it was potentially calling the derived class's onReady at a point when the derived class hadn't even finished construction yet. In normal usage, I guess this never was a problem, but it was causing some of the tests I was writing to crash. This is solved by separating out the onReady call into a start method. * Rename 1:1 call components to 'LegacyCall' to reflect the fact that they're slated for removal, and to not clash with the new Call code. * Refactor VideoChannelStore into Call and CallStore Call is an abstract class that currently only has a Jitsi implementation, but this will make it easy to later add an Element Call implementation. * Remove WidgetReady, ClientReady, and ForceHangupCall hacks These are no longer used by the new Jitsi call implementation, and can be removed. * yarn i18n * Delete call map entries instead of inserting nulls * Allow multiple active calls and consolidate call listeners * Fix a race condition when creating a video room * Un-hardcode the media device fallback labels * Apply misc code review fixes * yarn i18n * Disconnect from calls more politely on logout * Fix some strict mode errors * Fix another updateRoom race condition
104 lines
3.6 KiB
TypeScript
104 lines
3.6 KiB
TypeScript
|
|
/*
|
|
Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import { MatrixClient } from "matrix-js-sdk/src/matrix";
|
|
|
|
import { VoiceRecording } from '../../src/audio/VoiceRecording';
|
|
import { VoiceRecordingStore } from '../../src/stores/VoiceRecordingStore';
|
|
import { MatrixClientPeg } from "../../src/MatrixClientPeg";
|
|
import { flushPromises } from "../test-utils";
|
|
|
|
const stubClient = {} as undefined as MatrixClient;
|
|
jest.spyOn(MatrixClientPeg, 'get').mockReturnValue(stubClient);
|
|
|
|
describe('VoiceRecordingStore', () => {
|
|
const room1Id = '!room1:server.org';
|
|
const room2Id = '!room2:server.org';
|
|
const room3Id = '!room3:server.org';
|
|
const room1Recording = { destroy: jest.fn() } as unknown as VoiceRecording;
|
|
const room2Recording = { destroy: jest.fn() } as unknown as VoiceRecording;
|
|
|
|
const state = {
|
|
[room1Id]: room1Recording,
|
|
[room2Id]: room2Recording,
|
|
[room3Id]: undefined,
|
|
};
|
|
|
|
const mkStore = (): VoiceRecordingStore => {
|
|
const store = new VoiceRecordingStore();
|
|
store.start();
|
|
return store;
|
|
};
|
|
|
|
describe('startRecording()', () => {
|
|
it('throws when roomId is falsy', () => {
|
|
const store = mkStore();
|
|
expect(() => store.startRecording(undefined)).toThrow("Recording must be associated with a room");
|
|
});
|
|
|
|
it('throws when room already has a recording', () => {
|
|
const store = mkStore();
|
|
// @ts-ignore
|
|
store.storeState = state;
|
|
expect(() => store.startRecording(room2Id)).toThrow("A recording is already in progress");
|
|
});
|
|
|
|
it('creates and adds recording to state', async () => {
|
|
const store = mkStore();
|
|
const result = store.startRecording(room2Id);
|
|
|
|
await flushPromises();
|
|
|
|
expect(result).toBeInstanceOf(VoiceRecording);
|
|
expect(store.getActiveRecording(room2Id)).toEqual(result);
|
|
});
|
|
});
|
|
|
|
describe('disposeRecording()', () => {
|
|
it('destroys recording for a room if it exists in state', async () => {
|
|
const store = mkStore();
|
|
// @ts-ignore
|
|
store.storeState = state;
|
|
|
|
await store.disposeRecording(room1Id);
|
|
|
|
expect(room1Recording.destroy).toHaveBeenCalled();
|
|
});
|
|
|
|
it('removes room from state when it has a recording', async () => {
|
|
const store = mkStore();
|
|
// @ts-ignore
|
|
store.storeState = state;
|
|
|
|
await store.disposeRecording(room2Id);
|
|
|
|
expect(store.getActiveRecording(room2Id)).toBeFalsy();
|
|
});
|
|
|
|
it('removes room from state when it has a falsy recording', async () => {
|
|
const store = mkStore();
|
|
// @ts-ignore
|
|
store.storeState = state;
|
|
|
|
await store.disposeRecording(room3Id);
|
|
|
|
expect(store.getActiveRecording(room1Id)).toEqual(room1Recording);
|
|
expect(store.getActiveRecording(room2Id)).toEqual(room2Recording);
|
|
expect(store.getActiveRecording(room3Id)).toBeFalsy();
|
|
});
|
|
});
|
|
});
|