e946674df3
* Add Stores and StoresContext and use it in MatrixChat and RoomView Added a new kind of class: - Add God object `Stores` which will hold refs to all known stores and the `MatrixClient`. This object is NOT a singleton. - Add `StoresContext` to hold onto a ref of `Stores` for use inside components. `StoresContext` is created via: - Create `Stores` in `MatrixChat`, assigning the `MatrixClient` when we have one set. Currently sets the RVS to `RoomViewStore.instance`. - Wrap `MatrixChat`s `render()` function in a `StoresContext.Provider` so it can be used anywhere. `StoresContext` is currently only used in `RoomView` via the following changes: - Remove the HOC, which redundantly set `mxClient` as a prop. We don't need this as `RoomView` was using the client from `this.context`. - Change the type of context accepted from `MatrixClientContext` to `StoresContext`. - Modify alllll the places where `this.context` is used to interact with the client and suffix `.client`. - Modify places where we use `RoomViewStore.instance` and replace them with `this.context.roomViewStore`. This makes `RoomView` use a non-global instance of RVS. * Linting * SDKContext and make client an optional constructor arg * Move SDKContext to /src/contexts * Inject all RVS deps * Linting * Remove reset calls; deep copy the INITIAL_STATE to avoid test pollution * DI singletons used in RoomView; DI them in RoomView-test too * Initial RoomViewStore.instance after all files are imported to avoid cyclical deps * Lazily init stores to allow for circular dependencies Rather than stores accepting a list of other stores in their constructors, which doesn't work when A needs B and B needs A, make new-style stores simply accept Stores. When a store needs another store, they access it via `Stores` which then lazily constructs that store if it needs it. This breaks the circular dependency at constructor time, without needing to introduce wiring diagrams or any complex DI framework. * Delete RoomViewStore.instance Replaced with Stores.instance.roomViewStore * Linting * Move OverridableStores to test/TestStores * Rejig how eager stores get made; don't automatically do it else tests break * Linting * Linting and review comments * Fix new code to use Stores.instance * s/Stores/SdkContextClass/g * Update docs * Remove unused imports * Update src/stores/RoomViewStore.tsx Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> * Remove empty c'tor to make sonar happy Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
198 lines
6.7 KiB
TypeScript
198 lines
6.7 KiB
TypeScript
/*
|
|
Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import { MatrixClient, Room } from 'matrix-js-sdk/src/matrix';
|
|
import { mocked } from 'jest-mock';
|
|
|
|
import { Command, Commands, getCommand } from '../src/SlashCommands';
|
|
import { createTestClient } from './test-utils';
|
|
import { MatrixClientPeg } from '../src/MatrixClientPeg';
|
|
import { LocalRoom, LOCAL_ROOM_ID_PREFIX } from '../src/models/LocalRoom';
|
|
import SettingsStore from '../src/settings/SettingsStore';
|
|
import LegacyCallHandler from '../src/LegacyCallHandler';
|
|
import { SdkContextClass } from '../src/contexts/SDKContext';
|
|
|
|
describe('SlashCommands', () => {
|
|
let client: MatrixClient;
|
|
const roomId = "!room:example.com";
|
|
let room: Room;
|
|
const localRoomId = LOCAL_ROOM_ID_PREFIX + "test";
|
|
let localRoom: LocalRoom;
|
|
let command: Command;
|
|
|
|
const findCommand = (cmd: string): Command => {
|
|
return Commands.find((command: Command) => command.command === cmd);
|
|
};
|
|
|
|
const setCurrentRoom = (): void => {
|
|
mocked(SdkContextClass.instance.roomViewStore.getRoomId).mockReturnValue(roomId);
|
|
mocked(client.getRoom).mockImplementation((rId: string): Room => {
|
|
if (rId === roomId) return room;
|
|
});
|
|
};
|
|
|
|
const setCurrentLocalRoon = (): void => {
|
|
mocked(SdkContextClass.instance.roomViewStore.getRoomId).mockReturnValue(localRoomId);
|
|
mocked(client.getRoom).mockImplementation((rId: string): Room => {
|
|
if (rId === localRoomId) return localRoom;
|
|
});
|
|
};
|
|
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
|
|
client = createTestClient();
|
|
jest.spyOn(MatrixClientPeg, 'get').mockReturnValue(client);
|
|
|
|
room = new Room(roomId, client, client.getUserId());
|
|
localRoom = new LocalRoom(localRoomId, client, client.getUserId());
|
|
|
|
jest.spyOn(SdkContextClass.instance.roomViewStore, "getRoomId");
|
|
});
|
|
|
|
describe('/topic', () => {
|
|
it('sets topic', async () => {
|
|
const command = getCommand("/topic pizza");
|
|
expect(command.cmd).toBeDefined();
|
|
expect(command.args).toBeDefined();
|
|
await command.cmd.run("room-id", null, command.args);
|
|
expect(client.setRoomTopic).toHaveBeenCalledWith("room-id", "pizza", undefined);
|
|
});
|
|
});
|
|
|
|
describe.each([
|
|
["upgraderoom"],
|
|
["myroomnick"],
|
|
["roomavatar"],
|
|
["myroomavatar"],
|
|
["topic"],
|
|
["roomname"],
|
|
["invite"],
|
|
["part"],
|
|
["remove"],
|
|
["ban"],
|
|
["unban"],
|
|
["op"],
|
|
["deop"],
|
|
["addwidget"],
|
|
["discardsession"],
|
|
["whois"],
|
|
["holdcall"],
|
|
["unholdcall"],
|
|
["converttodm"],
|
|
["converttoroom"],
|
|
])("/%s", (commandName: string) => {
|
|
beforeEach(() => {
|
|
command = findCommand(commandName);
|
|
});
|
|
|
|
describe("isEnabled", () => {
|
|
it("should return true for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(true);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("/tovirtual", () => {
|
|
beforeEach(() => {
|
|
command = findCommand("tovirtual");
|
|
});
|
|
|
|
describe("isEnabled", () => {
|
|
describe("when virtual rooms are supported", () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(LegacyCallHandler.instance, "getSupportsVirtualRooms").mockReturnValue(true);
|
|
});
|
|
|
|
it("should return true for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(true);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("when virtual rooms are not supported", () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(LegacyCallHandler.instance, "getSupportsVirtualRooms").mockReturnValue(false);
|
|
});
|
|
|
|
it("should return false for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("/remakeolm", () => {
|
|
beforeEach(() => {
|
|
command = findCommand("remakeolm");
|
|
});
|
|
|
|
describe("isEnabled", () => {
|
|
describe("when developer mode is enabled", () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(SettingsStore, "getValue").mockImplementation((settingName: string) => {
|
|
if (settingName === "developerMode") return true;
|
|
});
|
|
});
|
|
|
|
it("should return true for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(true);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("when developer mode is not enabled", () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(SettingsStore, "getValue").mockImplementation((settingName: string) => {
|
|
if (settingName === "developerMode") return false;
|
|
});
|
|
});
|
|
|
|
it("should return false for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|