0d6a550c33
* Improve accessibility and testability of Tooltip Adding a role to Tooltip was motivated by React Testing Library's reliance on accessibility-related attributes to locate elements. * Make the ReadyWatchingStore constructor safer The ReadyWatchingStore constructor previously had a chance to immediately call onReady, which was dangerous because it was potentially calling the derived class's onReady at a point when the derived class hadn't even finished construction yet. In normal usage, I guess this never was a problem, but it was causing some of the tests I was writing to crash. This is solved by separating out the onReady call into a start method. * Rename 1:1 call components to 'LegacyCall' to reflect the fact that they're slated for removal, and to not clash with the new Call code. * Refactor VideoChannelStore into Call and CallStore Call is an abstract class that currently only has a Jitsi implementation, but this will make it easy to later add an Element Call implementation. * Remove WidgetReady, ClientReady, and ForceHangupCall hacks These are no longer used by the new Jitsi call implementation, and can be removed. * yarn i18n * Delete call map entries instead of inserting nulls * Allow multiple active calls and consolidate call listeners * Fix a race condition when creating a video room * Un-hardcode the media device fallback labels * Apply misc code review fixes * yarn i18n * Disconnect from calls more politely on logout * Fix some strict mode errors * Fix another updateRoom race condition
198 lines
6.6 KiB
TypeScript
198 lines
6.6 KiB
TypeScript
/*
|
|
Copyright 2022 The Matrix.org Foundation C.I.C.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
import { MatrixClient, Room } from 'matrix-js-sdk/src/matrix';
|
|
import { mocked } from 'jest-mock';
|
|
|
|
import { Command, Commands, getCommand } from '../src/SlashCommands';
|
|
import { createTestClient } from './test-utils';
|
|
import { MatrixClientPeg } from '../src/MatrixClientPeg';
|
|
import { LocalRoom, LOCAL_ROOM_ID_PREFIX } from '../src/models/LocalRoom';
|
|
import { RoomViewStore } from '../src/stores/RoomViewStore';
|
|
import SettingsStore from '../src/settings/SettingsStore';
|
|
import LegacyCallHandler from '../src/LegacyCallHandler';
|
|
|
|
describe('SlashCommands', () => {
|
|
let client: MatrixClient;
|
|
const roomId = "!room:example.com";
|
|
let room: Room;
|
|
const localRoomId = LOCAL_ROOM_ID_PREFIX + "test";
|
|
let localRoom: LocalRoom;
|
|
let command: Command;
|
|
|
|
const findCommand = (cmd: string): Command => {
|
|
return Commands.find((command: Command) => command.command === cmd);
|
|
};
|
|
|
|
const setCurrentRoom = (): void => {
|
|
mocked(RoomViewStore.instance.getRoomId).mockReturnValue(roomId);
|
|
mocked(client.getRoom).mockImplementation((rId: string): Room => {
|
|
if (rId === roomId) return room;
|
|
});
|
|
};
|
|
|
|
const setCurrentLocalRoon = (): void => {
|
|
mocked(RoomViewStore.instance.getRoomId).mockReturnValue(localRoomId);
|
|
mocked(client.getRoom).mockImplementation((rId: string): Room => {
|
|
if (rId === localRoomId) return localRoom;
|
|
});
|
|
};
|
|
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
|
|
client = createTestClient();
|
|
jest.spyOn(MatrixClientPeg, 'get').mockReturnValue(client);
|
|
|
|
room = new Room(roomId, client, client.getUserId());
|
|
localRoom = new LocalRoom(localRoomId, client, client.getUserId());
|
|
|
|
jest.spyOn(RoomViewStore.instance, "getRoomId");
|
|
});
|
|
|
|
describe('/topic', () => {
|
|
it('sets topic', async () => {
|
|
const command = getCommand("/topic pizza");
|
|
expect(command.cmd).toBeDefined();
|
|
expect(command.args).toBeDefined();
|
|
await command.cmd.run("room-id", null, command.args);
|
|
expect(client.setRoomTopic).toHaveBeenCalledWith("room-id", "pizza", undefined);
|
|
});
|
|
});
|
|
|
|
describe.each([
|
|
["upgraderoom"],
|
|
["myroomnick"],
|
|
["roomavatar"],
|
|
["myroomavatar"],
|
|
["topic"],
|
|
["roomname"],
|
|
["invite"],
|
|
["part"],
|
|
["remove"],
|
|
["ban"],
|
|
["unban"],
|
|
["op"],
|
|
["deop"],
|
|
["addwidget"],
|
|
["discardsession"],
|
|
["whois"],
|
|
["holdcall"],
|
|
["unholdcall"],
|
|
["converttodm"],
|
|
["converttoroom"],
|
|
])("/%s", (commandName: string) => {
|
|
beforeEach(() => {
|
|
command = findCommand(commandName);
|
|
});
|
|
|
|
describe("isEnabled", () => {
|
|
it("should return true for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(true);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("/tovirtual", () => {
|
|
beforeEach(() => {
|
|
command = findCommand("tovirtual");
|
|
});
|
|
|
|
describe("isEnabled", () => {
|
|
describe("when virtual rooms are supported", () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(LegacyCallHandler.instance, "getSupportsVirtualRooms").mockReturnValue(true);
|
|
});
|
|
|
|
it("should return true for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(true);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("when virtual rooms are not supported", () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(LegacyCallHandler.instance, "getSupportsVirtualRooms").mockReturnValue(false);
|
|
});
|
|
|
|
it("should return false for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("/remakeolm", () => {
|
|
beforeEach(() => {
|
|
command = findCommand("remakeolm");
|
|
});
|
|
|
|
describe("isEnabled", () => {
|
|
describe("when developer mode is enabled", () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(SettingsStore, "getValue").mockImplementation((settingName: string) => {
|
|
if (settingName === "developerMode") return true;
|
|
});
|
|
});
|
|
|
|
it("should return true for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(true);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe("when developer mode is not enabled", () => {
|
|
beforeEach(() => {
|
|
jest.spyOn(SettingsStore, "getValue").mockImplementation((settingName: string) => {
|
|
if (settingName === "developerMode") return false;
|
|
});
|
|
});
|
|
|
|
it("should return false for Room", () => {
|
|
setCurrentRoom();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
|
|
it("should return false for LocalRoom", () => {
|
|
setCurrentLocalRoon();
|
|
expect(command.isEnabled()).toBe(false);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
});
|