Commit graph

103 commits

Author SHA1 Message Date
Michael Telatynski
f758cbd38a
Make more of the codebase conform to strict types (#10859) 2023-05-12 09:49:37 +01:00
Andy Balaam
aa8c0f5cc7
Honour feature toggles in guest mode (#10651)
* Honour feature toggles in guest mode

* Suppress TS warning about returning null MatrixClient

* Revert "Suppress TS warning about returning null MatrixClient"

Don't ts-ignore this - we will eventually fix it via the strict work.

This reverts commit 0c657e6afd4c69d07c39bc2783184f36feaf940f.
2023-04-24 10:02:17 +00:00
Michael Weimann
c30b2637c5 Changes for v3.69.0 2023-03-28 11:23:16 +01:00
Michael Telatynski
145a5a8a8d
Conform more code to strict null checking (#10153)
* Conform more code to strict null checking

* Conform more code to strict null checking

* Iterate

* Iterate
2023-02-15 13:36:22 +00:00
Michael Telatynski
61a63e47f4
Comply with noImplicitAny (#9940)
* Stash noImplicitAny work

* Stash

* Fix imports

* Iterate

* Fix tests

* Delint

* Fix tests
2023-02-13 11:39:16 +00:00
Michael Telatynski
030b7e90bf
Enable @typescript-eslint/explicit-function-return-type in /src (#9788)
* Enable `@typescript-eslint/explicit-member-accessibility` on /src

* Prettier

* Enable `@typescript-eslint/explicit-function-return-type` in /src

* Fix types

* tsc strict fixes

* Delint

* Fix test

* Fix bad merge
2023-01-12 13:25:14 +00:00
Michael Telatynski
f1e8e7f140
Enable @typescript-eslint/explicit-member-accessibility on /src (#9785)
* Enable `@typescript-eslint/explicit-member-accessibility` on /src

* Prettier
2022-12-16 12:29:59 +00:00
Michael Weimann
526645c791
Apply prettier formatting 2022-12-12 12:24:14 +01:00
Travis Ralston
0697d1d6d4
Fix race condition in AccountSettingsHandler local echo (#9172)
Should fix https://github.com/vector-im/element-web/issues/23006
2022-08-10 17:34:21 -06:00
Travis Ralston
32478db57e
Migrate the hidden read receipts flag to new "send read receipts" option (#9141)
* Migrate the hidden read receipts flag to new "send read receipts" option

For safety.

* Appease linter & ignore guests

* `void`
2022-08-08 13:48:28 -06:00
Michael Telatynski
424d33d4b0
Fix PlatformSettingsHandler always returning true due to returning a Promise (#8954)
* Fix PlatformSettingsHandler always returning true due to returning a Promise

* Improve typescript
2022-06-30 14:48:21 +00:00
Michael Telatynski
ba2ce5ecba
Abstract electron settings properly to avoid boilerplate-hell (#8798)
* Remove unused method `BasePlatform::screenCaptureErrorString`

* Improve platform typescripting

* Remove redundant awaits

* Abstract electron settings properly to avoid boilerplate-hell

* i18n

* Fix stray semi-colons

* Fix setting level order for Platform settings
2022-06-10 22:38:50 +01:00
Robin
0b0e414fd4
Fix unresponsive notification toggles (#8549)
* Return consistently typed setting values from localStorage

* Watch notification toggles

* Test that it all works
2022-05-10 09:13:02 -04:00
Michael Telatynski
5cdc8fb3fd
Fix reading of cached room device setting values (#8491)
* Fix reading of cached room device setting values

* Add tests
2022-05-04 15:54:59 +01:00
Michael Telatynski
633229ca26
Clear local storage settings handler cache on logout (#8454) 2022-05-02 03:23:43 +01:00
Michael Telatynski
859fdf7d51
Cache localStorage objects for SettingsStore (#8366) 2022-04-20 08:44:06 +00:00
Travis Ralston
d8a939df5d
Use & enforce snake_case naming convention on config.json settings (#8062)
* Document and support the established naming convention for config opts

This change:
* Rename `ConfigOptions` to `IConfigOptions` to match code convention/style, plus move it to a dedicated file
* Update comments and surrounding documentation
* Define every single documented option (from element-web's config.md)
* Enable a linter to enforce the convention
* Invent a translation layer for a different change to use
* No attempt to fix build errors from doing this (at this stage)

* Add demo of lint rule in action

* Fix all obvious instances of SdkConfig case conflicts

* Fix tests to use SdkConfig directly

* Add docs to make unset() calling safer

* Appease the linter

* Update documentation to match snake_case_config

* Fix more instances of square brackets off SdkConfig
2022-03-18 10:12:36 -06:00
J. Ryan Stinnett
3426c3c3cd
Fix room account settings (#7999) 2022-03-07 17:51:20 +00:00
Šimon Brandner
675b4271e9
Rename MessageComposerInput.insertTrailingComma to MessageComposerInput.insertTrailingColon (#7981) 2022-03-04 15:13:50 +00:00
Šimon Brandner
4c05b7da1f
Make trailing : into a setting (#6711)
* Make trailing `:` into a setting

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Make traling comma opt-out

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Write `insertTrailingComma` when reading for future opt-in setting

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Update src/editor/parts.ts

* Fix line length

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

Co-authored-by: Travis Ralston <travpc@gmail.com>
2022-03-04 00:23:26 -07:00
Michael Telatynski
afbe3d16b4
Fix account & room settings race condition (#7953) 2022-03-03 22:09:06 +00:00
Michael Telatynski
7fa01ffb06
Improve typing around event emitter handlers (#7816) 2022-02-22 12:18:08 +00:00
Šimon Brandner
eca64d776a
Remove layout workaround (#7853) 2022-02-21 10:05:01 +00:00
Šimon Brandner
9aa77f3417
Remove autoplayGifsAndVideos workaround (#7852) 2022-02-21 10:02:45 +00:00
Timo
325e2ba99b
Right panel store refactor (#7313)
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
2022-01-05 16:14:44 +01:00
Michael Telatynski
9ed771ad7a
Have LocalEchoWrapper emit updates so the app can react faster (#7358) 2021-12-17 08:53:03 +00:00
Aaron Raimist
7b94e13a84 Merge branch 'develop' into sort-imports
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2021-12-09 08:34:20 +00:00
James Salter
5219b6be80
Analytics opt in for posthog (#6936)
* Add a new flag pseudonymousAnalyticsOptIn replacing analyticsOptIn, stored at account level, so people only need to opt in once.

* Show a toast in login to users that have analyticsOptIn set but not yet pseudonymousAnalyticsOptIn prompting them confirm the new method is okay. Update the copy of the existing opt-in toast. Don't notify users that previously opted out.

* Update the copy in settings

* Add a new learn more dialog

* Support a new config flag analyticsOwner which is used in these toasts when explaining which entity the data is sent to ("Help improve %(analyticsOwner)"). If unset, display brand. This allows deployments whose brand differs from the receiver of the analytics to explain the situation to their users (e.g. AcmeCorp badges their app, but explains the data is sent to Element, not them)

* The new opt-in and flags are only used when posthog is configured; prior to that there are no changes to UX or tracking behaviour.
2021-12-06 09:39:33 +11:00
Travis Ralston
3c06e7f7a0
Add option to change the size of images/videos in the timeline (#7017)
Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com>
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com>
Co-authored-by: Timo K <toger5@hotmail.de>
2021-11-17 15:19:30 +00:00
Aaron Raimist
bdc56be863
Auto fix
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2021-10-22 17:23:37 -05:00
Dariusz Niemczyk
5290afcc4c Replace console.warn with logger.warn
Related https://github.com/vector-im/element-web/issues/18425
2021-10-18 14:08:23 +02:00
Šimon Brandner
9533f7b0b9
Don't setValue() if that would lead to setting a null/undefined
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2021-10-13 19:47:49 +02:00
Šimon Brandner
c246b027be
Add missing space
Co-authored-by: Dariusz Niemczyk <3636685+Palid@users.noreply.github.com>
2021-09-02 17:39:13 +02:00
Šimon Brandner
9b2c380b64
Split autoplay gifs and videos in to different settings
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2021-09-01 17:28:15 +02:00
Šimon Brandner
a8b86da058
Set the new layout setting when reading it
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2021-08-26 18:09:14 +02:00
Michael Telatynski
bd175c6f40 Improve and consolidate typing 2021-07-10 15:43:46 +01:00
J. Ryan Stinnett
782e793925 Merge remote-tracking branch 'origin/develop' into jryans/rework-linting-2 2021-06-29 15:27:24 +01:00
J. Ryan Stinnett
ae0a8b8da4 Auto-fix lint errors 2021-06-29 13:11:58 +01:00
Germain Souquet
6607294573 Deprecate Tinter and TintableSVG 2021-06-28 17:13:23 +01:00
Šimon Brandner
7efbd50e31
Handle migration from useIRCLayout to layout
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2021-01-26 13:30:34 +01:00
J. Ryan Stinnett
cb66f7493b Skip account settings for guest users
Homeservers don't allow this currently, so we should use something else instead
for such cases.
2021-01-14 15:58:27 +00:00
Travis Ralston
71643862c0 Implement new config style for features 2020-08-17 13:24:55 -06:00
Michael Telatynski
cd29edb442 Write more typescript defs 2020-08-05 09:13:01 +01:00
Travis Ralston
bb48ee669b Make SettingsHandler truly abstract 2020-07-30 08:50:36 -06:00
Travis Ralston
648c3c7796 Fix various type definitions 2020-07-30 08:49:42 -06:00
Travis Ralston
ae3eb3da9c Fix MatrixClient access in settings 2020-07-29 11:51:42 -06:00
Travis Ralston
51968a8072 Convert RoomSettingsHandler to TS 2020-07-28 22:16:54 -06:00
Travis Ralston
c7b28b4566 Convert RoomDeviceSettingsHandler to TS 2020-07-28 22:14:33 -06:00
Travis Ralston
c4f4e2aa0a Convert RoomAccountSettingsHandler to TS 2020-07-28 22:04:25 -06:00
Travis Ralston
21e5bccb62 Convert LocalEchoWrapper to TS 2020-07-28 21:57:00 -06:00