Commit graph

42617 commits

Author SHA1 Message Date
Michael Telatynski
d9b7e0721c
Add visual tests using Percy in Cypress ()
* Add basic Percy tests

* Run Percy in CI

* Fix snapshot timing

* Fix bad selector

* Hide another bit of dynamic text

* Add docs
2022-05-17 15:16:14 +00:00
J. Ryan Stinnett
c122c5cd3b
Add basic performance testing via Cypress () 2022-05-17 15:38:45 +01:00
Michael Telatynski
83b3dfa341
Add logs to try debug issue with thread view ()
* Tidy up

* Add logs to try debug issue with thread view
2022-05-17 10:38:24 -04:00
Robin
e099ebd9ec
Fix click behavior of notification badges on spaces ()
* Fix click behavior of notification badges on spaces

* Fix import
2022-05-17 14:28:19 +00:00
Sinharitik589
d717d06ce5
Prevent invites from showing up in breadcrumbs () 2022-05-17 15:08:36 +01:00
Michael Telatynski
5976f59827
Add missing return values in Read Receipt animation code () 2022-05-17 15:08:23 +01:00
Robin
796e12e789
Go to space landing page when clicking on a selected space ()
* Go to space landing page when clicking on a selected space

Signed-off-by: Robin Townsend <robin@robin.town>

* Go to home landing page when clicking on selected home space

Signed-off-by: Robin Townsend <robin@robin.town>

* Remove metaspace behavior

* Add tests

* Use the dispatcher action enum

* Break up the onClick assignment
2022-05-17 13:22:35 +00:00
Michael Telatynski
007b8816df
Tweak ReactionsRow to make saner use of its RoomContext ()
* Tweak ReactionsRow to make saner use of its RoomContext

* `this.context.canReact` already asserts membership=join
2022-05-17 14:17:27 +01:00
Michael Telatynski
de4e0cfcaa
Add extra TimelinePanel logging to debug specific issue () 2022-05-17 14:12:11 +01:00
Travis Ralston
afaeaaf954
Convert setupNotificationListener to an unbound function ()
This isn't called by an event handler directly, so shouldn't need to be bound. Equally, this shouldn't cause any problems.

This is a long-shot attempt at completing https://github.com/vector-im/element-web/issues/22141
2022-05-17 00:21:29 -06:00
Travis Ralston
2bddadc14e
Fix order of object override when copying identity server terms state ()
Fixes https://github.com/vector-im/element-web/issues/20003
2022-05-17 00:20:16 -06:00
Travis Ralston
5f8aecaf08
Use a default for ignoreHover when not supplied ()
It is considered optional by the component props, so let's treat it as optional.
2022-05-16 20:26:19 -04:00
Travis Ralston
12cee6e29f
Add missing key to ReplyInThreadButton as used in MessageActionBar () 2022-05-16 18:09:38 -04:00
Michael Telatynski
4162c21596
Update netlify.yaml () 2022-05-16 21:20:00 +00:00
Robin
a66ffa43c4
Fix copy on video room creation button () 2022-05-16 21:10:44 +00:00
Robin
ceda77d7dc
Proactively fix stuck devices in video rooms ()
* Proactively fix stuck devices in video rooms

* Fix tests

* Explain why we're disabling the lint rule

* Apply code review suggestions

* Back VideoChannelStore's flags by SettingsStore instead of localStorage
2022-05-16 16:54:08 -04:00
Suguru Hirahara
6f851108be
Fix position of the message action bar on left side bubbles ()
* Fix position of the message action bar on data-self=false bubble

- Fix position of the bar on GenericEventListSummary as well
- Override default value `right: 8px` of MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables for MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set the right property to [data-self=true]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove space for "React" and "Reply" buttons inside MessageActionBar on the left side bubble inside ThreadView

This commit removes space reserved for those buttons on deleted or "Unable to decrypt" message bubble inside ThreadView.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-16 15:44:05 +00:00
James Salter
fcc4d62ede
Fall back to untranslated string rather than showing missing translation error () 2022-05-16 13:28:24 +01:00
Šimon Brandner
fb30b67b14
Fix issues with the new topic dialog () 2022-05-16 14:10:00 +02:00
Šimon Brandner
e1d11db256
Don't show public indicator on spaces () 2022-05-16 10:24:01 +02:00
Kerry
42f12485bc
fix ts issues in Registration-test ()
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-05-16 08:23:51 +00:00
Michael Telatynski
8ae9f7d79a
Fix edge case thread summaries around events without a msgtype ()
* Fix edge case thread summaries around events without a msgtype

* Remove incomprehensible comment
2022-05-16 08:11:50 +00:00
Šimon Brandner
fc2d7b67d1
Don't show image metadata banner in replies () 2022-05-16 09:47:21 +02:00
Šimon Brandner
b54c7d8faf
Fix not being able to open avatars in lightbox () 2022-05-14 16:07:54 +00:00
Suguru Hirahara
eb10c3647b
Remove an obsolete declaration for DisambiguatedProfile of EventTile on modern layout () 2022-05-14 15:11:01 +02:00
Šimon Brandner
4c1c12bbc4
Fix favourites metaspace not updating () 2022-05-14 11:45:15 +00:00
Šimon Brandner
11eca18450
Stop spaces from displaying as rooms in new breadcrumbs () 2022-05-14 13:41:17 +02:00
Šimon Brandner
e0d94f6338
Add right margin to pills () 2022-05-14 13:41:05 +02:00
Suguru Hirahara
9b9ecf9c55
Fix avatar position of hidden event on ThreadView () 2022-05-14 11:34:27 +02:00
Travis Ralston
f51a6b6da4
Show file name and size on images on hover ()
* Show simple file name and size on images/videos

Fixes https://github.com/vector-im/element-web/issues/18197

* i18n

* Fix bad merge

* Add hover state tracking

* Only show on timeline-like objects

* Match new design requirements

* Remove video support (deemed not needed)

* Colouring and sizing from design

* Include file name in lightbox

* Revert changes to videos since we don't need them

* i18n

* Iterate PR

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-14 10:31:53 +02:00
Suguru Hirahara
f54d54b3ff
Fix MessageTimestamp position next to redacted messages on IRC/modern layout () 2022-05-14 09:55:52 +02:00
Michael Telatynski
e6ec01fe86
Use reusable SonarCloud workflow ()
* Use reusable SonarCloud workflow

* Simplify Netlify run too

* We don't need dbl quotes

* Remove stale if check
2022-05-13 22:25:50 +00:00
Michael Telatynski
caf2827f93
Merge branch 'develop' into develop 2022-05-13 21:01:09 +01:00
Michael Telatynski
6453530993
Fix js-sdk types () 2022-05-13 19:13:21 +00:00
Suguru Hirahara
1fc8009109
Fix padding of messages in threads ()
* Apply the padding setting of EventTile_line of ThreadView to TimelineCard

Set 2px padding-top and padding-bottom property to EventTile_line on IRC/modern layout of TimelineCard.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

f

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move position property of mx_EventTile_e2eIcon from ThreadPanel to TimelineCard

The E2E icon is available only on TimelineCard.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-13 12:04:27 -06:00
Michael Telatynski
b331099525
Make pull_request.yaml between the layers consistent and fix enforce labels () 2022-05-13 18:51:25 +01:00
Šimon Brandner
170b41f43b
Center initial letter in pills () 2022-05-13 19:51:11 +02:00
Suguru Hirahara
c6cb00bf0c
Enable overflow of hidden events content () 2022-05-13 17:01:21 +00:00
Robin
46bdccea9d
Increase composer line height to avoid cutting off emoji () 2022-05-13 11:31:27 -04:00
Travis Ralston
bc0bfa6377
Iterate on search results for message bubbles ()
* PSFD-455: Iterate on search results for message bubbles

Though not perfect, this is a bit better than it was before. Specifically, we ensure our matching for `isOwnEvent` correctly identifies the user and that the results don't look *awful*. 

There's still room for improvement, but this should be a measurable improvement itself. Most notably, this doesn't fix a couple obvious bugs due to complexity:
* Message bubbles have the wrong corners for the display format (pre-existing).
* The sender's own messages are missing avatars/names. This is just way too complex to fix.

**Requires https://github.com/matrix-org/matrix-js-sdk/pull/2004**

* Tweak opacity

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-13 15:20:43 +00:00
Janne Mareike Koschinski
6d6cfcde11
registration: redesign email verification page () 2022-05-13 14:10:22 +00:00
Michael Telatynski
438e66bb3f
Show full thread message in hover title on thread summary () 2022-05-13 14:32:28 +01:00
Robin
26bc3ab0aa
Tweak video rooms copy ()
* "Video room" → "New video room"

* "Connect now" → "Join"

* "N people connected" → "N people joined"

* "Connected" → "Joined"

* Fix tests
2022-05-13 12:45:38 +00:00
Michael Telatynski
59b9d1e818
Don't consider threads for breaking continuation until actually created ()
* Don't consider threads for breaking continuation until they've actually been created

* Update tests

* Make hasThreadSummary null thread safe

* Apply feedback from pr review
2022-05-13 11:59:50 +00:00
Kerry
fbbb9c27ba
Live location share - beacon tooltip in maximised view () PSF-926
* pass optional tooltip prop down through markers

Signed-off-by: Kerry Archibald <kerrya@element.io>

* add beaconstatustooltip, handle overflow on beacon status label

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove debug, fix mouseout

Signed-off-by: Kerry Archibald <kerrya@element.io>

* tidy comments

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-05-13 08:30:53 +00:00
Germain
fdd5494402
Add dialog to navigate long room topics () 2022-05-13 08:55:10 +01:00
Kerry
e0415d0123
remove unused map util fn () 2022-05-12 17:50:13 +02:00
Janne Mareike Koschinski
d87cfae0c9
Change spaceroomfacepile tooltip if memberlist is shown () 2022-05-12 15:47:19 +02:00
Suguru Hirahara
997d8ab8b3
Fix button width and align 絵文字 (emoji) on the user panel ()
* Fix button width and align 絵文字 (emoji) on the user panel

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* mx_UserInfo_container:not(.mx_UserInfo_separator)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move the spinner to the center

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Add indent to 'Unable to load session list' paragraph

Because the indent style has been specified with ':not(h3)', wrapping
with something is required for the indent.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Align the spinner to the center

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove margin of paragraph inside div on verification panel

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-12 14:21:22 +01:00
Michael Weimann
7ed3089434 Improve tooltip positioning
Signed-off-by: Michael Weimann <michaelw@matrix.org>
2022-05-12 14:05:55 +02:00