Commit graph

331 commits

Author SHA1 Message Date
Michael Telatynski
d5db131eef
Spike AXE A11Y testing in Cypress (#9111)
* Spike AXE A11Y testing in Cypress

* Fix NewRoomIntro breaking html/aria list rules

* Fix HeaderButtons breaking aria role semantics rules

* missing type

* Switch left panel from aside to nav and include space panel

* Give the page a main heading of the room name when viewing a room

* Use header landmark on RoomHeader

* Improve aria attributes on composer when autocomplete is closed

* Fix aria-owns on RoomHeader

* Give Spinner an aria role

* Give server picker help button an aria label

* Improve auth aria attributes and semantics

* Improve heading semantics in use case selection screen

* Fix autocomplete attribute to be valid

* Fix heading semantics on login page

* Improve Cypress axe testing

* Add axe tests

* Stop synapse after the timeline tests

* Await spinners to fade before percy snapshotting timeline tests

* Improve naming of plugin

* Update snapshots

* Fix accidental heading change

* Fix double synapse stoppage

* Fix Cypress timeline avatar assertions to be DPI agnostic

* Fix aria attributes on date separators

* delint

* Update snapshots

* Revert style change

* Skip redundant call
2022-08-01 08:31:14 +01:00
Germain
72c24af5c0
Disallow invalid inline style comments in stylesheets (#9099) 2022-07-27 14:39:29 +01:00
Kerry
594439222d
Replace mask-images with svg components in MessageActionBar (#9088)
* Use svg components in messageactionbar

* highlight options button in pinned messages mock buttons
2022-07-25 12:43:41 +02:00
Suguru Hirahara
38a913488f
Improve clickability of view source event toggle button (#9068)
* Improve clickability of view source event toggle button

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix compression

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Make it easy to select subsequent events

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-18 09:41:01 +02:00
Suguru Hirahara
161a333a51
Improve clickability of "collapse" link button on bubble layout (#9037) 2022-07-16 09:31:29 +00:00
yaya-usman
017f489be6 nits fixes 2022-07-15 22:55:11 +03:00
Michael Telatynski
01f4bb8c78
Rename PostCSS files to .pcss (#9013)
* Rename PostCSS files to `.pcss`

* Make Stylelint happy

* Delint

* Rename new files too

* delint

* Fix bad comment placement
2022-07-15 14:53:23 +01:00
Suguru Hirahara
b1f8d36a69
Re-add margin to tiles based on EventTileBubble (#9015)
* Re-add margin to HistoryTile, which is based on EventTileBubble

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Readd margin to the other tiles based on EventTileBubble

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Default margin is not required for mx_MJitsiWidgetEvent as it appears inside EventTile

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Cancel left value for cryptoEvent on IRC layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-08 09:58:49 +01:00
Suguru Hirahara
b1fb609ab3
Specify spacing around EventTileBubble for each layout (#9001)
* Apply margin to EventTileBubble on each layout

Use a variable to ensure alignment of EventTileBubble on IRC layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Improve style rules

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply the same block margin to every layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-07-07 09:24:24 +00:00
Suguru Hirahara
78a98415eb
Set common width, white-space, and display values to MessageTimestamp (#8818)
* Add mx_MessageTimestamp to mx_PinnedEventTile_timestamp

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply display: block globally to enable the width declaration

- Unset display and width value of timestamp on pinned messages card

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply nowrap globally

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* MessageTimestamp on ThreadsList - Remove width setting and add font-size setting

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant font-size declaration from Threadview

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix timestamp position of timestamp on ThreadView in IRC layout

- GroupLayout is modern layout, not IRC layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant font-size declaration from IRC layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant color setting from timestamp on file panel

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Cancel the default width to set a gap between the event tile line

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply user-select: none globally

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-30 13:37:43 +02:00
Suguru Hirahara
731776d189
Improve link buttons and inline link buttons styling (#8238)
* Set padding: 0 to both "link" and "link_inline"

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant settings - _SpotlightDialog.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant settings - JoinRuleSettings

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant settings - _ViewSourceEvent.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant settings - _RoomDirectory.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant settings - _InviteDialog.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant settings - ServerOfflineDialog

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant settings - UpdateCheckButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant settings - NonUrgentEchoFailureToast

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant settings - CallView

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove unused styles - _RoomSettingsDialogBridges.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Replace "link" with "link_inline" for inline links

- src/components/structures/UserMenu.tsx
- src/components/views/dialogs/BetaFeedbackDialog.tsx
- src/components/views/dialogs/FeedbackDialog.tsx
- src/components/views/rooms/NewRoomIntro.tsx
- src/components/views/settings/tabs/room/NotificationSettingsTab.tsx
- src/components/views/settings/tabs/user/PreferencesUserSettingsTab.tsx
- src/components/views/spaces/SpaceCreateMenu.tsx

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Replace "link_inline" with "link" for links not inline

- src/async-components/views/dialogs/security/CreateKeyBackupDialog.tsx
- src/async-components/views/dialogs/security/CreateSecretStorageDialog.tsx
- src/components/structures/auth/ForgotPassword.tsx
- src/components/structures/auth/Registration.tsx
- src/components/views/auth/InteractiveAuthEntryComponents.tsx
- src/components/views/dialogs/security/AccessSecretStorageDialog.tsx
- src/components/views/dialogs/security/RestoreKeyBackupDialog.tsx
- src/components/views/messages/TileErrorBoundary.tsx
- src/components/views/messages/ViewSourceEvent.tsx

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a redundant declaration - _SetupEncryptionBody.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a redundant declaration - _ReplyChain.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a redundant declaration - _EventTile.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove an obsolete style block - _RoomPreviewCard.scss

The block was transferred from _SpaceRoomView.scss with ec24dc661edb6979ba901936067e5bc731dafa59

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a redundant declaration - _SecurityUserSettingsTab.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove element='span' - NewRoomIntro.tsx

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant declarations - _ServerPicker.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Replace 'link' with 'link_inline' - AnalyticsToast.tsx

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-29 22:37:34 +00:00
Michael Weimann
9cf03a8d32
Disable pointer events for replies to locations (#8918)
PSD-283
2022-06-28 09:34:48 +02:00
Robin
5c67ef14ec
Don't overlap tile bubbles with timestamps in modern layout (#8908)
* Don't overlap tile bubbles with timestamps in modern layout

* Use timestamp width variable
2022-06-27 17:40:46 +00:00
Suguru Hirahara
43f2ee4283
Fix reactions row overflow and gap between reactions (#8813) 2022-06-16 17:47:37 +00:00
Suguru Hirahara
3b28b1100f
Include mx_MessageActionBar_maskButton in mx_MessageActionBar (#8792)
* Include mx_MessageActionBar_maskButton in mx_MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-16 14:34:56 +01:00
Suguru Hirahara
1b7e9d95da
Fix flex blowout on image reply (#8809)
* Set min-width to prevent a flex blowout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use a native spacing property

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set max-width: 100% to display name inside the image reply

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-10 12:36:17 +01:00
Suguru Hirahara
c304e3da51
Fix the incorrect nesting of MessageActionBar (#8785)
mx_MessageActionBar_downloadSpinnerButton::after

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-08 13:16:24 +02:00
Suguru Hirahara
36f2f3e2ce
Use MessageActionBar style declarations on pinned message card (#8757)
* Refer mx_MessageActionBar on pinned messages card

Normalize mx_MessageActionBar style rules

- Allow the varaible (--MessageActionBar-size-button) to be used
- Remove redundant declarations

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables for normalization

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set class name

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Readd the comment

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use Heading size='h4'

- Use size='h4' instead of 'h2' as 15px has been specified as the font-size of the header
- Use logical values following _Heading.scss
- Remove line-height declaration in favor of the default value

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-08 12:52:25 +02:00
Suguru Hirahara
c016815562
Normalize the name of buttons on MessageActionBar (#8781)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-08 10:53:58 +01:00
Suguru Hirahara
66daaf0748
Force style rules of buttons on MessageActionBar used with maskButton selector (#8780)
* Include mx_MessageActionBar_maskButton::after in mx_MessageActionBar_maskButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_MessageActionBar_maskButton:hover::after in mx_MessageActionBar_maskButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Ensure buttons on message action bar used only with mx_MessageActionBar_maskButton as expected

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_Indicator in mx_MessageActionBar_threadButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_MessageActionBar_downloadButton.mx_MessageActionBar_downloadSpinnerButton in mx_MessageActionBar_downloadButton

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-08 11:08:49 +02:00
Suguru Hirahara
dc1f53b6e9
Prevent the banner text from being selected, replacing the spacing values with the variable (#8756) 2022-06-05 08:30:29 +02:00
Robin
4b957b57af
Squish event bubble tiles less (#8740) 2022-06-02 09:10:41 -04:00
Robin
f47121ece7
Revert "Fix wide image overflowing from the thumbnail container (#8663)" (#8709)
This reverts commit 5082d67dc1.
2022-05-27 17:18:44 +00:00
Suguru Hirahara
5446d5d6ba
Fix position of wide images on IRC / modern layout (#8667)
* Move declarations related to position from _MImageBody.scss to _EventTile.scss

These declarations should not be defined as default values as position depends on other factors such as layout, etc.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move min-height and min-width declarations from _MImageBody.scss to _EventTile.scss

Since min-height and min-width have been specified for bubble layout, the declarations have been expected to be applied to the other layouts.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply 'justify-content: center' to bubble layout only

'justify-content: center' was added for the bubble layout with 1436f23. It should not be applied to the other layouts.

In order to prevent an issue related to cascading from happening, 'justify-content: flex-start' is explicitly specified.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 09:02:13 +02:00
Suguru Hirahara
11cb48176e
Fix other user's displayName being wrapped on the bubble message layout (#8456) 2022-05-22 09:07:29 +02:00
Suguru Hirahara
5082d67dc1
Fix wide image overflowing from the thumbnail container (#8663) 2022-05-21 14:42:55 +00:00
Suguru Hirahara
e1e87ac019
Fix styles of "Show all" link button on ReactionsRow (#8658) 2022-05-21 11:38:50 +02:00
Michael Telatynski
ce73b9988e
Hide image banner on stickers, they have a tooltip already (#8641) 2022-05-18 10:08:33 +01:00
Suguru Hirahara
6f851108be
Fix position of the message action bar on left side bubbles (#8398)
* Fix position of the message action bar on data-self=false bubble

- Fix position of the bar on GenericEventListSummary as well
- Override default value `right: 8px` of MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables for MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set the right property to [data-self=true]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove space for "React" and "Reply" buttons inside MessageActionBar on the left side bubble inside ThreadView

This commit removes space reserved for those buttons on deleted or "Unable to decrypt" message bubble inside ThreadView.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-16 15:44:05 +00:00
Šimon Brandner
fc2d7b67d1
Don't show image metadata banner in replies (#8606) 2022-05-16 09:47:21 +02:00
Travis Ralston
f51a6b6da4
Show file name and size on images on hover (#6511)
* Show simple file name and size on images/videos

Fixes https://github.com/vector-im/element-web/issues/18197

* i18n

* Fix bad merge

* Add hover state tracking

* Only show on timeline-like objects

* Match new design requirements

* Remove video support (deemed not needed)

* Colouring and sizing from design

* Include file name in lightbox

* Revert changes to videos since we don't need them

* i18n

* Iterate PR

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-14 10:31:53 +02:00
Suguru Hirahara
f54d54b3ff
Fix MessageTimestamp position next to redacted messages on IRC/modern layout (#8591) 2022-05-14 09:55:52 +02:00
Suguru Hirahara
c6cb00bf0c
Enable overflow of hidden events content (#8585) 2022-05-13 17:01:21 +00:00
Šimon Brandner
7d1ecfdcbc
Make date changes more obvious (#6410)
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-05-09 14:23:51 +01:00
Suguru Hirahara
50a714de4a
Add margin-top to the location body which is a sibling of DisambiguatedProfile (#8523)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-09 06:33:34 +00:00
Suguru Hirahara
c86040b77a
Fix timestamp's position on the chat panel with a maximized widget in IRC layout (#8464)
Fix avatar's position on the chat panel with a maximized widget in IRC layout
Fix timestamp's position on Message Edits history modal window

Also:
- Align DisambiguatedProfile with reactions row and thread summary with a variable
- Add width property as default
- Use the global variable on _IRCLayout.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-07 03:07:51 +00:00
Suguru Hirahara
34471ba855
Fix unexpected and inconsistent inheritance of line-height property for mx_TextualEvent (#8485)
- IRC layout: unspecified
- Modern layout: $font-22px (with _GroupLayout.scss)
- Bubble layout: $font-18px (with _EventBubbleTile.scss)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-07 03:07:11 +00:00
Suguru Hirahara
3a6ddf3a2b
Set max-width for MLocationBody and MLocationBody_map by default (#8519)
To avoid map overflow due to width and height specified by maplibregl-canvas

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-06 18:24:42 +00:00
agrani29
995d008aca
fixed avatar and message box layering (#8190)
Co-authored-by: Andy Balaam <andyb@element.io>
2022-05-04 14:35:04 +00:00
Alexander
2c08063925
Add pointer if you hover over location map (#8451) 2022-04-30 16:15:20 +01:00
Michael Telatynski
f85e178fc1
Fix centering issue with sticker placeholder (#8404) 2022-04-25 17:36:32 +00:00
Suguru Hirahara
af3eac2c4f
Fixes call tiles overflow (#8096)
* Responsive call tiles

Fixes https://github.com/vector-im/element-web/issues/20254

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Take e2e icon into consideration on Bubble message layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use spacing variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* spacing variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-04-14 14:27:29 -06:00
Janne Mareike Koschinski
1436f23e2f
Fix image preview sizing for edge cases (#8322) 2022-04-14 20:07:34 +02:00
Kerry
b98739056e
Live location sharing - extract location markers into generic Marker (#8225)
* extract location markers into generic Marker

Signed-off-by: Kerry Archibald <kerrya@element.io>

* comments

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove skinned

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-04-06 12:40:39 +01:00
Germain
694c39e72d
Enable threads by default and mark it as a beta feature (#8081) 2022-04-05 17:15:31 +01:00
Suguru Hirahara
631fd87509
Normalize call buttons (#8129)
- Set a mixin to use it on call events and toasts

Fixes https://github.com/vector-im/element-web/issues/21493

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-04-04 00:34:39 -06:00
Robin
af6bd63ac7
Fix some image/video scroll jumps (#8182)
* Fix some image/video scroll jumps

* Fix aspect ratio formatting

* Fix videos not being responsive to timeline width
2022-03-28 19:07:02 +00:00
Šimon Brandner
bda18f8bc9
Fix disambiguated profile in threads in bubble layout (#8168) 2022-03-28 08:59:06 +01:00
Robin
953e3148d1
Make video sizing consistent with images (#8102)
* Make video sizing consistent with images

* Test suggestedSize

* Constrain width of media in large mode
2022-03-22 18:16:03 -04:00
Šimon Brandner
bff1ef31d6
Use styled mxids in member list v2 (#8110)
* Revert "Revert "Use styled mxids in member list (#6328)" (#8107)"

This reverts commit 709e6e78d2.

* Fix disambiguated profile for bubbles

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-03-22 16:14:55 -06:00