* Install knapsack pro
* Use knapsack pro command
* Lint
* Use chrome
* Add test file pattern
* Use two different tokens for knapsack
* Use the correct secret
* Update lockfile
* Fix conflict
* Remove redundant options
* Add explaining comment
* Remove outdated variables and steps
* Update comment
* Fix conflict
* Use the chrome we setup earlier
* Add back percy config
* Set knapsack pro branch
* Use github_env to get browser path
* Add badge to readme
* Update .github/workflows/cypress.yaml
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* Apply prettier
---------
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* Disable Percy
While visual regression testing is without doubt an essential part of
quality assurance, the way we're currently using Percy brings little
to no value while causing mainenance overhead. Therefore, we're disabling it
until we have figure out https://github.com/vector-im/wat-internal/issues/36
and https://github.com/vector-im/wat-internal/issues/56.
* Also disable nightly build
* Comment out Percy step instead of fiddling with the output value
* Appease the frigging linter
* Use cypress-terminal-report
This cypress plugin gives nice console logs about what is happening: I hope it
will help us debug mysteriously failing tests.
In its default config, it only logs for failing tests.
* another anti-morgan hack
* Disable collection of `console.debug`
* `ctr:info` is not real
* Remove STIXGeneral from the font stack
STIXGeneral was originally added to our font stack to work around a bug in Chrome (https://bugs.chromium.org/p/chromium/issues/detail?id=591346) which caused some obscure combining marks to render as tofu. However, because STIXGeneral unexpectedly has glyphs for a handful of common Japanese characters, it's ended up making Japanese text in Element look patchy. I previously attempted to fix this by prioritizing sans-serif over STIXGeneral, but as is evident from our screenshot tests and user reports, this is still not enough on some systems to get Chrome to pick a consistent font for Japanese. On the basis that i18n is more important than supporting a few mathematical diacritics, I propose we remove the font. STIXGeneral is deprecated anyways, so if we want to get these diacritics back there's always the option of looking at its successor, STIXTwo.
* Remove STIXGeneral installation from Cypress workflow
* GHA: make `element-web` workflow reusable
... so that we can call it from the js-sdk repo
* GHA: make `cypress.yaml` a reusable workflow
... so that we can call it from js-sdk
* GHA: give cypress.yaml a `rust-crypto` parameter
* Update .github/workflows/cypress.yaml
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
* remove workflow_dispatch
---------
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
