Commit graph

22 commits

Author SHA1 Message Date
R Midhun Suresh
cf8b87fd14
Add tabs to the right panel ()
* Create new method for header button behaviour

With the introduction of tabs, the behaviour of the header buttons is
changed as follows:
- Close any right panel if open
- Open the correct right panel if no panel was open before

The old method (and behaviour) is retained as showOrHidePhase.

* Implement tabs in the right panel

There are three tabs: Info, People and Threads

* Remove unwanted code from RoomSummaryCard

- Remove the menu item for opening the memberlist since that is now
  taken of by the tabs.
- Remove the close button

* Remove code for focusing close button from tac item

See https://github.com/matrix-org/matrix-react-sdk/pull/12410

There's no longer a close button to focus so we instead focus the thread
tab. This is done in RightPaneltabs.tsx so we just need to remove this
code.

* Introduce a room info icon to the header

This was previously present in the legacy room header but not in the new
header.

* BaseCard changes

- Adds id, ariaLabelledBy and role props to implement tab accessibility.
- Adds hideHeaderButtons prop to hide header buttons (think back and
  close buttons).
- Change confusing header rendering code:
  header is not rendered ONLY when no header is passed AND
  hideHeaderButtons is true.

* Refactor repeated code into function

Created a new function createSpaceScopeHeader which returns the
component if the room is a space room. Previously this code was
duplicated in every component that uses SpaceScopeHeader component.

* Pass BaseCard attributes and use helper function

Actually using the code from the last two commits

* Add, update and remove tests/screenshots/snapshots

* Fix distance between search bar and tabs

* Update compound

* Update screenshots/snapshots
2024-07-09 11:36:50 +00:00
Richard van der Hoff
efd309f5f9
Disable playwright tests for legacy crypto ()
* Disable "legacy crypto" playwright project

* playwight: Remove crypto stack conditions

We only ever run under the rust stack now, so these conditions are
redundant.

* playwright: remove `cryptoBackend` test option

* playwright: remove redundant `projects`

We don't need this any more

* playwright: remove redundant `TestOptions`
2024-06-24 10:30:59 +00:00
David Baker
281916fd96
Take the Threads Activity Centre out of labs ()
* Take the TAC out of labs!

Requires https://github.com/matrix-org/matrix-react-sdk/pull/12438
and ideally https://github.com/matrix-org/matrix-react-sdk/pull/12418

* i18n

* Add test method

That's needed now we we don't include threads in the notif count in the tests

* One less labs setting

* Update snapshot

* Disable release announcement

* Unused import

* Fix some screenshots

* Fix all the unread test cases now room unreads don't include threads

* Fix more tests

* Even more test fixes

* Still more test fixes

* Oh goodness, it's more test fixes

* Fix selectors now there are 2 buttons called Threads

* Disable some tests that aren't passing

for reasons that don't appear releated to any of the TAC work, as
per the comment.

* Remove debugging

* Oops, removed too much
2024-04-29 15:30:19 +00:00
Florian Duros
700b3955a4
Add Tooltip to AccessibleButton ()
* Deprecate AccessibleTooltipButton

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Deprecate AccessibleTooltipButton

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix tests

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Fix `UserInfo-test.tsx`

* Update `LoginWithQRFlow-test.tsx` snapshot

* Remove tooltip provider from test

* Fix `AccessibleButton`

* Update snapshots

* Revert to original import

* Use title to populate aria-label

* Rollback AccessibleButton or Tooltip changes. Will come in another PR

* Rollback en.json change

* Update snapshots

* Fix `UserInfo`

* Update snapshots

* Use label instead of title in test

* Use label instead of title in TAC test

* Use label instead of title in read-receipt test

* Remove tooltip for ContextMenu

* Add extra information for caption field

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2024-04-24 12:24:25 +00:00
Richard van der Hoff
ca5ab09f3b
Disable failing playwright test ()
This is the first test in the file, so it's possible that the failure will move
to the next test. But let's give it a try.
2024-01-24 09:54:14 +00:00
renovate[bot]
a0c8575113
Update dependency prettier to v3 ()
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2024-01-02 18:56:39 +00:00
Florian Duros
f6fc91196f
Add tests about room list order () 2023-12-29 10:06:51 +00:00
Florian Duros
16c89c21b1
Enable A thread with a redacted unread is still read after restart () 2023-12-21 16:57:22 +00:00
Florian Duros
537b4a1971
Playwright: Fix thread root skipped tests ()
* Fix thread root skipped tests

* Add comment about collapsed content in `redactions.spec.ts`

---------

Co-authored-by: David Baker <dbkr@users.noreply.github.com>
2023-12-19 09:59:05 +00:00
David Baker
24cda5fc59
Fix threaded reply playwright tests ()
It appears the bug with these tests was just that the MessageBuilder
wasn't setting the thread relation on the reply messages as this didn't
happen trying to repro it manually, so fix the builder and re-enable
the tests.

The flip side of this is that it implies buggy clients that don't
set thread relations properly will cause stuck notifs in Element Web.
I've filed this as https://github.com/element-hq/element-web/issues/26787
2023-12-18 21:05:06 +00:00
Florian Duros
a806d71d45
Remove skipped for rust crypto in high-level.spec.ts () 2023-12-12 13:23:25 +00:00
Florian Duros
2002f3f627
Fix more tests in redactions.spec.ts () 2023-12-12 12:38:13 +00:00
Florian Duros
0f42418b5c
Enable skipped tests in redactions.spec.ts () 2023-12-11 14:53:00 +00:00
Florian Duros
f9b50938de
Enable skipped tests in high-level.spec.ts () 2023-12-11 10:11:26 +00:00
Florian Duros
75500b606e
Enable skipped tests in reactions.spec.ts () 2023-12-08 16:07:25 +00:00
Florian Duros
d15065d05c
Enable & fix skipped tests in new-messages.spec.ts () 2023-12-08 12:38:39 +00:00
Florian Duros
845838b67f
Fix assertUnreadLessThan and assertUnreadGreaterThan () 2023-12-07 16:38:36 +00:00
Florian Duros
d6d3585c30
Playwright: Enable more tests in editing-messages.spec.ts ()
* Enable skipped test in `editing-messages.spec.ts`

* Enable 2 more tests in `editing-messages.spec.ts`

* Fix `A room where all threaded edits are read is still read after restart` integ test

* Fix `A room where all threaded edits are read is still read after restart` integ test

* WIP fix `A room where all threaded edits are read is still read after restart `

* WIP fix `A room where all threaded edits are read is still read after restart `
2023-12-07 10:29:25 +00:00
Florian Duros
1ce569bfc2
Fix A room with an edit is still read after restart integ test () 2023-12-06 16:59:10 +00:00
Florian Duros
36c6afd53f
Enable skipped test in editing-messages.spec.ts () 2023-12-06 09:50:37 +00:00
Michael Telatynski
99b580d501
Migrate read-receipts.spec.ts from Cypress to Playwright ()
* Migrate read-receipts.spec.ts from Cypress to Playwright

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update client.ts

* Serialise test message sending

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2023-12-05 13:24:10 +00:00
Michael Telatynski
b691be3bee
Migrate most read-receipts tests from Cypress to Playwright ()
* Migrate most read-receipts tests from Cypress to Playwright

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Disable failing test

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Iterate

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2023-12-05 10:37:23 +00:00