PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 3
26304 commits 1 branch 0 tags 338 MiB
Commit graph

26304 commits

This branch
This branch
All branches
Author SHA1 Message Date
Travis Ralston
dd833f4f2f Ensure the sticky room changes if the tag changes 
This fixes a case where a user accepts an invite, which causes a tag change, but the room stays stuck in the invites list. The tag change additionally gets swallowed when the user moves away, causing the room to get lost. 

By moving it when we see it, potentially during a sticky room change itself (though extremely rare), we avoid having the room get lost in the wrong lists. A side effect of this is that accepting an invite puts it at the top of the tag it's going to (usually untagged), however this feels like the best option for the user.

A rare case of a tag change happening during a sticky room change is when a leave event comes in for the sticky room, but because it's come through as a tag change it can get swallowed. If it does get swallowed and the user clicks away, the tag change will happen when the room is re-introduced to the list (fake NewRoom event).
 2020-07-06 19:38:13 -06:00
Travis Ralston
4345f972e0 Handle sticky room to avoid accidental removal 
Plus a bunch of logging.

This fixes a case where switching rooms would cause the last room you were on to disappear due to an optimization where known NewRoom fires would be translated to tag change fires, which wouldn't re-add the room to the underlying tag algorithm.

By tracking the last sticky room, we can identify when we're about to do this and avoid it. 

This commit also adds a check to ensure that we have the latest reference of a room stored as rooms changing from invite -> join change references.

This commit additionally updates the PossibleTagChange handling to be faster and smarter, leading to a more stable generation of the room list. We convert the update cause to a Timeline update in order to indicate it is a change within the same tag rather than having to jump tags. This also means that PossibleTagChange should no longer make it as far as the underlying algorithm.

New logging has also been added to aid debugging.
 2020-07-06 19:38:13 -06:00
Travis Ralston
18df29b627 Flag & add some debugging 2020-07-06 19:38:13 -06:00
Travis Ralston
0b6f744a58 Wrap handleRoomUpdate in a lock 
Dev note: this is removed in a later commit
 2020-07-06 19:38:13 -06:00
Michael Telatynski
64237c9f4e Apply scroll margins to RoomTile so that they don't scroll under the "sticky" headers 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-07 00:11:32 +01:00
Michael Telatynski
6bc39547c7 Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into t3chguy/room-list/12345 2020-07-07 00:10:06 +01:00
Jorik Schellekens
5176685d20 Implement incoming call box 2020-07-06 23:05:00 +01:00
Travis Ralston
d14dd777b7 Revert "don't need to set width with javascript?" 
This reverts commit a2cf641c0e.
 2020-07-06 15:23:20 -06:00
Travis Ralston
70eebc978f Revert "Minor cleanup of sticky header CSS" 
This reverts commit 5bf14d8427.
 2020-07-06 15:22:40 -06:00
Michael Telatynski
3094bb32ec
Merge pull request #4901 from matrix-org/t3chguy/room-list/112 
Fix some room list sticky header instabilities
 2020-07-06 22:21:02 +01:00
Michael Telatynski
abfbcf4090 use uglier style for props but be consistent :'( 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 22:04:30 +01:00
Michael Telatynski
f038dd52e6
Merge pull request #4903 from matrix-org/t3chguy/room-list/14353 
null-guard against groups with a null name in new Room List
 2020-07-06 22:01:41 +01:00
Michael Telatynski
60225154e6 delint 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 21:58:44 +01:00
Michael Telatynski
97d4295bf5
Merge pull request #4902 from matrix-org/t3chguy/room-list/14306 
Allow vertical scrolling on the new room list breadcrumbs
 2020-07-06 21:53:54 +01:00
Michael Telatynski
f6aa6208ee null-guard against groups with a null name :(( 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 21:53:20 +01:00
Travis Ralston
5bf14d8427 Minor cleanup of sticky header CSS 2020-07-06 14:37:38 -06:00
Bruno Windels
7647072b05 remove prop instead of assigning unset 2020-07-06 14:36:07 -06:00
Bruno Windels
201f6ebe83 make stick headers jump in a bit later so the transition is less jumpy 2020-07-06 14:36:01 -06:00
Bruno Windels
a2cf641c0e don't need to set width with javascript? 2020-07-06 14:35:53 -06:00
Bruno Windels
61a5807fd1 only show topmost top sticky header 2020-07-06 14:35:46 -06:00
Michael Telatynski
c9bc318ca7 Allow vertical scrolling on the new room list breadcrumbs 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 21:32:46 +01:00
Michael Telatynski
8233dec72e Fix some room list sticky header instabilities 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 21:05:06 +01:00
Michael Telatynski
2c1eb07768
Merge pull request #4883 from matrix-org/t3chguy/ts123 
Convert things to Typescript, including languageHandler
 2020-07-06 18:54:19 +01:00
Michael Telatynski
18064c19a3 add TODO 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 18:13:11 +01:00
Michael Telatynski
8acec1f417 delint 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 17:58:39 +01:00
Michael Telatynski
1849ed90d2 Implement ViewRoomDelta for the new Room List 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 17:58:29 +01:00
Michael Telatynski
2da1320d99 Type view_room_delta as ViewRoomDelta 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 17:57:40 +01:00
Michael Telatynski
6042e015e0 Remove unused dispatches view_indexed_room and view_prev_room 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 17:49:37 +01:00
Michael Telatynski
66ca095706 Fix double handling of native inputs wrapped for aria menus 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 10:41:35 +01:00
Michael Telatynski
823ada374d delint 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 10:30:06 +01:00
Michael Telatynski
6cb0ac6a50 Fix checkboxes/radios in context menus should only close on ENTER, not SPACE 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 10:18:49 +01:00
Michael Telatynski
d366ca12a0 i18n 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 01:19:00 +01:00
Michael Telatynski
87a7a8a02b Add TODOs 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 01:15:53 +01:00
Michael Telatynski
b7c23b690c Include more classes for room list keyboard navigation 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 01:14:02 +01:00
Michael Telatynski
2d09ac9f88 Improve UserMenu label 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-06 01:01:40 +01:00
Michael Telatynski
7c29a53ebd aria-hide the notifications badge on room tiles as we have manual labels here 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-05 19:59:29 +01:00
Michael Telatynski
a68e23c9e0 Make message previews accessible via describedby 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-05 19:38:45 +01:00
Michael Telatynski
3cebfc8072 Fix StyledMenuItemCheckbox and StyledMenuItemRadio 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-05 19:31:24 +01:00
Michael Telatynski
069cdf3ce0 Fix room list v2 context menus to be aria menus 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-05 18:23:57 +01:00
Michael Telatynski
83cfdd9c07 Fix accessibility of the Explore button 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-05 01:30:22 +01:00
Michael Telatynski
4f1cd82b66 i18n 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-05 01:24:22 +01:00
Michael Telatynski
1620feb55e Sprinkle in some better ARIA props 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-05 01:07:46 +01:00
Michael Telatynski
4c7014167d Improve a11y of default BaseAvatar 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-05 01:06:36 +01:00
Travis Ralston
d98ba9b577
Merge pull request #4894 from matrix-org/travis/room-list/badge-fixes 
Fix minor issues with the badges in the new room list
 2020-07-03 15:09:15 -06:00
Travis Ralston
afa71c7b7c Fix minor issues with the badges in the new room list 
Fixes https://github.com/vector-im/riot-web/issues/14225
 2020-07-03 14:26:59 -06:00
Michael Telatynski
ae5ab4c394
Merge pull request #4893 from matrix-org/t3chguy/room-list/101 
Radio button outline fixes including for new room list context menu
 2020-07-03 20:35:17 +01:00
Michael Telatynski
599cc9c9ed
Merge pull request #4882 from matrix-org/t3chguy/room-list/6 
First step towards a11y in the new room list
 2020-07-03 20:17:33 +01:00
Michael Telatynski
af5f9b7c41 revert dark mode separator colour 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-03 19:53:06 +01:00
Michael Telatynski
c8bb6f5904 Improve radio outlines for message layout to be more consistent 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-03 19:48:22 +01:00
Michael Telatynski
5a542281ed Make Styled Radio Button outlines default-off 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
 2020-07-03 19:27:45 +01:00