Commit graph

308 commits

Author SHA1 Message Date
Suguru Hirahara
5446d5d6ba
Fix position of wide images on IRC / modern layout (#8667)
* Move declarations related to position from _MImageBody.scss to _EventTile.scss

These declarations should not be defined as default values as position depends on other factors such as layout, etc.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move min-height and min-width declarations from _MImageBody.scss to _EventTile.scss

Since min-height and min-width have been specified for bubble layout, the declarations have been expected to be applied to the other layouts.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply 'justify-content: center' to bubble layout only

'justify-content: center' was added for the bubble layout with 1436f23. It should not be applied to the other layouts.

In order to prevent an issue related to cascading from happening, 'justify-content: flex-start' is explicitly specified.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 09:02:13 +02:00
Suguru Hirahara
11cb48176e
Fix other user's displayName being wrapped on the bubble message layout (#8456) 2022-05-22 09:07:29 +02:00
Suguru Hirahara
5082d67dc1
Fix wide image overflowing from the thumbnail container (#8663) 2022-05-21 14:42:55 +00:00
Suguru Hirahara
e1e87ac019
Fix styles of "Show all" link button on ReactionsRow (#8658) 2022-05-21 11:38:50 +02:00
Michael Telatynski
ce73b9988e
Hide image banner on stickers, they have a tooltip already (#8641) 2022-05-18 10:08:33 +01:00
Suguru Hirahara
6f851108be
Fix position of the message action bar on left side bubbles (#8398)
* Fix position of the message action bar on data-self=false bubble

- Fix position of the bar on GenericEventListSummary as well
- Override default value `right: 8px` of MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables for MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set the right property to [data-self=true]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove space for "React" and "Reply" buttons inside MessageActionBar on the left side bubble inside ThreadView

This commit removes space reserved for those buttons on deleted or "Unable to decrypt" message bubble inside ThreadView.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-16 15:44:05 +00:00
Šimon Brandner
fc2d7b67d1
Don't show image metadata banner in replies (#8606) 2022-05-16 09:47:21 +02:00
Travis Ralston
f51a6b6da4
Show file name and size on images on hover (#6511)
* Show simple file name and size on images/videos

Fixes https://github.com/vector-im/element-web/issues/18197

* i18n

* Fix bad merge

* Add hover state tracking

* Only show on timeline-like objects

* Match new design requirements

* Remove video support (deemed not needed)

* Colouring and sizing from design

* Include file name in lightbox

* Revert changes to videos since we don't need them

* i18n

* Iterate PR

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-14 10:31:53 +02:00
Suguru Hirahara
f54d54b3ff
Fix MessageTimestamp position next to redacted messages on IRC/modern layout (#8591) 2022-05-14 09:55:52 +02:00
Suguru Hirahara
c6cb00bf0c
Enable overflow of hidden events content (#8585) 2022-05-13 17:01:21 +00:00
Šimon Brandner
7d1ecfdcbc
Make date changes more obvious (#6410)
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-05-09 14:23:51 +01:00
Suguru Hirahara
50a714de4a
Add margin-top to the location body which is a sibling of DisambiguatedProfile (#8523)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-09 06:33:34 +00:00
Suguru Hirahara
c86040b77a
Fix timestamp's position on the chat panel with a maximized widget in IRC layout (#8464)
Fix avatar's position on the chat panel with a maximized widget in IRC layout
Fix timestamp's position on Message Edits history modal window

Also:
- Align DisambiguatedProfile with reactions row and thread summary with a variable
- Add width property as default
- Use the global variable on _IRCLayout.scss

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-07 03:07:51 +00:00
Suguru Hirahara
34471ba855
Fix unexpected and inconsistent inheritance of line-height property for mx_TextualEvent (#8485)
- IRC layout: unspecified
- Modern layout: $font-22px (with _GroupLayout.scss)
- Bubble layout: $font-18px (with _EventBubbleTile.scss)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-07 03:07:11 +00:00
Suguru Hirahara
3a6ddf3a2b
Set max-width for MLocationBody and MLocationBody_map by default (#8519)
To avoid map overflow due to width and height specified by maplibregl-canvas

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-06 18:24:42 +00:00
agrani29
995d008aca
fixed avatar and message box layering (#8190)
Co-authored-by: Andy Balaam <andyb@element.io>
2022-05-04 14:35:04 +00:00
Alexander
2c08063925
Add pointer if you hover over location map (#8451) 2022-04-30 16:15:20 +01:00
Michael Telatynski
f85e178fc1
Fix centering issue with sticker placeholder (#8404) 2022-04-25 17:36:32 +00:00
Suguru Hirahara
af3eac2c4f
Fixes call tiles overflow (#8096)
* Responsive call tiles

Fixes https://github.com/vector-im/element-web/issues/20254

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Take e2e icon into consideration on Bubble message layout

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use spacing variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* spacing variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-04-14 14:27:29 -06:00
Janne Mareike Koschinski
1436f23e2f
Fix image preview sizing for edge cases (#8322) 2022-04-14 20:07:34 +02:00
Kerry
b98739056e
Live location sharing - extract location markers into generic Marker (#8225)
* extract location markers into generic Marker

Signed-off-by: Kerry Archibald <kerrya@element.io>

* comments

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove skinned

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-04-06 12:40:39 +01:00
Germain
694c39e72d
Enable threads by default and mark it as a beta feature (#8081) 2022-04-05 17:15:31 +01:00
Suguru Hirahara
631fd87509
Normalize call buttons (#8129)
- Set a mixin to use it on call events and toasts

Fixes https://github.com/vector-im/element-web/issues/21493

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-04-04 00:34:39 -06:00
Robin
af6bd63ac7
Fix some image/video scroll jumps (#8182)
* Fix some image/video scroll jumps

* Fix aspect ratio formatting

* Fix videos not being responsive to timeline width
2022-03-28 19:07:02 +00:00
Šimon Brandner
bda18f8bc9
Fix disambiguated profile in threads in bubble layout (#8168) 2022-03-28 08:59:06 +01:00
Robin
953e3148d1
Make video sizing consistent with images (#8102)
* Make video sizing consistent with images

* Test suggestedSize

* Constrain width of media in large mode
2022-03-22 18:16:03 -04:00
Šimon Brandner
bff1ef31d6
Use styled mxids in member list v2 (#8110)
* Revert "Revert "Use styled mxids in member list (#6328)" (#8107)"

This reverts commit 709e6e78d2.

* Fix disambiguated profile for bubbles

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
2022-03-22 16:14:55 -06:00
Travis Ralston
709e6e78d2
Revert "Use styled mxids in member list (#6328)" (#8107)
This reverts commit 5d28e0533d.
2022-03-21 19:58:38 -06:00
Šimon Brandner
5d28e0533d
Use styled mxids in member list (#6328)
* Add DisambiguatedProfile

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Give DisambiguatedProfile some nice options

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Delint

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Use DisambiguatedProfile in member tile

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Basic handling of text overflow

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Use name instead of rawDisplayName

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* This seems to make more sense

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Reodred

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* rethemedex

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Fix import

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Fix color

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>

* Appease the linter

* Re-apply UserIdentifier patch

Co-authored-by: Matthew Hodgson <matthew@matrix.org>
Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-03-22 01:08:43 +00:00
Suguru Hirahara
09c57b228e
Fixes mx_MLocationBody_markerBorder (#8069)
Fixes https://github.com/vector-im/element-web/issues/21444

This commit fixes the position of the avatar on the location pin on the
timeline.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-03-18 16:43:44 +01:00
Germain
7508fd975f
Prevent thread creation on events with existing relation (#8037) 2022-03-11 17:51:38 +00:00
Michael Telatynski
86329012f3
Fix location map attribution rendering over message action bar (#7974) 2022-03-04 09:41:18 +00:00
Kerry
7aefa34420
use LocationAssetType (#7965)
* use LocationAssetType

Signed-off-by: Kerry Archibald <kerrya@element.io>

* center icon better

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove debug

Signed-off-by: Kerry Archibald <kerrya@element.io>

* retrigger all builds

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-03 10:04:38 +00:00
Kerry
d304e24a45
Revert "remove code related to encrypted file download button in iframe" (#7957)
* Revert "remove code related to encrypted file download button in iframe (#7940)"

This reverts commit 26216ec527.

* udpate icon import in MFileBody

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-02 18:27:36 +01:00
Kerry
26216ec527
remove code related to encrypted file download button in iframe (#7940)
* remove code related to encrypted file download button in iframe

Signed-off-by: Kerry Archibald <kerrya@element.io>

* i18n

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove getIframeFn in mfilebody filedownloader

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove iframe ref too

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-02 11:55:03 +00:00
Kerry
36adba101c
fix color of location share caret (#7917)
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-01 08:53:28 +00:00
Michael Telatynski
e644ede09e
Fix edge case around event list summary layout (#7867) 2022-02-22 10:25:44 +00:00
Michael Telatynski
57595bc593
Fix misalignment with Event List Summaries (#7865)
* Fix misalignment with Event List Summaries

* simplify styling
2022-02-22 08:35:58 +00:00
Kerry
6fccd6b183
add cursor: pointer to actionable poll options (#7826)
* add cursor: pointer to actionable poll options

Signed-off-by: Kerry Archibald <kerrya@element.io>

* eof

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-02-18 11:43:07 +01:00
Andy Balaam
84e15fa148
Display '(edited)' next to edited polls (#7789) 2022-02-15 08:52:51 +00:00
Andy Balaam
76cafb7aa9
Ensure location bodies have a width in bubbles (#7742) 2022-02-08 12:59:08 +00:00
Šimon Brandner
c52eaa53ce
Remove weird padding on stickers (#6271) 2022-02-08 08:27:37 +00:00
Andy Balaam
afbc843157
Fit location into the width of the container (#7705) 2022-02-02 11:41:33 +00:00
Eric Eastwood
9b0da552e7
Fix vertical spacing in compact <ContextMenu> (#7684)
Fix https://github.com/vector-im/element-web/issues/20801

Regressed in https://github.com/matrix-org/matrix-react-sdk/pull/7339

Relevant styles were first added in https://github.com/matrix-org/matrix-react-sdk/pull/4858
(context behind why the original styles were added)

---

## Cause

Battling CSS specificity between the default and compact styles, https://specificity.keegan.st/

Known good (On `app.element.io` (expected)):
```css
// 0 3 0
.mx_IconizedContextMenu .mx_IconizedContextMenu_optionList .mx_AccessibleButton {
    padding-top: 12px;
    padding-bottom: 12px;
}

// Compact styles override our default rules because they come
// after the other styles (source order) and have the same specificity
// 0 3 0
.mx_IconizedContextMenu.mx_IconizedContextMenu_compact .mx_IconizedContextMenu_optionList > * {
    padding: 8px 16px 8px 11px;
}
```

Bad (On `develop` (broken)):
```css
// Default rules always override because they have higher specificity.
// The `:not()` selector doesn't add any extra specificity but the selectors inside the `:not(...)` do.
// 0 4 0
.mx_IconizedContextMenu .mx_IconizedContextMenu_optionList .mx_AccessibleButton:not(.mx_AccessibleButton_hasKind) {
    padding-top: 12px;
    padding-bottom: 12px;
}

// 0 3 0
.mx_IconizedContextMenu.mx_IconizedContextMenu_compact .mx_IconizedContextMenu_optionList > * {
    padding: 8px 16px 8px 11px;
}
```
2022-02-01 11:23:21 -06:00
Eric Eastwood
7fa27f5834
Add jump to date functionality to date headers in timeline v2 (#7339)
Fix https://github.com/vector-im/element-web/issues/7677

Utilizes MSC3030: https://github.com/matrix-org/matrix-doc/pull/3030

https://user-images.githubusercontent.com/558581/150060664-79627573-f4fd-497c-b726-dc3485854bd0.png
2022-01-27 16:32:12 -06:00
Michael Telatynski
fb49ccce35
Show bubble tile timestamps for bubble layout inside the bubble (#7622) 2022-01-25 13:10:17 +00:00
Germain
336217f668
Add view in room to action bar in thread list (#7519) 2022-01-19 10:39:33 +00:00
Andy Balaam
2743a75a21
Display general marker on non-self location shares (#7574) 2022-01-19 09:33:49 +00:00
David Teller
6b870ba1a9
MSC3531 - Implementing message hiding pending moderation (#7518)
Signed-off-by: David Teller <davidt@element.io>
2022-01-17 16:04:37 +01:00
Kerry
fed53a268b
A11y - fix anchors-as-buttons (#7444)
* add link_inline accessiblebutton variant

* valid anchors in SecurityRoomSettingsTab

Signed-off-by: Kerry Archibald <kerrya@element.io>

* new room intro link button

Signed-off-by: Kerry Archibald <kerrya@element.io>

* replace anchor with button in rerequest encryption keys message

Signed-off-by: Kerry Archibald <kerrya@element.io>

* inline button in UrlPreviewSettings

Signed-off-by: Kerry Archibald <kerrya@element.io>

* ButtonResetDefault mixin

Signed-off-by: Kerry Archibald <kerrya@element.io>

* inline link buttons in TextForEvent

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix anchors in InviteDialog

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix anchors in DevToolsDialog

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix anchors in login/registration/reset pword flows

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix types after fixing anchors in devtools

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix anchors in MemberEventListSummary

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix anchors in ReactionsRow and RoomUpgrade

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix anchors in ReplyChain

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix more anchors

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix anchors in auth comps

* stylelint fixes

Signed-off-by: Kerry Archibald <kerrya@element.io>

* remove ignore of jsx-a11y rule that is not added yet

Signed-off-by: Kerry Archibald <kerrya@element.io>

* devtools style important explainer

Signed-off-by: Kerry Archibald <kerrya@element.io>

* translate button alt in devtools dialog

Signed-off-by: Kerry Archibald <kerrya@element.io>

* AccessibleButton is reactionsrow

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix viewsourcevent button placement, use AccessibleButton

Signed-off-by: Kerry Archibald <kerrya@element.io>

* use AccessibleButton in EventTile

Signed-off-by: Kerry Archibald <kerrya@element.io>

* unignore jsx-a11y/anchor-is-valid

Signed-off-by: Kerry Archibald <kerrya@element.io>

* fix lint issue in test jsx

Signed-off-by: Kerry Archibald <kerrya@element.io>

* update coment

Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-01-07 10:40:53 +01:00