Commit graph

3462 commits

Author SHA1 Message Date
Suguru Hirahara
b12a272385
Use AccessibleButton for 'In reply to' link button on ReplyChain (#8726)
- Remove ButtonResetDefault mixin to respect the concept of cascading

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-31 15:52:12 -06:00
Suguru Hirahara
bae8854c13
Remove inline margin from UTD error message inside a reply tile on ThreadView (#8708)
* Remove inline margin from UTD error message inside a reply tile on ThreadView

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge 'mx_ReplyChain_wrapper' blocks

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-30 08:55:12 +02:00
Robin
f47121ece7
Revert "Fix wide image overflowing from the thumbnail container (#8663)" (#8709)
This reverts commit 5082d67dc1.
2022-05-27 17:18:44 +00:00
Suguru Hirahara
12abbf4042
Prevent overflow of grid items on a bubble with UTD generally (#8697) 2022-05-27 10:41:53 +01:00
Suguru Hirahara
aef080ac80
Create 'Unable To Decrypt' grid layout for hidden events on a bubble layout (#8704) 2022-05-27 09:23:34 +01:00
Suguru Hirahara
f3b762c1a8
Move unread notification dots of the threads list to the expected position (#8700)
* Change dot size from 10px to 8px

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set inset 8px to the dot

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use shorthand properties for inset

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move blocks from '.mx_EventTile:not([data-layout=bubble])' to '.mx_EventTile[data-shape=ThreadsList]'

For a notification dot it does not matter whether the layout of the event tile is bubble or not. Instead what matters is that the dot is expected to be displayed on the threads list.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant declarations

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove an obsolete z-index declaration

The declaration was added with ed34952 to fix a clickability issue. Now the event tile is clickable everywhere, it is no longer required.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 23:33:35 +01:00
Suguru Hirahara
dbd9911fe7
Align EventTile_line with display name on message bubble (#8692) 2022-05-25 14:08:43 +00:00
Suguru Hirahara
948f81d25f
Make the empty thread panel fill BaseCard (#8690)
Use border-box to make maintaining the layout more intuitive.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 14:33:27 +02:00
Suguru Hirahara
90dfb8d61f
Move style rules related to ThreadPanel from EventTile (#8683)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 09:36:12 +02:00
Suguru Hirahara
03c2bdbde1
Remove ButtonResetDefault from mx_AccessibleButton of EventTile_keyRequestInfo_text (#8678)
To respect the concept of cascading. Also using a mixin to unset the declarations can easily cause a style inconsistency.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-25 08:45:18 +02:00
Suguru Hirahara
8afb1abd36
Fix a grid blowout due to nowrap displayName on a bubble with UTD (#8688) 2022-05-25 06:50:36 +02:00
Suguru Hirahara
412c207b23
Apply the same max-width to image tile on the thread timeline as message bubble (#8669) 2022-05-25 06:31:39 +02:00
Suguru Hirahara
ed2c79051e
Fix dropdown button size for picture-in-picture CallView (#8680) 2022-05-24 17:49:04 +02:00
Suguru Hirahara
9f1bffcd34
Fix file button and audio player overflowing from message bubble (#8666)
* Fix file button and audio player overflowing from message bubble

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move '.mx_EventTile_image' to '.mx_EventTile_mediaLine'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use class names for now, adding a TODO comment

Remove unset as it is no longer required.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-24 09:06:04 +02:00
Suguru Hirahara
ef977146c3
Prevent possible regressions of EventTile structurally (#8647)
* '.mx_EventTile_e2eIcon_warning' and '.mx_EventTile_e2eIcon_normal'

- Include '.mx_EventTile_e2eIcon_warning' and '.mx_EventTile_e2eIcon_normal'
- Merge '.mx_EventTile_e2eIcon_warning' and '.mx_EventTile_e2eIcon_normal'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* mx_EventTile_spoiler

- Group 'mx_EventTile_spoiler'
- mx_EventTile_spoiler.visible

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group 'mx_EventTile_button'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_collapseButton' and '.mx_EventTile_expandButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_body .mx_EventTile_pre_container'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_copyButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_collapseButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_expandButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_copyButton' and '.mx_EventTile_collapseButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Group '.mx_EventTile_collapseButton'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include '.mx_EventTile_collapsedCodeBlock' in '.mx_EventTile_pre_container'

Collapsed code block is displayed only in mx_EventTile_pre_container

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* .mx_EventTile_keyRequestInfo

- Include '.mx_EventTile_keyRequestInfo_text' in '.mx_EventTile_keyRequestInfo'
- Include '.mx_AccessibleButton' in '.mx_EventTile_keyRequestInfo_text'
- Include '.mx_EventTile_keyRequestInfo_tooltip_contents p:first-child' and 'p:last-child' in '.mx_EventTile_keyRequestInfo_tooltip_contents p'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Separate properties of mx_EventTile_button

The properties which should only be applied to buttons inside mx_EventTile_pre_container should not be applied to the top level.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply mask-size of collapse button and expand button to ones in mx_EventTile_pre_container only

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move declarations of buttons from mx_EventTile_button to mx_EventTile_pre_container

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move buttons declarations below mx_EventTile_button

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include '.mx_EventTile_pre_container' in '.mx_EventTile_body .mx_EventTile_pre_container'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Specify width and height to only buttons in mx_EventTile_pre_container

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Dedupe 'mx_EventTile_e2eIcon' ::before

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Hide buttons in mx_EventTile_pre_container and show them on hover by default

Setting "visibility: hidden" to mx_EventTile_button can easily cause a regression. The declaration should be exclusively applied to buttons inside mx_EventTile_pre_container, and "visibility: visible" should be set to those buttons only.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove redundant nestings for E2E icons

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 21:16:50 +01:00
Suguru Hirahara
20fd68b902
Organize UserInfo.scss (#8461)
* .mx_UserInfo_profileField under .mx_UserInfo_memberDetails

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* .mx_UserInfo_container:not(.mx_UserInfo_separator) under .mx_UserInfo_container

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* reorganize structure of .mx_UserInfo_avatar - 1

.mx_UserInfo_avatar > div > div *

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* reorganize structure of .mx_UserInfo_avatar - 2

.mx_UserInfo_avatar > div > div

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* reorganize structure of .mx_UserInfo_avatar - 3

.mx_UserInfo_avatar > div

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* reorganize structure of .mx_UserInfo_avatar - 4

- .mx_BaseAvatar_initial
- .mx_BaseAvatar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* reorganize structure of .mx_UserInfo_avatar - 5

Move .mx_BaseAvatar_initial under .mx_BaseAvatar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Replace a wildcard with className

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Specify className

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* .mx_UserInfo.mx_BaseCard.mx_UserInfo_smallAvatar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Fix position of the E2E icon of expanding sessions button

To prevent the icon from moving down a little bit

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 12:42:31 +01:00
Suguru Hirahara
764b307e63
Edit properties and values of EventTile on ThreadView (#8638)
* Edit properties and values of EventTile on ThreadView

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove obsolete order properties of EventTile on ThreadView

These values are no longer required as the reactions row is displayed under the message by default.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 11:11:55 +01:00
Suguru Hirahara
eb977e6e7d
Add padding to event info tile for MessageTimestamp on TimelineCard (#8639)
* Add padding-right to EventTile_line in EventTile_info on TimelineCard

Also ensure the same padding values are applied to EventTile_line on TimelineCard.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove git diff

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 09:52:52 +00:00
Suguru Hirahara
67b0078b33
Integrate thread panel's header style declarations with those of BaseCard (#8651)
* Variable on mx_BaseCard_Header

- Use a variable for margin of buttons on mx_BaseCard_header
- Reduce default margin instead of setting negative left and right values
- Set margin to span in order to ensure spacing between the back button and the span (6px: 30px - 24px)

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use the same variable to the mask button

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use spacing variables

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove obsolete declarations - mx_ThreadPanel_button

mx_ThreadPanel_button does not seem to be used anywhere.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 09:42:48 +02:00
Suguru Hirahara
5446d5d6ba
Fix position of wide images on IRC / modern layout (#8667)
* Move declarations related to position from _MImageBody.scss to _EventTile.scss

These declarations should not be defined as default values as position depends on other factors such as layout, etc.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move min-height and min-width declarations from _MImageBody.scss to _EventTile.scss

Since min-height and min-width have been specified for bubble layout, the declarations have been expected to be applied to the other layouts.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply 'justify-content: center' to bubble layout only

'justify-content: center' was added for the bubble layout with 1436f23. It should not be applied to the other layouts.

In order to prevent an issue related to cascading from happening, 'justify-content: flex-start' is explicitly specified.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-23 09:02:13 +02:00
Suguru Hirahara
11cb48176e
Fix other user's displayName being wrapped on the bubble message layout (#8456) 2022-05-22 09:07:29 +02:00
Suguru Hirahara
6825b43f42
Set spacing declarations to elements in mx_EventTile_mediaLine (#8665) 2022-05-22 08:19:45 +02:00
Suguru Hirahara
23babbb8ab
Normalize inline spacing of image and file button on ThreadView (#8664) 2022-05-21 22:19:56 +02:00
Suguru Hirahara
5082d67dc1
Fix wide image overflowing from the thumbnail container (#8663) 2022-05-21 14:42:55 +00:00
Suguru Hirahara
e1e87ac019
Fix styles of "Show all" link button on ReactionsRow (#8658) 2022-05-21 11:38:50 +02:00
Suguru Hirahara
348863debb
Move '.mx_ThreadSummary' from _ThreadPanel.scss to _TimelineCard.scss (#8661) 2022-05-21 11:34:00 +02:00
Travis Ralston
025fb631b7
Update "jump to related event" for design requirements & dev tooling (#8652) 2022-05-20 08:07:00 -06:00
Suguru Hirahara
30b03776b8
Align input area with event body's first letter in a thread on IRC/modern layout (#8636)
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-20 10:14:37 +01:00
Germain
3f2f839b3b
Add jump to related event context menu item (#6775) 2022-05-19 14:56:10 +01:00
Travis Ralston
e87bda9f37
Add an option to ignore (block) a user when reporting their events (#8471)
* Add an option to ignore (block) a user when reporting their events

This is primarily useful if the content being reported really doesn't belong on your screen, and the room moderators are slow to react.

Ideally we'd use the word "block" instead of "ignore", but we call it "ignore user" everywhere else. See https://github.com/vector-im/element-web/issues/19590 for further context on the word choice.

This change includes a minor refactor to the styles of labelled toggles (for reusability).

* Appease the linter

* Use a checkbox instead of toggle in the dialog

* Update classnames handling for toggle switch

* Appease the linter
2022-05-18 16:20:55 +00:00
Suguru Hirahara
c715f72745
Remove obsolete declarations for buttons on EditMessageComposer on ThreadView (#8632)
Those declarations are no longer necessary to align the buttons with the right edge of the input area and background.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-18 14:22:42 +01:00
Suguru Hirahara
9b92eca73d
Organize rules of GenericEventListSummary on bubble layout (#8599)
* Organize - data-expanded=false

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Organize - data-expanded=true

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Organize - EventTile

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Dedupe mx_GenericEventListSummary[data-layout=bubble]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-18 14:10:02 +01:00
Suguru Hirahara
bb46846981
Set common horizontal spacing rules for EventTile on the right panel (#8528)
* Remove an obsolete override against .mx_EventTile_line

- Move &[data-layout=bubble] under mx_ThreadView
- Use variables for .mx_NewRoomIntro
- Move the variable to BaseCard

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use --ThreadView_group_spacing-end variable

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Apply GenericEventListSummary rules to ThreadView only

This commit stops those declarations from being applied to TimelineCard, which is also applied with mx_ThreadPanel class name.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Nesting - mx_GenericEventListSummary:not([data-layout=bubble])

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style --fix

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-18 14:08:39 +01:00
Suguru Hirahara
8d59612c74
Merge styles of mx_EventTile_content for maintainability (#8605)
* Include mx_EventTile_edited in mx_EventTile_content

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include mx_EventTile_pendingModeration in mx_EventTile_content

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Merge style rules of mx_EventTile_edited and mx_EventTile_pendingModeration

Except "cursor: pointer" of mx_EventTile_edited

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include markdown-body in mx_EventTile_content

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include 'pre code' in 'pre'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include 'mx_EventTile_content' in 'mx_EventTile_content'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include 'mx_EventTile_content .markdown-body' header in 'mx_EventTile_content'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Include 'mx_EventTile_content .markdown-body' a, blockquote, and em in 'mx_EventTile_content'

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove a comment on selector 'code'

There is technically nothing wrong that a declaration for 'code' is inherited to 'pre code'.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-18 14:04:39 +01:00
Michael Telatynski
ce73b9988e
Hide image banner on stickers, they have a tooltip already (#8641) 2022-05-18 10:08:33 +01:00
Suguru Hirahara
9889aa0de2
Adjust EditMessageComposer style declarations (#8631) 2022-05-17 19:12:13 +02:00
Suguru Hirahara
6f851108be
Fix position of the message action bar on left side bubbles (#8398)
* Fix position of the message action bar on data-self=false bubble

- Fix position of the bar on GenericEventListSummary as well
- Override default value `right: 8px` of MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Use variables for MessageActionBar

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Set the right property to [data-self=true]

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove space for "React" and "Reply" buttons inside MessageActionBar on the left side bubble inside ThreadView

This commit removes space reserved for those buttons on deleted or "Unable to decrypt" message bubble inside ThreadView.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-16 15:44:05 +00:00
Šimon Brandner
fb30b67b14
Fix issues with the new topic dialog (#8608) 2022-05-16 14:10:00 +02:00
Šimon Brandner
e1d11db256
Don't show public indicator on spaces (#8607) 2022-05-16 10:24:01 +02:00
Šimon Brandner
fc2d7b67d1
Don't show image metadata banner in replies (#8606) 2022-05-16 09:47:21 +02:00
Suguru Hirahara
eb10c3647b
Remove an obsolete declaration for DisambiguatedProfile of EventTile on modern layout (#8596) 2022-05-14 15:11:01 +02:00
Šimon Brandner
11eca18450
Stop spaces from displaying as rooms in new breadcrumbs (#8595) 2022-05-14 13:41:17 +02:00
Šimon Brandner
e0d94f6338
Add right margin to pills (#8593) 2022-05-14 13:41:05 +02:00
Suguru Hirahara
9b9ecf9c55
Fix avatar position of hidden event on ThreadView (#8592) 2022-05-14 11:34:27 +02:00
Travis Ralston
f51a6b6da4
Show file name and size on images on hover (#6511)
* Show simple file name and size on images/videos

Fixes https://github.com/vector-im/element-web/issues/18197

* i18n

* Fix bad merge

* Add hover state tracking

* Only show on timeline-like objects

* Match new design requirements

* Remove video support (deemed not needed)

* Colouring and sizing from design

* Include file name in lightbox

* Revert changes to videos since we don't need them

* i18n

* Iterate PR

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-14 10:31:53 +02:00
Suguru Hirahara
f54d54b3ff
Fix MessageTimestamp position next to redacted messages on IRC/modern layout (#8591) 2022-05-14 09:55:52 +02:00
Suguru Hirahara
1fc8009109
Fix padding of messages in threads (#8574)
* Apply the padding setting of EventTile_line of ThreadView to TimelineCard

Set 2px padding-top and padding-bottom property to EventTile_line on IRC/modern layout of TimelineCard.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

f

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Move position property of mx_EventTile_e2eIcon from ThreadPanel to TimelineCard

The E2E icon is available only on TimelineCard.

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* yarn run lint:style

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-05-13 12:04:27 -06:00
Šimon Brandner
170b41f43b
Center initial letter in pills (#8575) 2022-05-13 19:51:11 +02:00
Suguru Hirahara
c6cb00bf0c
Enable overflow of hidden events content (#8585) 2022-05-13 17:01:21 +00:00
Robin
46bdccea9d
Increase composer line height to avoid cutting off emoji (#8583) 2022-05-13 11:31:27 -04:00