Commit graph

381 commits

Author SHA1 Message Date
Andy Balaam
11507790fd
Skip redaction tests that are still flaking (#11704)
* Unflake redaction tests by checking unread state before sending redactions

* Skip a flaky test

* Skip redaction tests that are still flaking
2023-10-03 21:12:36 +00:00
Andy Balaam
54a4875e15
Unflake redaction tests by checking unread state before sending redactions (#11696) 2023-10-03 18:03:52 +01:00
Richard van der Hoff
da85b6f257
Enable some cypress tests for rust crypto (#11689) 2023-10-03 15:04:13 +00:00
Andy Balaam
f1d34adbbe
Merge pull request #11695 from matrix-org/andybalaam/share-code-between-read-receipt-tests
Share code for room initialisation between read receipt tests
2023-10-03 15:40:06 +01:00
Florian Duros
067e338b4b
Cypress: Check that the new verified device is connected to key backup (#11686)
* Check that the new verified device is connected to key backup

* Review changes. Extract key backup verification in its own function and chang parameter order of bot `bootstrapSecretStorage` call.
2023-10-03 12:44:15 +00:00
Andy Balaam
d34ed6b66c
Merge branch 'develop' into andybalaam/share-code-between-read-receipt-tests 2023-10-03 09:08:00 +01:00
Richard van der Hoff
e8890467fe
Fix a flaky cypress crypto test (#11687)
* Fix a flaky cypress crypto test

We need to be a bit proactive to get existing shields to update when a device
is deleted.

* Handle different text between rust and legacy crypto
2023-10-02 20:07:42 +00:00
Richard van der Hoff
6e559266df
Cypress test for incoming user verification (#11688)
* Cypress test for incoming user verification

* Fix complaint from cypress about immediate values
2023-10-02 19:08:41 +00:00
Andy Balaam
ff1057fb0a Share code for room initialisation between read receipt tests 2023-10-02 16:59:38 +01:00
Andy Balaam
966d8bd695
Ensure the bot has joined the correct room before we start the test (#11693) 2023-10-02 12:51:56 +00:00
Andy Balaam
1897962086
Fix expectations in edit tests: edits should not cause unread (#11682)
* Fix expectations in edit tests: edits should not cause unread

* Skip flaky test
2023-10-02 09:55:18 +00:00
Andy Balaam
506f286a3e
Tests for paging up to find old messages (#11650)
* Use longer numbers for many() messages to avoid substring clashes

* Tests for paging up
2023-09-29 08:26:47 +00:00
Michael Telatynski
6af4335db1
Migrate more strings to translation keys (#11680) 2023-09-29 08:49:26 +01:00
Andy Balaam
d7d0f54e9b
Merge branch 'develop' into andybalaam/fix-receipt-flakes 2023-09-28 14:23:45 +01:00
Andy Balaam
58afa900d5
Target specific thread name to unflake redaction tests (#11662)
* Disambiguate thread root names to unflake redaction tests

* Revert "Disambiguate thread root names to unflake redaction tests"

This reverts commit f21ffa5554e7d49322acc8f8c1c1ef4063b9efdd.

* Find thread root by text, not contains
2023-09-28 12:44:29 +00:00
Andy Balaam
8565637213
Merge branch 'develop' into andybalaam/fix-receipt-flakes 2023-09-25 17:40:08 +01:00
Andy Balaam
de250df520
Merge pull request #11654 from matrix-org/andybalaam/fix-high-level-flakes
Fix flake in high-level tests by not using markAsRead
2023-09-25 12:53:56 +01:00
Andy Balaam
4804adcef6 Fix flaky receipt and redaction tests by pausing between message sends 2023-09-25 12:06:22 +01:00
Andy Balaam
4097844fed Fix flake in high-level tests by not using markAsRead 2023-09-25 09:55:37 +01:00
Andy Balaam
25a462ad8e Fix lint error 2023-09-25 09:51:44 +01:00
Andy Balaam
10eac43e24 Fix flaky test that raced because we were in the room while the count changed 2023-09-25 09:51:44 +01:00
Andy Balaam
14a622b1e8 Fix flaky test that assumes edits count as messages 2023-09-25 09:51:44 +01:00
Andy Balaam
1c2d604abe
Split the read-receipt tests into logical units (#11649)
* Split the read-receipt tests into logical units

* Move read-receipt docs into a readme file

* Provide doc comments for exported functions in read-receipt tests
2023-09-22 11:57:40 +00:00
Richard van der Hoff
f60ba1c29d
Fix cypress test for events from unsigned devices (#11636) 2023-09-21 09:54:23 +00:00
Andy Balaam
8ac25758b3
Cypress tests for redacted messages in threads and thread roots (#11629)
* Tests for redacted messages in threads and thread roots

* Cache redacted events and enable tests that refer to them
2023-09-20 10:57:24 +00:00
Andy Balaam
d46d4b3d04
More tests for reactions to messages in threads (#11612)
* Tests for redacting messages not increasing unreads

* Comment explaining tips for writing high level rr tests

* Test for restarting with a receipt pointing at a redacted thread root

* Two failing tests for counting correctly when a thread message was redacted

* Test for reading a thread containing an earlier redaction

* Failing tests for redacted messages in threads

* More tests for reactions to messages in threads

* Wait before looking for the thread list, to let the room settle
2023-09-19 13:29:04 +00:00
Richard van der Hoff
50ee43c4a5
Enable cypress tests for shields with rust crypto (#11589)
* Use new crypto-api for cross user verification

* update verification flow with new APIs

* Replace some calls to `checkUserTrust`

A start on https://github.com/vector-im/crypto-internal/issues/147

* Enable cypress tests

* update tests

* Delegate decisions on event shields to the js-sdk

* rerender after editing events

This is required because a transition from "valid event" to "unencrypted event"
no longer triggers a state change, so the component does not render
itself. Previously, this would be a transition from `verified:
E2EState.Normal` to `verified: null`.

* Update tests

* prettier

* Test coverage

* Enable cypress tests for shields with rust crypto

---------

Co-authored-by: Florian Duros <florianduros@element.io>
2023-09-18 21:34:24 +00:00
Richard van der Hoff
cf2340bcad
Replace event verification logic with new code in js-sdk (#11528)
* Use new crypto-api for cross user verification

* update verification flow with new APIs

* Replace some calls to `checkUserTrust`

A start on https://github.com/vector-im/crypto-internal/issues/147

* Enable cypress tests

* update tests

* Delegate decisions on event shields to the js-sdk

* rerender after editing events

This is required because a transition from "valid event" to "unencrypted event"
no longer triggers a state change, so the component does not render
itself. Previously, this would be a transition from `verified:
E2EState.Normal` to `verified: null`.

* Update tests

* prettier

* Test coverage

---------

Co-authored-by: Florian Duros <florianduros@element.io>
2023-09-18 17:12:18 +00:00
Florian Duros
579b0dd10a
ElementR: Cross user verification (#11364)
The hard work has been done in previous PRs in the js-sdk, so this is now just a case of updating a few call sites to use the new APIs.
2023-09-18 17:34:00 +01:00
Andy Balaam
e887c6d71f
Cypress tests for redactions in threads (#11594)
* Tests for redacting messages not increasing unreads

* Comment explaining tips for writing high level rr tests

* Test for restarting with a receipt pointing at a redacted thread root

* Two failing tests for counting correctly when a thread message was redacted

* Test for reading a thread containing an earlier redaction

* Failing tests for redacted messages in threads
2023-09-18 15:01:05 +00:00
Andy Balaam
5a3c32e26c
More assertions about threads being read (#11505) 2023-09-18 09:09:47 +00:00
RMidhunSuresh
610f9396bb
Fix broken tests 2023-09-14 16:55:14 +05:30
Andy Balaam
b1f455eb2d
Assert that the thread is unread after an edit (#11504)
* Expand a thread reply test to be more explicit

* Add an assertion that the thread is read after I read it

* Assert that the thread is unread after an edit
2023-09-12 11:41:04 +00:00
Andy Balaam
a4156add49
Tests for thread roots and reading history (#11588)
* Minor improvements to unread tests

* Test for reading an older message in a room

* Test for reading an old message in a thread

Also a mostly-trivial test for read status being preserved over
restarts.

* Give the reason for a failing test

* Fix a failing test by making it wait for a thread to be read

* More tests for thread roots
2023-09-12 03:22:04 +00:00
Andy Balaam
a621dfa6c1
Expand a thread reply test to be more explicit (#11502) 2023-09-09 06:45:48 +00:00
Andy Balaam
a4b861637f
Avoid using markAsRead where we don't need it (#11517)
* Avoid using markAsRead where we don't need it

* Review response
2023-09-08 13:07:26 +00:00
Andy Balaam
493d5083a8
Tests for reacting to thread roots (#11586) 2023-09-08 13:06:44 +00:00
Andy Balaam
728a3a751a
Tests for redactions in the main timeline (#11587) 2023-09-08 13:06:25 +00:00
Andy Balaam
f1f8c6bf2c
Add waits in Spotlight Cypress tests, hoping this unflakes them (#11590)
Attempt to fix:

* https://github.com/vector-im/element-web/issues/26053
* https://github.com/vector-im/element-web/issues/26140
* https://github.com/vector-im/element-web/issues/26139
* https://github.com/vector-im/element-web/issues/26138
2023-09-08 12:08:21 +00:00
Andy Balaam
77b681eed9
Add a (failing for unrelated reasons) test for reading a thread root (#11534) 2023-09-08 00:32:16 +00:00
renovate[bot]
35a6595080
Update dependency cypress to v13 (#11570)
* Update dependency cypress to v13

* Update cypress.config.ts

* Fix test

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2023-09-07 15:07:39 +00:00
Richard van der Hoff
3818c1dc70
Cypress tests for event shields (#11525)
* Factor downloadKey out to `utils.ts`

* Add a new `describe` block for event shields

* create a beforeEach block

* Cypress tests for event shields
2023-09-05 11:11:10 +00:00
Andy Balaam
f8ff95349a
Add a 'm.relates_to' to edits in receipt tests and disable failing tests (#11501)
* Add a 'm.relates_to' to edits in receipt tests

* Disable a test that fails with real edits

* Wait for the room to be read after we mark it as read

* Skip tests that are failing because of inconsistencies between local and CI behaviour
2023-09-04 16:08:03 +00:00
Richard van der Hoff
30d997e21c
Remove green "verified" bar for e2e events (#11496)
There is a little-known feature where, if you have verified a user (eg, via the
emoji game), then when you mouse-over a message that they sent, it gets a green
highlight.

We also show a brown bar sometimes, and according to the CSS there may be a
yellow bar too?

Very few people seem to know this exists, and even if you do know it exists
nobody seems to understand what exactly the various colours are supposed to be.

So, rather than porting this magic mystery feature to Rust Crypto, let's rip it
out.
2023-09-01 09:41:14 +00:00
Andy Balaam
c7b0850ffe
Improve comments in unread tests (#11491) 2023-08-31 13:08:37 +00:00
Andy Balaam
aaea42c626
Use a single synapse for all unread tests. (#11489)
Saves about 30 seconds per run.
2023-08-30 15:15:47 +00:00
Andy Balaam
c6d9228f94
Fix flaky Cypress test cypress/e2e/widgets/stickers.spec.ts (#11440)
* Fix tests choosing the wrong room by matching on exact room name in viewRoomByName

* Allow either of the two different URLs for thumbnails in sticker test

* Find room by looking inside Rooms for something with the right text

* Check for the download URL of a thumbnail only, which will appear after the thumbnail 404s

* Click the title div instead of the contained span, to avoid clicking something potentially off-screen

* Find by label text because that works when room list is folded

* Find room by title because label text is different

* Attempt to allow opening room by name in all needed cases
2023-08-25 11:04:56 +00:00
Andy Balaam
5b290196cd
Fix read receipt tests with incorrect read counts (#11465)
These counts were transiently correct if the client was slow enough, so
the tests usually passed, but actually they were wrong.
2023-08-25 09:20:43 +00:00
Germain
09c5e06d12
Change avatar to use Compound implementation (#11448)
* Move avatar to new compound implementation

* Make space avatars square

* Remove reference to the avatar initial CSS class

* remove references to mx_BaseAvatar_image

* Fixe test suites

* Fix accessbility violations

* Add ConfirmUserActionDialog test

* Fix tests

* Add FacePile test

* Fix items clipping in members list

* Fix user info avatar sizing

* Fix tests
2023-08-24 03:48:35 +00:00
Andy Balaam
b231bbb683
Disable some IRC audio player tests because they are flaky (#11456)
See https://github.com/vector-im/element-web/issues/24881
2023-08-23 10:00:50 +00:00