Kerry
7a80ea4bbe
Test typescriptification - MessagePanel ( #8943 )
...
* mv test/components/structures/MessagePanel-test.js test/components/structures/MessagePanel-test.tsx
* convert simpler messagepanel tests to rtl
* add data-testid to eventlistsummary
* convert read marker tests to rtl
* formatting
* remove commented
2022-06-30 14:41:53 +02:00
Robin
ef48443dc9
Show chat panel when opening a video room with unread messages ( #8812 )
...
* Show chat panel when opening a video room with unread messages
* Remove unnecessary calls to private methods in tests
* Make room ID mandatory when toggling the right panel
* Restore the isViewingRoom check
* Test RightPanelStore
* Make the constructor private again
* Add even more tests
* Fix onReady
2022-06-17 16:57:40 -04:00
Suguru Hirahara
fe8c267a14
Create a common header on right panel cards on BaseCard ( #8808 )
...
* Remove duplicate declarations and add height and overflow properties
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move mx_TimelineCard__header under mx_BaseCard_header for normalization
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Normalize mx_BaseCard_close position
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Normalize className of header
- mx_BaseCard_header__ThreadPanel
- mx_BaseCard_header__TimelineCard
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Normalize header's button size
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Normalize inline start header margin
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* normalize header bottom margin for PinnedMessagesCard and TimelineCard
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Normalize header declarations
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add mixin RightPanelCard
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move common declarations - top level
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move common declarations - mx_BaseCard_header
Remove specific declarations on PinnedMessagesCard
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move common declarations - mx_BaseCard_back and mx_BaseCard_close
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Create a common class name - mx_BaseCard_header_title
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Create a common class name - mx_BaseCard_header_title - ThreadPanel
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move common declarations - mx_BaseCard_header_title
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move common declarations - span:first-of-type
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove redundant declarations
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Rename a variable to remove --ThreadPanel_header-button-size
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove class name - mx_BaseCard_header_title
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove mx_BaseCard_header_title--ThreadPanel and h2 declarations from PinnedMessagesCard
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Headers need Heading
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use spacing variables
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Move common style rules of mx_ContextualMenu inside mx_BaseCard_header_title to BaseCard
leaving style rules specific to ThreadPanel.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Hide long header title with ellipsis
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Merge style rules - BaseCard_header-button-size
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Merge style rules - BaseCard_header margin-bottom
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Merge style rules - BaseCard back and close margin
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Merge style rules - BaseCard back ~ mx_BaseCard_header_title
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Merge style rules - mx_BaseCard_header_title
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Return special declarations to _ThreadPanel.scss
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove the mixin
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Add mx_BaseCard_header_title_button--option
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove redundant margin from AppTileFullWidth
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Header on mx_RoomSummaryCard - remove default declarations
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Remove default declarations from mx_UserInfo
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
* Use variables - _BaseCard.scss
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
2022-06-16 09:22:45 +02:00
Robin
53340db5e9
Update the live timeline when the JS SDK resets it ( #8806 )
2022-06-10 08:59:07 -04:00
Andy Balaam
4e1958d9fe
Fix #20026 : send read marker as soon as we change it ( #8802 )
2022-06-09 13:41:09 +00:00
Robin
d9396b0b54
Expire video member events after 1 hour ( #8776 )
...
* Expire video member events after 1 hour
* Iterate based on feedback
* Validate the types of video member events better
* Even more parentheses
2022-06-09 13:19:52 +00:00
Robin
f152310c08
Use random widget IDs for video rooms ( #8739 )
2022-06-02 09:10:22 -04:00
Hugh Nimmo-Smith
60cd740b66
Fix crash on null idp for SSO buttons ( #8650 )
...
* Add test case for null identity_providers for SSO
* Fix typing for identity_providers
* Make null idp explicit and handle in analytics
* chore: whitespace fix
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-05-20 10:08:57 +01:00
Robin
ceda77d7dc
Proactively fix stuck devices in video rooms ( #8587 )
...
* Proactively fix stuck devices in video rooms
* Fix tests
* Explain why we're disabling the lint rule
* Apply code review suggestions
* Back VideoChannelStore's flags by SettingsStore instead of localStorage
2022-05-16 16:54:08 -04:00
Kerry
42f12485bc
fix ts issues in Registration-test ( #8579 )
...
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-05-16 08:23:51 +00:00
Michael Telatynski
59b9d1e818
Don't consider threads for breaking continuation until actually created ( #8581 )
...
* Don't consider threads for breaking continuation until they've actually been created
* Update tests
* Make hasThreadSummary null thread safe
* Apply feedback from pr review
2022-05-13 11:59:50 +00:00
Robin
658ff4dfe6
Iterate video room designs in labs ( #8499 )
...
* Remove blank header from video room view frame
* Add video room option to space context menu
* Remove duplicate tooltips from face piles
* Factor RoomInfoLine out of SpaceRoomView
* Factor RoomPreviewCard out of SpaceRoomView
* Adapt RoomPreviewCard for video rooms
* "New video room" → "Video room"
* Add comment about unused cases in RoomPreviewCard
* Make widgets in video rooms mutable again to de-risk future upgrades
* Ensure that the video channel exists when mounting VideoRoomView
2022-05-04 17:02:06 -04:00
Kerry
c5633a24fe
Live location sharing: don't group beacon info with room creation summary ( #8468 )
...
* dont group beacon info with room creation summary
Signed-off-by: Kerry Archibald <kerrya@element.io>
* remove debugs
Signed-off-by: Kerry Archibald <kerrya@element.io>
* add comment
Signed-off-by: Kerry Archibald <kerrya@element.io>
* update comment
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-05-03 09:04:47 +00:00
Michael Telatynski
a70f11704f
Don't form continuations on either side of a thread root ( #8408 )
2022-04-26 08:30:36 +00:00
Michael Telatynski
bbe0c945d3
Fix regression around haveRendererForEvent for hidden events ( #8379 )
2022-04-21 16:57:08 +00:00
Robin
6e86a14cc9
Show a lobby screen in video rooms ( #8287 )
...
* Show a lobby screen in video rooms
* Add connecting state
* Test VideoRoomView
* Test VideoLobby
* Get the local video stream with useAsyncMemo
* Clean up code review nits
* Explicitly state what !important is overriding
* Use spacing variables
* Wait for video channel messaging
* Update join button copy
* Show frame on both the lobby and widget
* Force dark theme for video lobby
* Wait for the widget to be ready
* Make VideoChannelStore constructor private
* Allow video lobby to shrink
* Add invite button to video room header
* Show connected members on lobby screen
* Make avatars in video lobby clickable
* Increase video channel store timeout
* Fix Jitsi Meet getting wedged on startup in Chrome and Safari
* Revert "Fix Jitsi Meet getting wedged on startup in Chrome and Safari"
This reverts commit 9f77b8c227c1a5bffa5d91b0c48bf3bbc44d4cec.
* Disable device buttons while connecting
* Factor RoomFacePile into a separate file
* Fix i18n lint
* Fix switching video channels while connected
* Properly limit number of connected members in face pile
* Fix CSS lint
2022-04-20 11:03:33 -04:00
Robin
7335b35fbb
Avoid looking up settings during timeline rendering ( #8313 )
...
* Avoid showHiddenEventsInTimeline lookups
* Avoid MSC3531 feature lookups
* Test that showHiddenEventsInTimeline doesn't get looked up while
rendering
* Fix code review nits
Co-authored-by: Travis Ralston <travisr@matrix.org>
2022-04-14 23:23:22 +00:00
David Baker
285dc25b3e
Add a test for URL previews being disabled in e2e rooms ( #8270 )
...
* Add a test for URL previews being disabled in e2e rooms
Regression test for https://github.com/matrix-org/matrix-react-sdk/pull/8227
* Fix the types
2022-04-08 18:32:35 +01:00
Travis Ralston
5137fcf3e8
Remove unit test function which isn't needed
...
The import ordering no longer requires us to create an injector function.
2022-03-31 19:43:17 -06:00
Travis Ralston
661b8d595c
Step 8.7: Introduce focus-visible
import where needed to repair tests
...
There is an import in `MatrixChat` which no longer gets executed when we don't skin the entire app, so bring it in manually.
2022-03-28 14:02:31 -06:00
Travis Ralston
4144d0ba57
Step 8.5: Isolate RightPanelStore from RoomViewStore
2022-03-28 14:02:31 -06:00
Travis Ralston
a987ead7d2
Step 8.1: Remove skinning setup from all tests
2022-03-28 14:02:31 -06:00
Travis Ralston
26dc2ba45e
Step 3.1: Stop using getComponent
in tests
2022-03-28 14:02:31 -06:00
Robin
1e060fed84
Don't form continuations from thread roots ( #8166 )
...
* Don't form continuations from thread roots
* Only apply the continuation break in the main timeline
2022-03-26 18:06:25 -04:00
Travis Ralston
fce36ec826
Delete groups (legacy communities system) ( #8027 )
...
* Remove deprecated feature_communities_v2_prototypes
* Update _components
* i18n
* delint
* Cut out a bit more dead code
* Carve into legacy components
* Carve into mostly the room list code
* Carve into instances of "groupId"
* Carve out more of what comes up with "groups"
* Carve out some settings
* ignore related groups state
* Remove instances of spacesEnabled
* Fix some obvious issues
* Remove now-unused css
* Fix variable naming for legacy components
* Update i18n
* Misc cleanup from manual review
* Update snapshot for changed flag
* Appease linters
* rethemedex
* Remove now-unused AddressPickerDialog
* Make ConfirmUserActionDialog's member a required prop
* Remove useless override from RightPanelStore
* Remove extraneous CSS
* Update i18n
* Demo: "Communities are now Spaces" landing page
* Restore linkify for group IDs
* Demo: Dialog on click for communities->spaces notice
* i18n for demos
* i18n post-merge
* Update copy
* Appease the linter
* Post-merge cleanup
* Re-add spaces_learn_more_url to the new SdkConfig place
* Round 1 of post-merge fixes
* i18n
Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>
2022-03-22 23:07:37 +00:00
Travis Ralston
d8a939df5d
Use & enforce snake_case naming convention on config.json settings ( #8062 )
...
* Document and support the established naming convention for config opts
This change:
* Rename `ConfigOptions` to `IConfigOptions` to match code convention/style, plus move it to a dedicated file
* Update comments and surrounding documentation
* Define every single documented option (from element-web's config.md)
* Enable a linter to enforce the convention
* Invent a translation layer for a different change to use
* No attempt to fix build errors from doing this (at this stage)
* Add demo of lint rule in action
* Fix all obvious instances of SdkConfig case conflicts
* Fix tests to use SdkConfig directly
* Add docs to make unset() calling safer
* Appease the linter
* Update documentation to match snake_case_config
* Fix more instances of square brackets off SdkConfig
2022-03-18 10:12:36 -06:00
Germain
12d26555af
Move timeline set creation logic to the JS SDK ( #8070 )
2022-03-18 11:59:03 +00:00
Kerry
bc8fdac491
fix more type issues in unit tests ( #8053 )
...
* fix ts issues in test/components/structures
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix ts issues in test/components/views/context_menus
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-03-15 10:30:48 +01:00
Germain
21d3cb08a9
Switch to using stable values for threads ( #8019 )
2022-03-11 09:04:22 +00:00
Michael Telatynski
782ce016d1
Wrap EventTile rather than its children in an error boundary ( #7945 )
2022-03-09 11:22:36 +00:00
Michael Telatynski
0e60ad98c1
Hide composer and call buttons when the room is tombstoned ( #7975 )
2022-03-04 15:53:22 +00:00
Robin
aadb64615f
Fix duplicate EventListSummarys ( #7952 )
...
* Fix duplicate EventListSummarys
Signed-off-by: Robin Townsend <robin@robin.town>
* Add regression test
Signed-off-by: Robin Townsend <robin@robin.town>
2022-03-02 11:46:51 -05:00
Germain
d01ea1824b
[Update thread info after MSC3440 updates] ( #7911 )
2022-03-02 10:52:14 +00:00
Michael Telatynski
f25e6813bb
Mandate use of js-sdk/src/matrix import over js-sdk/src ( #7933 )
2022-03-01 20:42:05 +00:00
Michael Telatynski
482d756bd0
Ensure EventListSummary key does not change during backpagination ( #7915 )
2022-03-01 08:33:07 +00:00
Kerry
889b0cebb2
Fix 'my threads' filtering to include participated threads ( #7882 )
...
* move js utils into directory
Signed-off-by: Kerry Archibald <kerrya@element.io>
* typescripterize js test-utils
Signed-off-by: Kerry Archibald <kerrya@element.io>
* move test utils to directory
Signed-off-by: Kerry Archibald <kerrya@element.io>
* move remaining mock functions to directory
Signed-off-by: Kerry Archibald <kerrya@element.io>
* update imports
Signed-off-by: Kerry Archibald <kerrya@element.io>
* missed copyright
Signed-off-by: Kerry Archibald <kerrya@element.io>
* threads test helpers
Signed-off-by: Kerry Archibald <kerrya@element.io>
* forgotten copyright
Signed-off-by: Kerry Archibald <kerrya@element.io>
* comments
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix threads helper unsigned
Signed-off-by: Kerry Archibald <kerrya@element.io>
* test filter creation when thread capabilities enabled
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-02-24 09:44:34 +01:00
Kerry
5e76d988ca
convert test-utils to typescript ( #7877 )
...
* move js utils into directory
Signed-off-by: Kerry Archibald <kerrya@element.io>
* typescripterize js test-utils
Signed-off-by: Kerry Archibald <kerrya@element.io>
* move test utils to directory
Signed-off-by: Kerry Archibald <kerrya@element.io>
* move remaining mock functions to directory
Signed-off-by: Kerry Archibald <kerrya@element.io>
* update imports
Signed-off-by: Kerry Archibald <kerrya@element.io>
* missed copyright
Signed-off-by: Kerry Archibald <kerrya@element.io>
* type wait for update
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-02-23 11:21:11 +00:00
Kerry
8b9263c808
Clean up some unit test logs ( #7857 )
...
* kill some unit test logs in arrays-test
Signed-off-by: Kerry Archibald <kerrya@element.io>
* remove mock logs that are asserted against anyway
* remove more logs
Signed-off-by: Kerry Archibald <kerrya@element.io>
* fix safeCOunterpartTranslate warnings in tests
Signed-off-by: Kerry Archibald <kerrya@element.io>
* more safeCounterpartTranslate warnings
Signed-off-by: Kerry Archibald <kerrya@element.io>
* lint
Signed-off-by: Kerry Archibald <kerrya@element.io>
* remove more logs
Signed-off-by: Kerry Archibald <kerrya@element.io>
* add helper
Signed-off-by: Kerry Archibald <kerrya@element.io>
* naming
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-02-21 16:57:44 +00:00
J. Ryan Stinnett
a939184e10
Tear down AppTile using lifecycle tracking ( #7833 )
2022-02-17 16:30:36 +00:00
J. Ryan Stinnett
0dc1355441
Fix right panel data flow ( #7811 )
2022-02-16 11:19:28 +00:00
Michael Telatynski
714136d4f7
Consolidate RedactionGrouper and HiddenEventGrouper into MELS ( #7739 )
2022-02-09 10:51:12 +00:00
Germain
544957bdad
Use typographical quotes in no threads UI ( #7713 )
2022-02-07 15:13:34 +00:00
Kerry
cb1c94dd2b
Fix leaks in Login unit tests ( #7704 )
...
* make Login-test tsx, fix leaks
Signed-off-by: Kerry Archibald <kerrya@element.io>
* missed lint
Signed-off-by: Kerry Archibald <kerrya@element.io>
2022-02-02 11:18:55 +00:00
Michael Telatynski
f2249b3e37
Fix CallEventGrouper map building to not occur during a Render phase ( #7638 )
2022-01-27 11:08:28 +00:00
Michael Telatynski
3c1ce77d48
Properly maintain aspect ratio of inline images ( #7503 )
2022-01-10 15:32:06 +00:00
Eric Eastwood
9289c0c90f
Refactor ContextMenu
to use RovingTabIndex
(more consistent keyboard navigation accessibility) ( #7353 )
...
Split off from https://github.com/matrix-org/matrix-react-sdk/pull/7339
2021-12-17 11:08:56 -06:00
Aaron Raimist
2e8a93834b
Auto fix
...
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2021-12-09 09:10:23 +00:00
Aaron Raimist
7b94e13a84
Merge branch 'develop' into sort-imports
...
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2021-12-09 08:34:20 +00:00
Kerry
697b5d28b3
fix leaking registration test ( #7304 )
...
Signed-off-by: Kerry Archibald <kerrya@element.io>
2021-12-08 10:34:24 +01:00
Michael Telatynski
fe24c8ad2a
Improve ThreadPanel ctx menu accessibility ( #7217 )
2021-11-29 17:42:53 +00:00