PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Use React.PureComponent instead of reimplementing it

Browse source
This commit is contained in:
Luke Barnard 2018-03-15 13:09:29 +00:00
parent 04b1678c7f
commit fd8b36eb1c
1 changed files with 1 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/components/views/rooms/DNDRoomTile.js
View file

@ -20,7 +20,7 @@ import RoomTile from 'matrix-react-sdk/lib/components/views/rooms/RoomTile';
import classNames from 'classnames'; import classNames from 'classnames';
export default class DNDRoomTile extends React.Component { export default class DNDRoomTile extends React.PureComponent {
constructor() { constructor() {
super(); super();
this.getClassName = this.getClassName.bind(this); this.getClassName = this.getClassName.bind(this);
@ -33,17 +33,6 @@ export default class DNDRoomTile extends React.Component {
}); });
} }
shouldComponentUpdate(nextProps, nextState) {
// Do a shallow comparison of the props that we pass through (there is no
// state to check).
// NB: We might want to ignore changes to index in future if reordering
// occurs (all indices of all tiles in the sublist will change).
if (Object.keys(nextProps).some((k) => nextProps[k] !== this.props[k])) {
return true;
}
return false;
}
render() { render() {
const props = this.props; const props = this.props;