PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #3067 from vector-im/matthew/fix-badge-spam

Browse source 
only recalculate favicon if it changes
This commit is contained in:
David Baker 2017-01-26 11:44:11 +00:00 committed by GitHub
commit f9db7f017d
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/vector/platform/ElectronPlatform.js
View file

@ -58,6 +58,7 @@ function platformFriendlyName() {
export default class ElectronPlatform extends VectorBasePlatform { export default class ElectronPlatform extends VectorBasePlatform {
setNotificationCount(count: number) { setNotificationCount(count: number) {
if (this.notificationCount === number) return;
super.setNotificationCount(count); super.setNotificationCount(count);
// this sometimes throws because electron is made of fail: // this sometimes throws because electron is made of fail:
// https://github.com/electron/electron/issues/7351 // https://github.com/electron/electron/issues/7351

2
src/vector/platform/WebPlatform.js
View file

@ -60,11 +60,13 @@ export default class WebPlatform extends VectorBasePlatform {
} }
setNotificationCount(count: number) { setNotificationCount(count: number) {
if (this.notificationCount === number) return;
super.setNotificationCount(count); super.setNotificationCount(count);
this._updateFavicon(); this._updateFavicon();
} }
setErrorStatus(errorDidOccur: boolean) { setErrorStatus(errorDidOccur: boolean) {
if (this.errorDidOccur === errorDidOccur) return;
super.setErrorStatus(errorDidOccur); super.setErrorStatus(errorDidOccur);
this._updateFavicon(); this._updateFavicon();
} }