PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

remove specific timeout for selectors

Browse source 
as these are not hard sleeps, but timeouts, its better to put them
a bit larger, as in the best case they'll return quickly anyway
and in the worst case where they need a lot of time it's still better
if the tests don't fail
This commit is contained in:
Bruno Windels 2018-08-23 00:29:24 +02:00
parent fd67ace078
commit f49b85897d
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/tests/accept-invite.js
View file

@ -20,7 +20,7 @@ const {acceptDialogMaybe} = require('./dialog');
module.exports = async function acceptInvite(session, name) {
session.log.step(`accepts "${name}" invite`);
//TODO: brittle selector
const invitesHandles = await session.waitAndQueryAll('.mx_RoomTile_name.mx_RoomTile_invite', 1000);
const invitesHandles = await session.waitAndQueryAll('.mx_RoomTile_name.mx_RoomTile_invite');
const invitesWithText = await Promise.all(invitesHandles.map(async (inviteHandle) => {
const text = await session.innerText(inviteHandle);
return {inviteHandle, text};
@ -38,4 +38,4 @@ module.exports = async function acceptInvite(session, name) {
acceptDialogMaybe(session, "encryption");
session.log.done();
}
}

2
src/tests/consent.js
View file

@ -17,7 +17,7 @@ limitations under the License.
const assert = require('assert');
module.exports = async function acceptTerms(session) {
const reviewTermsButton = await session.waitAndQuery('.mx_QuestionDialog button.mx_Dialog_primary', 5000);
const reviewTermsButton = await session.waitAndQuery('.mx_QuestionDialog button.mx_Dialog_primary');
const termsPagePromise = session.waitForNewPage();
await reviewTermsButton.click();
const termsPage = await termsPagePromise;

4
src/tests/dialog.js
View file

@ -27,7 +27,7 @@ async function acceptDialog(session, expectedContent) {
async function acceptDialogMaybe(session, expectedContent) {
let dialog = null;
try {
dialog = await session.waitAndQuery(".mx_QuestionDialog", 100);
dialog = await session.waitAndQuery(".mx_QuestionDialog");
} catch(err) {
return false;
}
@ -44,4 +44,4 @@ async function acceptDialogMaybe(session, expectedContent) {
module.exports = {
acceptDialog,
acceptDialogMaybe,
};
};

2
src/tests/server-notices-consent.js
View file

@ -19,7 +19,7 @@ const acceptInvite = require("./accept-invite")
module.exports = async function acceptServerNoticesInviteAndConsent(session) {
await acceptInvite(session, "Server Notices");
session.log.step(`accepts terms & conditions`);
const consentLink = await session.waitAndQuery(".mx_EventTile_body a", 1000);
const consentLink = await session.waitAndQuery(".mx_EventTile_body a");
const termsPagePromise = session.waitForNewPage();
await consentLink.click();
const termsPage = await termsPagePromise;