PrivateCoffee/element-web
4
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Convert away from Promise.defer

Browse source 
`Promise.defer` is deprecated in Bluebird and it logs loudly each time it's
called. This cleans up testing logs significantly by converting away from it.
This commit is contained in:
J. Ryan Stinnett 2019-03-26 12:46:26 +00:00
parent 7ac117f964
commit f321aba4ac
1 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
test/app-tests/loading.js
View file

@ -123,9 +123,6 @@ describe('loading:', function() {
toString: function() { return this.search + this.hash; }, toString: function() { return this.search + this.hash; },
}; };
const tokenLoginCompleteDefer = Promise.defer();
tokenLoginCompletePromise = tokenLoginCompleteDefer.promise;
function onNewScreen(screen) { function onNewScreen(screen) {
console.log(Date.now() + " newscreen "+screen); console.log(Date.now() + " newscreen "+screen);
const hash = '#/' + screen; const hash = '#/' + screen;
@ -157,18 +154,21 @@ describe('loading:', function() {
PlatformPeg.set(new WebPlatform()); PlatformPeg.set(new WebPlatform());
const params = parseQs(windowLocation); const params = parseQs(windowLocation);
matrixChat = ReactDOM.render(
<MatrixChat tokenLoginCompletePromise = new Promise(resolve => {
onNewScreen={onNewScreen} matrixChat = ReactDOM.render(
config={config} <MatrixChat
realQueryParams={params} onNewScreen={onNewScreen}
startingFragmentQueryParams={fragParts.params} config={config}
enableGuest={true} realQueryParams={params}
onTokenLoginCompleted={() => tokenLoginCompleteDefer.resolve()} startingFragmentQueryParams={fragParts.params}
initialScreenAfterLogin={getScreenFromLocation(windowLocation)} enableGuest={true}
makeRegistrationUrl={() => {throw new Error('Not implemented');}} onTokenLoginCompleted={resolve}
/>, parentDiv, initialScreenAfterLogin={getScreenFromLocation(windowLocation)}
); makeRegistrationUrl={() => {throw new Error('Not implemented');}}
/>, parentDiv,
);
});
} }
// set an expectation that we will get a call to /sync, then flush // set an expectation that we will get a call to /sync, then flush