Merge pull request #5638 from uhoreg/use_default_ssss_key

Use the default SSSS key if the default is set
This commit is contained in:
Hubert Chathi 2021-02-25 15:13:50 -05:00 committed by GitHub
commit f1330b7359
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -98,11 +98,27 @@ async function getSecretStorageKey(
{ keys: keyInfos }: { keys: Record<string, ISecretStorageKeyInfo> }, { keys: keyInfos }: { keys: Record<string, ISecretStorageKeyInfo> },
ssssItemName, ssssItemName,
): Promise<[string, Uint8Array]> { ): Promise<[string, Uint8Array]> {
const keyInfoEntries = Object.entries(keyInfos); const cli = MatrixClientPeg.get();
if (keyInfoEntries.length > 1) { let keyId = await cli.getDefaultSecretStorageKeyId();
throw new Error("Multiple storage key requests not implemented"); let keyInfo;
if (keyId) {
// use the default SSSS key if set
keyInfo = keyInfos[keyId];
if (!keyInfo) {
// if the default key is not available, pretend the default key
// isn't set
keyId = undefined;
}
}
if (!keyId) {
// if no default SSSS key is set, fall back to a heuristic of using the
// only available key, if only one key is set
const keyInfoEntries = Object.entries(keyInfos);
if (keyInfoEntries.length > 1) {
throw new Error("Multiple storage key requests not implemented");
}
[keyId, keyInfo] = keyInfoEntries[0];
} }
const [keyId, keyInfo] = keyInfoEntries[0];
// Check the in-memory cache // Check the in-memory cache
if (isCachingAllowed() && secretStorageKeys[keyId]) { if (isCachingAllowed() && secretStorageKeys[keyId]) {